Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: ClamAV: devel

is this check valuable?

 

 

ClamAV devel RSS feed   Index | Next | Previous | View Threaded


steve at lobefin

Feb 18, 2007, 5:21 PM

Post #1 of 2 (805 views)
Permalink
is this check valuable?

Hello all,

In clamav-milter.c, I see:
/*
* Using TCP/IP for the sendmail->clamav-milter connection
*/
if((hostmail = smfi_getsymval(ctx, "{if_name}")) == NULL) {
if(use_syslog)
syslog(LOG_ERR, _("Can't get sendmail hostname"));
return cl_error;
}

However, I see here:
http://www.milter.info/sendmail/milter-ahead/CHANGES.TXT

When {if_addr}, {if_name}, and j macros are underfined fall
back onto the value of interface-name instead of "[127.0.0.1]"
for use with the call-ahead HELO.

And here:
http://blog.gmane.org/gmane.mail.postfix.devel/page=5

{if_name} interface name client connected to;
NULL for loopback

Both of these lead me to believe that it is a valid condition for
{if_name} to be NULL.

So I am curious what the value of the check is. This all came up
because a Debian user was trying to use postfix with clamav-milter over
a tcp socket. It is unclear to me whether postfix just does not set
this macro, or if it was a problem of a connection over lo.

So, my question is: if {if_name} returns NULL on loopback connections,
is the test in clamav-milter.c valid? Or should it just set hostmail to
127.0.0.1 in this case? Or am I missing something and this is a postfix
problem that we should not try to support? I admit to not knowing the
milter API all that well, so I can easily believe I'm missing something
here.

Thanks,
--
--------------------------------------------------------------------------
| Stephen Gran | You will pioneer the first Martian |
| steve [at] lobefin | colony. |
| http://www.lobefin.net/~steve | |
--------------------------------------------------------------------------
Attachments: signature.asc (0.18 KB)


steve at lobefin

Feb 21, 2007, 4:55 AM

Post #2 of 2 (724 views)
Permalink
Re: (clamav-milter) is this check valuable? [In reply to]

On Mon, Feb 19, 2007 at 01:21:33AM +0000, Stephen Gran said:
> Hello all,
>
> In clamav-milter.c, I see:

I've changed the subject a bit to try to catch Nigel's attention. Sorry
about following up to myself.
--
--------------------------------------------------------------------------
| Stephen Gran | Oh my GOD -- the SUN just fell into |
| steve [at] lobefin | YANKEE STADIUM!! |
| http://www.lobefin.net/~steve | |
--------------------------------------------------------------------------
Attachments: signature.asc (0.18 KB)

ClamAV devel RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.