Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: Cherokee: dev

Issue 796 in cherokee: Proxy handler utf8 based request extremely bad

 

 

Cherokee dev RSS feed   Index | Next | Previous | View Threaded


cherokee at googlecode

Apr 4, 2010, 1:16 PM

Post #1 of 25 (1087 views)
Permalink
Issue 796 in cherokee: Proxy handler utf8 based request extremely bad

Status: Accepted
Owner: ste...@konink.de
Labels: Type-Defect Priority-High OpSys-All Component-Logic Usability

New issue 796 by ste...@konink.de: Proxy handler utf8 based request
extremely bad
http://code.google.com/p/cherokee/issues/detail?id=796

What steps will reproduce the problem?
1. send a request with an encoded utf8 char
2. observe that the request is proper decoded
3. see that the request is not propely encoded
4. observe that the request is not properly decoded at the remote site


--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
_______________________________________________
Cherokee-dev mailing list
Cherokee-dev [at] lists
http://lists.octality.com/listinfo/cherokee-dev


cherokee at googlecode

Apr 4, 2010, 1:23 PM

Post #2 of 25 (1069 views)
Permalink
Re: Issue 796 in cherokee: Proxy handler utf8 based request extremely bad [In reply to]

Comment #1 on issue 796 by ste...@konink.de: Proxy handler utf8 based
request extremely bad
http://code.google.com/p/cherokee/issues/detail?id=796

handler_proxy.c:0684 ( cherokee_handler_proxy_init): Entering
init 'get conn'
handler_proxy.c:0722 ( cherokee_handler_proxy_init): Entering
phase 'preconnect'
handler_proxy.c:0743 ( cherokee_handler_proxy_init): Entering
phase 'connect':
pconn=0x76c760
handler_proxy.c:0801 ( cherokee_handler_proxy_init): Entering
phase 'build
headers'
handler_proxy.c:0299 ( add_request): Client request:
'/api/select%20x.kvk,%20x.bedrijfsnaam,%20x.adres,%20x.postcode,%20x.plaats,%20x.type
,%20not(anbikvk.kvks%20is%20null%20AND%20anbikvk.intrekking%20is%20null)%20as%20"anbi
",%20status,%20x.kvks,%20x.sub%20from%20(select%20kvk.kvk,%20kvk.bedrijfsnaam,%20kvk.
adres,%20kvk.postcode,%20kvk.plaats,%20kvk.type,%20kvk.kvks,%20kvk.sub%20FROM%20sphin
x_searchIndex('Caf%�3%�9',%20'openkvk')%20as%20fts,%20kvk%20where%20kvk.kvk%20=%20f
ts.id)%20as%20x%20LEFT%20JOIN%20anbikvk%20ON%20x.kvks%20=%20anbikvk.kvks%20LEFT%20JOI
N%20faillissementen%20ON%20x.kvks%20=%20faillissementen.kvk%20LIMIT%20200%20OFFSET%20
0;'
handler_proxy.c:0816 ( cherokee_handler_proxy_init): Entering
phase 'send
headers'
GET
http://api.openkvk.nl/json/select%20x.kvk,%20x.bedrijfsnaam,%20x.adres,%20x.postcode,
%20x.plaats,%20x.type,%20not(anbikvk.kvks%20is%20null%20AND%20anbikvk.intrekking%20is
%20null)%20as%20"anbi",%20status,%20x.kvks,%20x.sub%20from%20(select%20kvk.kvk,%20kvk
.bedrijfsnaam,%20kvk.adres,%20kvk.postcode,%20kvk.plaats,%20kvk.type,%20kvk.kvks,%20k
vk.sub%20FROM%20sphinx_searchIndex('Caf%�3%�9',%20'openkvk')%20as%20fts,%20kvk%20wh
ere%20kvk.kvk%20=%20fts.id)%20as%20x%20LEFT%20JOIN%20anbikvk%20ON%20x.kvks%20=%20anbi
kvk.kvks%20LEFT%20JOIN%20faillissementen%20ON%20x.kvks%20=%20faillissementen.kvk%20LI
MIT%20200%20OFFSET%200; HTTP/1.1
Host: 127.0.0.1
Connection: Keep-Alive
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US) AppleWebKit/532.8
(KHTML, like
Gecko) Chrome/4.0.295.0 Safari/532.8
Referer: http://www.openkvk.nl/
Cache-Control: max-age=0
X-Requested-With: XMLHttpRequest
Accept: application/json, text/javascript, */*
Accept-Encoding: gzip,deflate,sdch
Accept-Language: nl-NL,nl;q=0.8,en-US;q=0.6,en;q=0.4
Accept-Charset: ISO-8859-1,utf-8;q=0.7,*;q=0.3
X-Forwarded-For: 2001:610:600:4e7::2
X-Real-IP: 2001:610:600:4e7::2
X-Forwarded-Host: www.openkvk.nl
X-Forwarded-SSL: off

handler_proxy.c:0846 ( cherokee_handler_proxy_init): Entering
phase 'send post'
handler_proxy.c:0877 ( cherokee_handler_proxy_init): Entering
phase 'read
header'
select x.kvk, x.bedrijfsnaam, x.adres, x.postcode, x.plaats, x.type,
not(anbikvk.kvks
is null AND anbikvk.intrekking is null) as "anbi", status, x.kvks, x.sub
from (select
kvk.kvk, kvk.bedrijfsnaam, kvk.adres, kvk.postcode, kvk.plaats, kvk.type,
kvk.kvks,
kvk.sub FROM sphinx_searchIndex('Caf%�3%�9', 'openkvk') as fts, kvk where
kvk.kvk =
fts.id) as x LEFT JOIN anbikvk ON x.kvks = anbikvk.kvks LEFT JOIN
faillissementen ON
x.kvks = faillissementen.kvk LIMIT 200 OFFSET 0;
handler_proxy.c:0931 ( cherokee_handler_proxy_init): Exiting init
handler_proxy.c:1134 ( parse_server_header): IN - Header:
HTTP/1.1 200 OK
Connection: Keep-Alive
Keep-Alive: timeout=15
Transfer-Encoding: chunked
Date: Sun, 04 Apr 2010 20:22:22 GMT
Server: Cherokee/0.99.45b4715 (UNIX)
Expires: Sun, 04 Apr 2010 20:27:22 GMT
Cache-Control: max-age=300
Content-Encoding: gzip
Vary: Accept-Encoding
Content-Type: application/json

handler_proxy.c:1135 ( parse_server_header): IN - Keepalive: 1
handler_proxy.c:1136 ( parse_server_header): IN - Encoding:
chunked
handler_proxy.c:1137 ( parse_server_header): IN - Size: 0
handler_proxy.c:1138 ( parse_server_header): OUT - Header:
Date: Sun, 04 Apr 2010 20:22:22 GMT
Server: Cherokee/0.99.45b4715 (UNIX)
Expires: Sun, 04 Apr 2010 20:27:22 GMT
Cache-Control: max-age=300
Content-Encoding: gzip
Vary: Accept-Encoding
Content-Type: application/json
handler_proxy.c:1182 (cherokee_handler_proxy_add_headers): Added reply
headers
(len=222)
handler_proxy.c:1470 ( cherokee_handler_proxy_free): Did not get all,
turning
keepalive off


--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
_______________________________________________
Cherokee-dev mailing list
Cherokee-dev [at] lists
http://lists.octality.com/listinfo/cherokee-dev


cherokee at googlecode

Apr 4, 2010, 1:41 PM

Post #3 of 25 (1072 views)
Permalink
Re: Issue 796 in cherokee: Proxy handler utf8 based request extremely bad [In reply to]

Comment #2 on issue 796 by ste...@konink.de: Proxy handler utf8 based
request extremely bad
http://code.google.com/p/cherokee/issues/detail?id=796

How is this suppose to work?

/* Build the URL
*/
ret = cherokee_buffer_escape_uri (tmp, &conn->request);
if (ret != ret_ok) {
return ret_error;
}

Why are we escaping the URI before the rewrite took place. A user is now
not able to
match special characters right?


if (! cherokee_buffer_is_empty (&conn->pathinfo)) {
ret = cherokee_buffer_escape_uri (tmp, &conn->pathinfo);
if (ret != ret_ok) {
return ret_error;
}
}

Uuuuh? cherokee_buffer_escape_uri with only the pathinfo? Isn't this a bug
by
default?


if (! cherokee_buffer_is_empty (&conn->query_string)) {
cherokee_buffer_add_char (tmp, '?');

ret = cherokee_buffer_add_buffer (tmp, &conn->query_string);
if (ret != ret_ok) {
return ret_error;
}
}

So why isn't the query_string escaped?

TRACE(ENTRIES, "Client request: '%s'\n", tmp->buf);

/* Check the regexs
*/
re = replace_againt_regex_list (tmp, buf,
&props->in_request_regexs);
if (re == 0) {
/* Did not match any regex, use the raw URL
*/
cherokee_buffer_add_buffer (buf, tmp);
}

I think this should be the first thing that is done.

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
_______________________________________________
Cherokee-dev mailing list
Cherokee-dev [at] lists
http://lists.octality.com/listinfo/cherokee-dev


cherokee at googlecode

Apr 6, 2010, 1:07 PM

Post #4 of 25 (1065 views)
Permalink
Re: Issue 796 in cherokee: Proxy handler utf8 based request extremely bad [In reply to]

Updates:
Blockedon: 797

Comment #3 on issue 796 by ste...@konink.de: Proxy handler utf8 based
request extremely bad
http://code.google.com/p/cherokee/issues/detail?id=796

I reshuffled the output to:

static ret_t
add_request (cherokee_handler_proxy_t *hdl,
cherokee_buffer_t *buf)
{
int re;
ret_t ret;
cherokee_connection_t *conn = HANDLER_CONN(hdl);
cherokee_buffer_t *tmp =
&HANDLER_THREAD(hdl)->tmp_buf1;
cherokee_buffer_t *tmp2 =
&HANDLER_THREAD(hdl)->tmp_buf2;
cherokee_handler_proxy_props_t *props = HDL_PROXY_PROPS(hdl);

cherokee_buffer_clean (tmp);

/* Build the URL
*/

ret = cherokee_buffer_add_buffer(tmp, &conn->request);
if (ret != ret_ok) {
return ret_error;
}

ret = cherokee_buffer_add_buffer(tmp, &conn->pathinfo);
if (ret != ret_ok) {
return ret_error;
}

if (! cherokee_buffer_is_empty (&conn->query_string)) {
cherokee_buffer_add_char (tmp, '?');
ret = cherokee_buffer_add_buffer (tmp, &conn->query_string);
if (ret != ret_ok) {
return ret_error;
}
}

TRACE(ENTRIES, "Client request: '%s'\n", tmp->buf);

/* Check the regexs
*/
re = replace_againt_regex_list (tmp, tmp2,
&props->in_request_regexs);
if (re == 0) {
/* Did not match any regex, use the raw URL
*/
ret = cherokee_buffer_escape_uri (buf, tmp);
} else {
ret = cherokee_buffer_escape_uri (buf, tmp2);
}

if (ret != ret_ok) {
return ret_error;
}
return ret_ok;
}


--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
_______________________________________________
Cherokee-dev mailing list
Cherokee-dev [at] lists
http://lists.octality.com/listinfo/cherokee-dev


cherokee at googlecode

Apr 6, 2010, 3:41 PM

Post #5 of 25 (1064 views)
Permalink
Re: Issue 796 in cherokee: Proxy handler utf8 based request extremely bad [In reply to]

Comment #4 on issue 796 by ste...@konink.de: Proxy handler utf8 based
request extremely bad
http://code.google.com/p/cherokee/issues/detail?id=796

last comment has bugs...

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
_______________________________________________
Cherokee-dev mailing list
Cherokee-dev [at] lists
http://lists.octality.com/listinfo/cherokee-dev


cherokee at googlecode

Apr 30, 2010, 12:38 AM

Post #6 of 25 (1007 views)
Permalink
Re: Issue 796 in cherokee: Proxy handler utf8 based request extremely bad [In reply to]

Updates:
Status: New
Owner: alobbs

Comment #5 on issue 796 by alobbs: Proxy handler utf8 based request
extremely bad
http://code.google.com/p/cherokee/issues/detail?id=796

I cannot reproduce this problem. I have tried with two different scenarios:

- Cherokee proxying Cherokee
- Cherokee proxying Apache

In both cases it managed to list and access a file named 'Café Rico'.

Stefan, could you please build a smalled test case we could use to
reproduce this problem. If it's actually a
bug, it'd be good to get it fixed before the 1.0 release next week.

_______________________________________________
Cherokee-dev mailing list
Cherokee-dev [at] lists
http://lists.octality.com/listinfo/cherokee-dev


cherokee at googlecode

Apr 30, 2010, 5:28 AM

Post #7 of 25 (1005 views)
Permalink
Re: Issue 796 in cherokee: Proxy handler utf8 based request extremely bad [In reply to]

Comment #6 on issue 796 by ste...@konink.de: Proxy handler utf8 based
request extremely bad
http://code.google.com/p/cherokee/issues/detail?id=796

Since Pigmej can reproduce it as well I don't see I how I can make it any
more clear
than it is now. Try a proxy to a dbslayer instance...

Did you check it on OSX or on Linux?

_______________________________________________
Cherokee-dev mailing list
Cherokee-dev [at] lists
http://lists.octality.com/listinfo/cherokee-dev


cherokee at googlecode

Apr 30, 2010, 5:59 AM

Post #8 of 25 (1004 views)
Permalink
Re: Issue 796 in cherokee: Proxy handler utf8 based request extremely bad [In reply to]

Comment #7 on issue 796 by alobbs: Proxy handler utf8 based request
extremely bad
http://code.google.com/p/cherokee/issues/detail?id=796

Alright, I'll give it a try on Linux.. although I don't think it'll make
any difference.

_______________________________________________
Cherokee-dev mailing list
Cherokee-dev [at] lists
http://lists.octality.com/listinfo/cherokee-dev


cherokee at googlecode

Apr 30, 2010, 6:03 AM

Post #9 of 25 (1006 views)
Permalink
Re: Issue 796 in cherokee: Proxy handler utf8 based request extremely bad [In reply to]

Comment #8 on issue 796 by ste...@konink.de: Proxy handler utf8 based
request extremely bad
http://code.google.com/p/cherokee/issues/detail?id=796

I wonder if it could be a LC_ALL kind of thing.

_______________________________________________
Cherokee-dev mailing list
Cherokee-dev [at] lists
http://lists.octality.com/listinfo/cherokee-dev


cherokee at googlecode

May 4, 2010, 8:56 AM

Post #10 of 25 (988 views)
Permalink
Re: Issue 796 in cherokee: Proxy handler utf8 based request extremely bad [In reply to]

Comment #9 on issue 796 by ste...@konink.de: Proxy handler utf8 based
request extremely bad
http://code.google.com/p/cherokee/issues/detail?id=796

Setup:
Host1 = Reverse Proxy
Host2 = Reverse Proxy and MySQL bridge

Indirect request to Host2 via Reverse Proxy + MySQL bridge works;
wget -O test "http://70.38.69.142:9091/select 'Café';"

Direct request to Host2 via MySQL bridge works;
wget -O test "http://70.38.69.142:9091/mysql/select 'Café';"

All indirect requests from Host1 to Host2 fail:
wget -O test "http://127.0.0.1/select 'Café';"


Differences:
[{"RESULT":{"TYPES":["MYSQL_TYPE_VAR_STRING"],"HEADER":["Café"],"ROWS":[["Café"]]}}]

vs

[{"RESULT":{"TYPES":["MYSQL_TYPE_VAR_STRING"],"HEADER":["Caf%�3%�9"],"ROWS":[["Caf%
�3%�9"]]}}]

_______________________________________________
Cherokee-dev mailing list
Cherokee-dev [at] lists
http://lists.octality.com/listinfo/cherokee-dev


cherokee at googlecode

May 4, 2010, 9:05 AM

Post #11 of 25 (986 views)
Permalink
Re: Issue 796 in cherokee: Proxy handler utf8 based request extremely bad [In reply to]

Comment #10 on issue 796 by alobbs: Proxy handler utf8 based request
extremely bad
http://code.google.com/p/cherokee/issues/detail?id=796

The proxy will NEVER modify the content of the response body.. so the
problem must be in Dbslayer rather than
in the reverse proxy, actually.

_______________________________________________
Cherokee-dev mailing list
Cherokee-dev [at] lists
http://lists.octality.com/listinfo/cherokee-dev


cherokee at googlecode

May 4, 2010, 9:09 AM

Post #12 of 25 (988 views)
Permalink
Re: Issue 796 in cherokee: Proxy handler utf8 based request extremely bad [In reply to]

Comment #11 on issue 796 by pigmej: Proxy handler utf8 based request
extremely bad
http://code.google.com/p/cherokee/issues/detail?id=796

I confirm the Skinkie things....

_______________________________________________
Cherokee-dev mailing list
Cherokee-dev [at] lists
http://lists.octality.com/listinfo/cherokee-dev


cherokee at googlecode

May 4, 2010, 9:13 AM

Post #13 of 25 (987 views)
Permalink
Re: Issue 796 in cherokee: Proxy handler utf8 based request extremely bad [In reply to]

Comment #12 on issue 796 by ste...@konink.de: Proxy handler utf8 based
request extremely bad
http://code.google.com/p/cherokee/issues/detail?id=796

SELECT 'hello world'; returns 'hello world' in the body. This only shows
that the url
isn't decoded/sent properly.

_______________________________________________
Cherokee-dev mailing list
Cherokee-dev [at] lists
http://lists.octality.com/listinfo/cherokee-dev


cherokee at googlecode

May 4, 2010, 9:17 AM

Post #14 of 25 (989 views)
Permalink
Re: Issue 796 in cherokee: Proxy handler utf8 based request extremely bad [In reply to]

Comment #13 on issue 796 by alobbs: Proxy handler utf8 based request
extremely bad
http://code.google.com/p/cherokee/issues/detail?id=796

What happens when you comment out the following lines from
cherokee/handler_proxy.c (~line 278)?

======
ret = cherokee_buffer_escape_uri (tmp, &conn->request);
if (ret != ret_ok) {
return ret_error;
}
======


_______________________________________________
Cherokee-dev mailing list
Cherokee-dev [at] lists
http://lists.octality.com/listinfo/cherokee-dev


cherokee at googlecode

May 4, 2010, 9:25 AM

Post #15 of 25 (988 views)
Permalink
Re: Issue 796 in cherokee: Proxy handler utf8 based request extremely bad [In reply to]

Comment #14 on issue 796 by ste...@konink.de: Proxy handler utf8 based
request extremely bad
http://code.google.com/p/cherokee/issues/detail?id=796

2010-05-04 18:24:13 Fout 505: HTTP Version Not Supported.


_______________________________________________
Cherokee-dev mailing list
Cherokee-dev [at] lists
http://lists.octality.com/listinfo/cherokee-dev


cherokee at googlecode

May 4, 2010, 9:56 AM

Post #16 of 25 (985 views)
Permalink
Re: Issue 796 in cherokee: Proxy handler utf8 based request extremely bad [In reply to]

Comment #15 on issue 796 by ste...@konink.de: Proxy handler utf8 based
request extremely bad
http://code.google.com/p/cherokee/issues/detail?id=796

Reverted your suggestion; this is the communication between reverse proxy
and remote
system:

GET /select%20'Caf%.3%.9'; HTTP/1.0
Host: 70.38.69.142:9091
Connection: Keep-Alive
User-Agent: Wget/1.12 (linux-gnu)
Accept: */*
X-Forwarded-For: 127.0.0.1
X-Real-IP: 127.0.0.1
X-Forwarded-Host: 127.0.0.1
X-Forwarded-SSL: off

HTTP/1.0 200 OK
Connection: close
Date: Tue, 04 May 2010 16:53:53 GMT
Server: Cherokee/0.99.48 (UNIX)
Content-Type: application/json

[{"RESULT":{"TYPES":["MYSQL_TYPE_VAR_STRING"],"HEADER":["Caf%.3%.9"],"ROWS":[["Caf%.3
%.9"]]}}]


_______________________________________________
Cherokee-dev mailing list
Cherokee-dev [at] lists
http://lists.octality.com/listinfo/cherokee-dev


cherokee at googlecode

May 4, 2010, 10:01 AM

Post #17 of 25 (991 views)
Permalink
Re: Issue 796 in cherokee: Proxy handler utf8 based request extremely bad [In reply to]

Comment #16 on issue 796 by ste...@konink.de: Proxy handler utf8 based
request extremely bad
http://code.google.com/p/cherokee/issues/detail?id=796

Interestingly wireshark decodes it as:

/select%20'Caf%\3773%\3779'; HTTP/1.0\r\n

_______________________________________________
Cherokee-dev mailing list
Cherokee-dev [at] lists
http://lists.octality.com/listinfo/cherokee-dev


cherokee at googlecode

May 4, 2010, 10:24 AM

Post #18 of 25 (993 views)
Permalink
Re: Issue 796 in cherokee: Proxy handler utf8 based request extremely bad [In reply to]

Comment #17 on issue 796 by ste...@konink.de: Proxy handler utf8 based
request extremely bad
http://code.google.com/p/cherokee/issues/detail?id=796

ret = cherokee_buffer_escape_uri (tmp, &conn->request);

=>

ret = cherokee_buffer_add_buffer (tmp, &conn->request);

Gets a bad request, but interestingly the request becomes:
GET /select 'Caf..'; HTTP/1.0

.. = C3A9 (thus correct)


_______________________________________________
Cherokee-dev mailing list
Cherokee-dev [at] lists
http://lists.octality.com/listinfo/cherokee-dev


cherokee at googlecode

May 4, 2010, 2:34 PM

Post #19 of 25 (987 views)
Permalink
Re: Issue 796 in cherokee: Proxy handler utf8 based request extremely bad [In reply to]

Updates:
Status: WaitingQA
Owner: ste...@konink.de

Comment #18 on issue 796 by ste...@konink.de: Proxy handler utf8 based
request extremely bad
http://code.google.com/p/cherokee/issues/detail?id=796

Index: buffer.c
===================================================================
--- buffer.c (revision 5032)
+++ buffer.c (working copy)
@@ -1192,9 +1192,10 @@

for (i=0; i<src->len; i++) {
if (is_char_escaped[*s >> 5] & (1 << (*s & 0x1f))) {
+ unsigned char c = *s;
*t++ = '%';
- *t++ = hex_chars[*s >> 4];
- *t++ = hex_chars[*s & 0xf];
+ *t++ = hex_chars[c >> 4];
+ *t++ = hex_chars[c & 0xf];
s++;
} else {
*t++ = *s++;


_______________________________________________
Cherokee-dev mailing list
Cherokee-dev [at] lists
http://lists.octality.com/listinfo/cherokee-dev


cherokee at googlecode

May 4, 2010, 3:00 PM

Post #20 of 25 (988 views)
Permalink
Re: Issue 796 in cherokee: Proxy handler utf8 based request extremely bad [In reply to]

Comment #19 on issue 796 by ste...@konink.de: Proxy handler utf8 based
request extremely bad
http://code.google.com/p/cherokee/issues/detail?id=796

Issue 797 has been merged into this issue.

_______________________________________________
Cherokee-dev mailing list
Cherokee-dev [at] lists
http://lists.octality.com/listinfo/cherokee-dev


cherokee at googlecode

May 5, 2010, 1:18 AM

Post #21 of 25 (989 views)
Permalink
Re: Issue 796 in cherokee: Proxy handler utf8 based request extremely bad [In reply to]

Comment #20 on issue 796 by alobbs: Proxy handler utf8 based request
extremely bad
http://code.google.com/p/cherokee/issues/detail?id=796

Stefan, please.. give this one a try:

-----------
diff --git a/cherokee/buffer.c b/cherokee/buffer.c
index 9d04745..360115f 100644
--- a/cherokee/buffer.c
+++ b/cherokee/buffer.c
@@ -1164,10 +1164,11 @@ escape_with_table (cherokee_buffer_t *buffer,
cherokee_buffer_t *src,
uint32_t *is_char_escaped)
{
- cuint_t i;
- char *s, *t;
- cuint_t n_escape = 0;
- static char hex_chars[] = "0123456789abcdef";
+ cuint_t i;
+ unsigned char *s;
+ unsigned char *t;
+ cuint_t n_escape = 0;
+ static char hex_chars[] = "0123456789abcdef";

if (unlikely (src->buf == NULL)) {
return ret_error;
-----------

_______________________________________________
Cherokee-dev mailing list
Cherokee-dev [at] lists
http://lists.octality.com/listinfo/cherokee-dev


cherokee at googlecode

May 5, 2010, 2:29 AM

Post #22 of 25 (987 views)
Permalink
Re: Issue 796 in cherokee: Proxy handler utf8 based request extremely bad [In reply to]

Comment #21 on issue 796 by ste...@konink.de: Proxy handler utf8 based
request extremely bad
http://code.google.com/p/cherokee/issues/detail?id=796

Apply that one indeed :) Works!!

_______________________________________________
Cherokee-dev mailing list
Cherokee-dev [at] lists
http://lists.octality.com/listinfo/cherokee-dev


cherokee at googlecode

May 5, 2010, 2:50 AM

Post #23 of 25 (987 views)
Permalink
Re: Issue 796 in cherokee: Proxy handler utf8 based request extremely bad [In reply to]

Updates:
Status: Fixed

Comment #22 on issue 796 by alobbs: Proxy handler utf8 based request
extremely bad
http://code.google.com/p/cherokee/issues/detail?id=796

The patch is applied now:
http://svn.cherokee-project.com/changeset/5045

Great work Stefan. You've made my day! (two in a row) :-)

_______________________________________________
Cherokee-dev mailing list
Cherokee-dev [at] lists
http://lists.octality.com/listinfo/cherokee-dev


cherokee at googlecode

May 5, 2010, 2:57 AM

Post #24 of 25 (987 views)
Permalink
Re: Issue 796 in cherokee: Proxy handler utf8 based request extremely bad [In reply to]

Comment #23 on issue 796 by ste...@konink.de: Proxy handler utf8 based
request extremely bad
http://code.google.com/p/cherokee/issues/detail?id=796

Lets see what I can do tomorrow ;)

_______________________________________________
Cherokee-dev mailing list
Cherokee-dev [at] lists
http://lists.octality.com/listinfo/cherokee-dev


cherokee at googlecode

May 9, 2010, 1:12 PM

Post #25 of 25 (890 views)
Permalink
Re: Issue 796 in cherokee: Proxy handler utf8 based request extremely bad [In reply to]

Comment #24 on issue 796 by ste...@konink.de: Proxy handler utf8 based
request extremely bad
http://code.google.com/p/cherokee/issues/detail?id=796

Issue 556 has been merged into this issue.

_______________________________________________
Cherokee-dev mailing list
Cherokee-dev [at] lists
http://lists.octality.com/listinfo/cherokee-dev

Cherokee dev RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.