Mailing List Archive: Cherokee: dev

PATCH: Disabled Rules

Index | Next | Previous | View Threaded

aperez at skarcha

Nov 23, 2009, 11:15 AM

Post #1 of 18 (803 views)
Permalink

PATCH: Disabled Rules

Hello guys!

I've just finished what I think is an interesting patch... Sometimes I
need to remove some rules on cherokee-admin to test things, but the
right way, IMHO, is to disable them, make tests and enable them again.

Here is a patch that implements this feature... Could you please give
it a try and/or give your opinion?.

Thanks in advance... ;)

--
Saludos:
Antonio Pérez

Attachments:

disabled_rules.diff (4.62 KB)

stefan at konink

Nov 23, 2009, 1:13 PM

Post #2 of 18 (778 views)
Permalink

Re: PATCH: Disabled Rules [In reply to]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Antonio Pérez schreef:
> Here is a patch that implements this feature... Could you please give
> it a try and/or give your opinion?.

Without testing I already think you can close some enhancement requests ;)

Stefan
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.13 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEAREKAAYFAksK+wYACgkQYH1+F2Rqwn1xmACfXmmZksB6zyBB6pSpTFBgMsul
c2YAoJTkK3ikp9jJt3QXxNmNhJYkcObJ
=5wVL
-----END PGP SIGNATURE-----
_______________________________________________
Cherokee-dev mailing list
Cherokee-dev [at] lists
http://lists.octality.com/listinfo/cherokee-dev

alvaro at octality

Nov 23, 2009, 2:08 PM

Post #3 of 18 (774 views)
Permalink

Re: PATCH: Disabled Rules [In reply to]

On 23/11/2009, at 20:15, Antonio Pérez wrote:

> I've just finished what I think is an interesting patch... Sometimes I
> need to remove some rules on cherokee-admin to test things, but the
> right way, IMHO, is to disable them, make tests and enable them again.
>
> Here is a patch that implements this feature... Could you please give
> it a try and/or give your opinion?.

I like it, although I'm a bit concern about the potential usability penalty it may have.

I'd try to find a way to make clear how it works. Placing the checkbox in the middle of the row is not intuitive, and the "Dis" label isn't easily understandable either. I wouldn't know how to do it better though.

> Thanks in advance... ;)

Thank YOU; great stuff!! :-)

My +1, once we get those usability issues sorted out.

--
Octality
http://www.octality.com/

_______________________________________________
Cherokee-dev mailing list
Cherokee-dev [at] lists
http://lists.octality.com/listinfo/cherokee-dev

stefan at konink

Nov 23, 2009, 2:09 PM

Post #4 of 18 (775 views)
Permalink

Re: PATCH: Disabled Rules [In reply to]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Alvaro Lopez Ortega schreef:
> I like it, although I'm a bit concern about the potential usability penalty it may have.
>
> I'd try to find a way to make clear how it works. Placing the checkbox in the middle of the row is not intuitive, and the "Dis" label isn't easily understandable either. I wouldn't know how to do it better though.

What about something like a 'horinzontal line' through the item?

Stefan
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.13 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEAREKAAYFAksLCDMACgkQYH1+F2Rqwn02kACeNfwM7uDhJWyptSt520LkbO09
Iq4AmgPkUpCGwD9znPz/ZmfmwNBvyZZ6
=KdBF
-----END PGP SIGNATURE-----
_______________________________________________
Cherokee-dev mailing list
Cherokee-dev [at] lists
http://lists.octality.com/listinfo/cherokee-dev

alvaro at octality

Nov 23, 2009, 2:15 PM

Post #5 of 18 (774 views)
Permalink

Re: PATCH: Disabled Rules [In reply to]

On 23/11/2009, at 23:09, Stefan de Konink wrote:
Alvaro Lopez Ortega schreef:
>> I like it, although I'm a bit concern about the potential usability penalty it may have.
>>
>> I'd try to find a way to make clear how it works. Placing the checkbox in the middle of the row is not intuitive, and the "Dis" label isn't easily understandable either. I wouldn't know how to do it better though.
>
> What about something like a 'horinzontal line' through the item?

Haven't seen something like that before.
Do you guys know some other GUI doing something similar? (QT, GTK+, Cocoa, HTML, WinForms.. it does not matter.)

--
Octality
http://www.octality.com/

_______________________________________________
Cherokee-dev mailing list
Cherokee-dev [at] lists
http://lists.octality.com/listinfo/cherokee-dev

stefan at konink

Nov 23, 2009, 2:19 PM

Post #6 of 18 (772 views)
Permalink

Re: PATCH: Disabled Rules [In reply to]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Alvaro Lopez Ortega schreef:
> On 23/11/2009, at 23:09, Stefan de Konink wrote:
> Alvaro Lopez Ortega schreef:
>>> I like it, although I'm a bit concern about the potential usability penalty it may have.
>>>
>>> I'd try to find a way to make clear how it works. Placing the checkbox in the middle of the row is not intuitive, and the "Dis" label isn't easily understandable either. I wouldn't know how to do it better though.
>> What about something like a 'horinzontal line' through the item?
>
> Haven't seen something like that before.
> Do you guys know some other GUI doing something similar? (QT, GTK+, Cocoa, HTML, WinForms.. it does not matter.)

I think the common 'disabled' is 'greyed out'.

stefan
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.13 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEAREKAAYFAksLCmMACgkQYH1+F2Rqwn3TdQCeImixj7Xv+a7xJA/cUiXkyyUA
xZIAniVBV5G7blOMbSLGXxV4gaodXMjn
=NsrK
-----END PGP SIGNATURE-----
_______________________________________________
Cherokee-dev mailing list
Cherokee-dev [at] lists
http://lists.octality.com/listinfo/cherokee-dev

aperez at skarcha

Nov 23, 2009, 3:17 PM

Post #7 of 18 (775 views)
Permalink

Re: PATCH: Disabled Rules [In reply to]

Hello,

2009/11/23 Alvaro Lopez Ortega <alvaro [at] octality>:

>> I've just finished what I think is an interesting patch... Sometimes I
>> need to remove some rules on cherokee-admin to test things, but the
>> right way, IMHO, is to disable them, make tests and enable them again.
>>
>> Here is a patch that implements this feature... Could you please give
>> it a try and/or give your opinion?.
>
> I like it, although I'm a bit concern about the potential usability penalty it may have.
>
> I'd try to find a way to make clear how it works. Placing the checkbox in the middle of the row is not intuitive, and the "Dis" label isn't easily understandable either. I wouldn't know how to do it better though.

I agree... My first idea was what Stefan says: "text-decoration:
line-through", but I didn't like the result.

The checkbox could be placed between "Final" checkbox and "Delete"
icon ("disable" before "delete", it's the idea)

"Dis" label is "ugly", but we don't have too much space...

>> Thanks in advance... ;)
>
> Thank YOU; great stuff!! :-)
>
> My +1, once we get those usability issues sorted out.

Thanks guys... ;) And thanks to my friend Enric Agut; he inspired me
with his comments... ;)

--
Saludos:
Antonio Pérez
_______________________________________________
Cherokee-dev mailing list
Cherokee-dev [at] lists
http://lists.octality.com/listinfo/cherokee-dev

aperez at skarcha

Nov 23, 2009, 4:13 PM

Post #8 of 18 (774 views)
Permalink

Re: PATCH: Disabled Rules [In reply to]

Hello again,

2009/11/24 Antonio Pérez <aperez [at] skarcha>:

> The checkbox could be placed between "Final" checkbox and "Delete"
> icon ("disable" before "delete", it's the idea)

New idea.

--
Saludos:
Antonio Pérez

Attachments:

disabled_rules.png (37.5 KB)

disabled_rules2.diff (4.71 KB)

alvaro at octality

Nov 23, 2009, 10:19 PM

Post #9 of 18 (766 views)
Permalink

Re: PATCH: Disabled Rules [In reply to]

On 24/11/2009, at 01:13, Antonio Pérez wrote:
2009/11/24 Antonio Pérez <aperez [at] skarcha>:
>
>> The checkbox could be placed between "Final" checkbox and "Delete"
>> icon ("disable" before "delete", it's the idea)
>
> New idea.

Looks better to me!

What about doing s/Dis/Off? Would that be a good idea?

--
Octality
http://www.octality.com/

_______________________________________________
Cherokee-dev mailing list
Cherokee-dev [at] lists
http://lists.octality.com/listinfo/cherokee-dev

aperez at skarcha

Nov 23, 2009, 11:55 PM

Post #10 of 18 (768 views)
Permalink

Re: PATCH: Disabled Rules [In reply to]

2009/11/24 Alvaro Lopez Ortega <alvaro [at] octality>:
> On 24/11/2009, at 01:13, Antonio Pérez wrote:
> 2009/11/24 Antonio Pérez <aperez [at] skarcha>:
>>
>>> The checkbox could be placed between "Final" checkbox and "Delete"
>>> icon ("disable" before "delete", it's the idea)
>>
>> New idea.
>
> Looks better to me!
>
> What about doing s/Dis/Off? Would that be a good idea?

Yes, I think that "Off" is better... :-)

--
Saludos:
Antonio Pérez
_______________________________________________
Cherokee-dev mailing list
Cherokee-dev [at] lists
http://lists.octality.com/listinfo/cherokee-dev

stefan at konink

Nov 25, 2009, 2:18 AM

Post #11 of 18 (760 views)
Permalink

Re: PATCH: Disabled Rules [In reply to]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Antonio Pérez schreef:
> 2009/11/24 Alvaro Lopez Ortega <alvaro [at] octality>:
>> On 24/11/2009, at 01:13, Antonio Pérez wrote:
>> 2009/11/24 Antonio Pérez <aperez [at] skarcha>:
>>>> The checkbox could be placed between "Final" checkbox and "Delete"
>>>> icon ("disable" before "delete", it's the idea)
>>> New idea.
>> Looks better to me!
>>
>> What about doing s/Dis/Off? Would that be a good idea?
>
> Yes, I think that "Off" is better... :-)

Can you pretty please at this to virtual servers *itself* as well?

Stefan

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.13 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEAREKAAYFAksNBIAACgkQYH1+F2Rqwn0uZACdE+HNgBSbNDzVlMIhY7Z1UYkL
724AmQGCZ+0gSX9F4vWfkw+S4VFQtsqY
=dIu6
-----END PGP SIGNATURE-----
_______________________________________________
Cherokee-dev mailing list
Cherokee-dev [at] lists
http://lists.octality.com/listinfo/cherokee-dev

alvaro at octality

Nov 25, 2009, 2:29 AM

Post #12 of 18 (761 views)
Permalink

Re: PATCH: Disabled Rules [In reply to]

On 25/11/2009, at 11:18, Stefan de Konink wrote:
Antonio Pérez schreef:
>> 2009/11/24 Alvaro Lopez Ortega <alvaro [at] octality>:
>>> On 24/11/2009, at 01:13, Antonio Pérez wrote:
>>> 2009/11/24 Antonio Pérez <aperez [at] skarcha>:
>>>>> The checkbox could be placed between "Final" checkbox and "Delete"
>>>>> icon ("disable" before "delete", it's the idea)
>>>> New idea.
>>> Looks better to me!
>>>
>>> What about doing s/Dis/Off? Would that be a good idea?
>>
>> Yes, I think that "Off" is better... :-)
>
> Can you pretty please at this to virtual servers *itself* as well?

Good point! It'd certainly be interesting to implement the same functionality in both lists.

--
Octality
http://www.octality.com/

_______________________________________________
Cherokee-dev mailing list
Cherokee-dev [at] lists
http://lists.octality.com/listinfo/cherokee-dev

aperez at skarcha

Nov 25, 2009, 2:36 AM

Post #13 of 18 (761 views)
Permalink

Re: PATCH: Disabled Rules [In reply to]

On Wed, Nov 25, 2009 at 11:29 AM, Alvaro Lopez Ortega
<alvaro [at] octality> wrote:

> On 25/11/2009, at 11:18, Stefan de Konink wrote:
> Antonio Pérez schreef:
>>> 2009/11/24 Alvaro Lopez Ortega <alvaro [at] octality>:
>>>> On 24/11/2009, at 01:13, Antonio Pérez wrote:
>>>> 2009/11/24 Antonio Pérez <aperez [at] skarcha>:
>>>>>> The checkbox could be placed between "Final" checkbox and "Delete"
>>>>>> icon ("disable" before "delete", it's the idea)
>>>>> New idea.
>>>> Looks better to me!
>>>>
>>>> What about doing s/Dis/Off? Would that be a good idea?
>>>
>>> Yes, I think that "Off" is better... :-)
>>
>> Can you pretty please at this to virtual servers *itself* as well?
>
> Good point! It'd certainly be interesting to implement the same functionality in both lists.

Yes!, let me work more on the admin part and we'll release all in one
patch... ;)

Stefan, thanks for the idea! ;)

--
Saludos:
Antonio Pérez
_______________________________________________
Cherokee-dev mailing list
Cherokee-dev [at] lists
http://lists.octality.com/listinfo/cherokee-dev

stefan at konink

Nov 25, 2009, 3:41 AM

Post #14 of 18 (761 views)
Permalink

Re: PATCH: Disabled Rules [In reply to]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Antonio Pérez schreef:
> Yes!, let me work more on the admin part and we'll release all in one
> patch... ;)
>
> Stefan, thanks for the idea! ;)

Since we are now heading to make Cherokee actually /useful/ admin wise
;) Why not disable a vserver upon a configuration error instead of not
starting the entire server at all ;)

In that perspective I would vote for a disabled (in the admin) and a
configure issue (which may or may not be visible when browsing for the
hostname)

Stefan
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.13 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEAREKAAYFAksNF80ACgkQYH1+F2Rqwn3HJgCgkiBSM6csbH1Uo6QwGKpZdEmc
kZQAnAzBs3DR5g/ZD4tTn9DdjxIvmDfR
=IWyz
-----END PGP SIGNATURE-----
_______________________________________________
Cherokee-dev mailing list
Cherokee-dev [at] lists
http://lists.octality.com/listinfo/cherokee-dev

alvaro at octality

Nov 25, 2009, 4:08 AM

Post #15 of 18 (763 views)
Permalink

Re: PATCH: Disabled Rules [In reply to]

On 25/11/2009, at 12:41, Stefan de Konink wrote:
Antonio Pérez schreef:
>> Yes!, let me work more on the admin part and we'll release all in one
>> patch... ;)
>>
>> Stefan, thanks for the idea! ;)
>
> Since we are now heading to make Cherokee actually /useful/ admin wise
> ;) Why not disable a vserver upon a configuration error instead of not
> starting the entire server at all ;)

Hold your horses! :-)

Even though it'd certainly be another great enhancement, we should implement one feature at a time, and keep releasing new versions often. So, my +1 for the idea, but at the right time. We have still a bunch of things to do before we could even think of implementing it.

--
Octality
http://www.octality.com/

_______________________________________________
Cherokee-dev mailing list
Cherokee-dev [at] lists
http://lists.octality.com/listinfo/cherokee-dev

stefan at konink

Nov 25, 2009, 5:01 AM

Post #16 of 18 (762 views)
Permalink

Re: PATCH: Disabled Rules [In reply to]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Alvaro Lopez Ortega schreef:
> On 25/11/2009, at 12:41, Stefan de Konink wrote:
> Antonio Pérez schreef:
>>> Yes!, let me work more on the admin part and we'll release all in one
>>> patch... ;)
>>>
>>> Stefan, thanks for the idea! ;)
>> Since we are now heading to make Cherokee actually /useful/ admin wise
>> ;) Why not disable a vserver upon a configuration error instead of not
>> starting the entire server at all ;)
>
> Hold your horses! :-)

I usually put my horses in the bugtracker. I mean horses produce a nasty
smell that attracts bugs, but this feature was never logged in the
bugtracker so my horses could do nothing more than adding extra
horsepower to the brainstorming process ;)

Stefan
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.13 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEAREKAAYFAksNKrIACgkQYH1+F2Rqwn0FsQCcC6g+b1dkDr+QIapVR1XjN3M0
IMkAoI4aBQyO7WiHHIu3pasZd84wasOp
=hp6w
-----END PGP SIGNATURE-----
_______________________________________________
Cherokee-dev mailing list
Cherokee-dev [at] lists
http://lists.octality.com/listinfo/cherokee-dev

alvaro at octality

Nov 25, 2009, 5:04 AM

Post #17 of 18 (761 views)
Permalink

Re: PATCH: Disabled Rules [In reply to]

On 25/11/2009, at 14:01, Stefan de Konink wrote:
Alvaro Lopez Ortega schreef:
>> On 25/11/2009, at 12:41, Stefan de Konink wrote:
>> Antonio Pérez schreef:
>>>> Yes!, let me work more on the admin part and we'll release all in one
>>>> patch... ;)
>>>>
>>>> Stefan, thanks for the idea! ;)
>>> Since we are now heading to make Cherokee actually /useful/ admin wise
>>> ;) Why not disable a vserver upon a configuration error instead of not
>>> starting the entire server at all ;)
>>
>> Hold your horses! :-)
>
> I usually put my horses in the bugtracker. I mean horses produce a nasty
> smell that attracts bugs, but this feature was never logged in the
> bugtracker so my horses could do nothing more than adding extra
> horsepower to the brainstorming process ;)

Sure! And, by the way, thanks for logging all those RFEs :-)

--
Octality
http://www.octality.com/

_______________________________________________
Cherokee-dev mailing list
Cherokee-dev [at] lists
http://lists.octality.com/listinfo/cherokee-dev

stefan at konink

Nov 25, 2009, 5:13 AM

Post #18 of 18 (767 views)
Permalink

Re: PATCH: Disabled Rules [In reply to]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Alvaro Lopez Ortega schreef:
> Sure! And, by the way, thanks for logging all those RFEs :-)

Feeding the horses:
http://code.google.com/p/cherokee/issues/detail?id=642

Stefan
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.13 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEAREKAAYFAksNLZAACgkQYH1+F2Rqwn2pBACgkIAy1DJ6/Rl/5ShpUfEJBo21
01gAn0+P6eEGEI0pdXNLG9p6zw366QWz
=s81j
-----END PGP SIGNATURE-----
_______________________________________________
Cherokee-dev mailing list
Cherokee-dev [at] lists
http://lists.octality.com/listinfo/cherokee-dev

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads