Mailing List Archive: Cherokee: dev

Issue 600 in cherokee: rule - high load

Index | Next | Previous | View Threaded

codesite-noreply at google

Oct 14, 2009, 3:31 PM

Post #1 of 7 (85 views)
Permalink

Issue 600 in cherokee: rule - high load

Status: Accepted
Owner: ste...@konink.de
Labels: Type-Enhancement Priority-Medium OpSys-Linux Component-Logic
Component-Admin Usability

New issue 600 by ste...@konink.de: rule - high load
http://code.google.com/p/cherokee/issues/detail?id=600

rule_highload will implement several scenario's a user can match to in
order to redirect traffic to different servers if the load is just too high.

The basic scenario I want to have implemented:
- load (1m / 5m / 15m); because we REALLY don't want to do a systemcall
per incoming request, we might have to cache the one minute load just
somewhere in the server structure. [Windows equivalent?]

- use of the traffic counter.

If the maximum is exceeded the rule is matched, and and something can
happen in the handler behind it.

Potential problems; if we hit the famous 'cherokee doesn't like negative
rules...' then we call Alvaro...

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
_______________________________________________
Cherokee-dev mailing list
Cherokee-dev[at]lists.octality.com
http://lists.octality.com/listinfo/cherokee-dev

codesite-noreply at google

Nov 5, 2009, 8:47 PM

Post #2 of 7 (51 views)
Permalink

Re: Issue 600 in cherokee: rule - high load [In reply to]

Comment #1 on issue 600 by ste...@konink.de: rule - high load
http://code.google.com/p/cherokee/issues/detail?id=600

This initial patch should give support to Cherokee to store the load
variables up to
one minute. Now I wonder we could integrate this into the nonce timer
(hence also a 60s
delay). I'm totally open for that. I expect that for Windows, we probably
have to
figure out how to emulate this behavior.

Attachments:
cherokee-load-support.patch 2.7 KB

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
_______________________________________________
Cherokee-dev mailing list
Cherokee-dev[at]lists.octality.com
http://lists.octality.com/listinfo/cherokee-dev

codesite-noreply at google

Nov 6, 2009, 10:16 PM

Post #3 of 7 (52 views)
Permalink

Re: Issue 600 in cherokee: rule - high load [In reply to]

Updates:
Status: Started
Owner: tahers

Comment #2 on issue 600 by ste...@konink.de: rule - high load
http://code.google.com/p/cherokee/issues/detail?id=600

Implementation of the server code; we still lack an admin frontend. I hope
a skilled
Python engineer can make something functional. Ignore the above comment
about 'shared'
nonce timer. Although the load is calculated over the past minute, it is
(of course)
a continuous interval. I have reduced the update to 10s now. I think that
is pretty
reasonable.

For the gifted python engineers; this is what the module expects:
vserver!10!rule!700!match = load
vserver!10!rule!700!match!1min = 0.1
vserver!10!rule!700!handler = custom_error
vserver!10!rule!700!handler!error = 503

Where 1min, 5min, 15min are valid parameters. Leaving them out makes them
double max
on the server side. Any exceed in threshold results in a match.

Attachments:
cherokee-rule-load.patch 8.6 KB

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
_______________________________________________
Cherokee-dev mailing list
Cherokee-dev[at]lists.octality.com
http://lists.octality.com/listinfo/cherokee-dev

codesite-noreply at google

Nov 7, 2009, 5:09 AM

Post #4 of 7 (50 views)
Permalink

Re: Issue 600 in cherokee: rule - high load [In reply to]

Comment #3 on issue 600 by tahers: rule - high load
http://code.google.com/p/cherokee/issues/detail?id=600

Does this suit your needs, Stefan?

Attachments:
cherokee-rule-load-admin.patch 5.1 KB

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
_______________________________________________
Cherokee-dev mailing list
Cherokee-dev[at]lists.octality.com
http://lists.octality.com/listinfo/cherokee-dev

codesite-noreply at google

Nov 7, 2009, 7:48 AM

Post #5 of 7 (49 views)
Permalink

Re: Issue 600 in cherokee: rule - high load [In reply to]

Updates:
Status: WaitingQA
Owner: alobbs

Comment #4 on issue 600 by ste...@konink.de: rule - high load
http://code.google.com/p/cherokee/issues/detail?id=600

Seriously super Taher! Especially the nifty rendering in the virtual server
list :)

And because I like everyone here I have added a bonus patch so the load
also becomes
visible on the server info page.

In my opinion mergeable :)

Attachments:
cherokee-serverinfo-bonus.diff 2.6 KB

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
_______________________________________________
Cherokee-dev mailing list
Cherokee-dev[at]lists.octality.com
http://lists.octality.com/listinfo/cherokee-dev

codesite-noreply at google

Nov 7, 2009, 8:11 AM

Post #6 of 7 (49 views)
Permalink

Re: Issue 600 in cherokee: rule - high load [In reply to]

Updates:
Status: Started

Comment #5 on issue 600 by alobbs: rule - high load
http://code.google.com/p/cherokee/issues/detail?id=600

Bear with me here.. I'd like to check it out calmly.

Anyway, it looks pretty interesting, congrats in advance! :-)

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
_______________________________________________
Cherokee-dev mailing list
Cherokee-dev[at]lists.octality.com
http://lists.octality.com/listinfo/cherokee-dev

codesite-noreply at google

Nov 7, 2009, 10:29 AM

Post #7 of 7 (49 views)
Permalink

Re: Issue 600 in cherokee: rule - high load [In reply to]

Comment #6 on issue 600 by ste...@konink.de: rule - high load
http://code.google.com/p/cherokee/issues/detail?id=600

Since I was using a RWLOCK structure I just wondered if I unlocked it
properly. Sadly I
did not use it at all in the rule or in the server info page.

The attached patch combines everything above including my last fix.

Alvaro; in the server info page I put the load values on the stack to avoid
longer
locking then required. If you think this too complex, change it back the
original, and
lock/unlock it after the string functions.

Attachments:
load-final.patch 14.1 KB

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
_______________________________________________
Cherokee-dev mailing list
Cherokee-dev[at]lists.octality.com
http://lists.octality.com/listinfo/cherokee-dev

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact lists@gossamer-threads.com