cherokee at cherokee-project
Nov 20, 2009, 6:34 AM
Post #1 of 1
(89 views)
Permalink
|
|
[3850] cherokee/trunk/cherokee: Fixes a couple of issues: A file descriptor leak in Cherokee tweak,
|
|
Revision: 3850
http://svn.cherokee-project.com/changeset/3850
Author: alo
Date: 2009-11-20 15:34:56 +0100 (Fri, 20 Nov 2009)
Log Message:
-----------
Fixes a couple of issues: A file descriptor leak in Cherokee tweak,
and a wrong error checking in the host name resolution cache. Thanks
to Eric Sesterhenn <eric.sesterhenn [at] lsexperts> for the patch!
Modified Paths:
--------------
cherokee/trunk/cherokee/main_tweak.c
cherokee/trunk/cherokee/resolv_cache.c
Modified: cherokee/trunk/cherokee/main_tweak.c
===================================================================
--- cherokee/trunk/cherokee/main_tweak.c 2009-11-20 12:35:08 UTC (rev 3849)
+++ cherokee/trunk/cherokee/main_tweak.c 2009-11-20 14:34:56 UTC (rev 3850)
@@ -213,6 +213,8 @@
cherokee_buffer_drop_ending (&dirname, d_name_len);
}
+ closedir(dir);
+
/* Build the new filename
*/
cherokee_buffer_add_va (logname, "%s.%d", logfile->buf, max + 1);
Modified: cherokee/trunk/cherokee/resolv_cache.c
===================================================================
--- cherokee/trunk/cherokee/resolv_cache.c 2009-11-20 12:35:08 UTC (rev 3849)
+++ cherokee/trunk/cherokee/resolv_cache.c 2009-11-20 14:34:56 UTC (rev 3850)
@@ -185,8 +185,9 @@
/* Instance the entry
*/
ret = entry_new (&n);
- if (unlikely (ret != ret))
+ if (unlikely (ret != ret_ok)) {
return ret;
+ }
/* Fill it up
*/
|
