Mailing List Archive: Catalyst: Users

Suggested minor fixes for Catalyst error output

1 2

View All

Index | Next | Previous | View Threaded

Nigel.Metheringham at dev

Apr 12, 2006, 7:52 AM

Post #1 of 35 (3666 views)
Permalink

Suggested minor fixes for Catalyst error output

Here's a patch making 2 changes to the HTML output from Catalyst when
there is an error:-
1. Remove the rounded corners on the error page
2. Change the Data::Dumper parameters to be less space intensive

The reasoning behind this is that the -moz-border-radius CSS setting to
give the rounded corners looks great when there is a small amount of
output, however if you have dumped variables in the output it can get
rather large, which then tickles a Mozilla/Gecko rendering bug which
plasters the background on top of the error text output.

This is detailed in
https://bugzilla.mozilla.org/show_bug.cgi?id=252241

The workround is to simply live with square (although less cool)
corners, by removing the property from the style sheets. Other browsers
won't honour this anyhow, so it makes things consistent.

The other fix is to set Indent mode on Data::Dumper to 1, which heads
off to the right hand margin less quickly than the default. Anyone
using a DBIx::Class based model with elements in stash will know that a
dumped object rapidly exhausts the width of the browser window :-(

Cheers
Nigel.

--
[ Nigel Metheringham Nigel.Metheringham [at] InTechnology ]
[. - Comments in this message are my own and not ITO opinion/policy - ]

Attachments:

catalyst-dumping.patch (1.21 KB)

dbix-class at trout

Apr 12, 2006, 8:13 AM

Post #2 of 35 (3585 views)
Permalink

Re: Suggested minor fixes for Catalyst error output [In reply to]

Nigel Metheringham wrote:
> Here's a patch making 2 changes to the HTML output from Catalyst when
> there is an error:-
> 1. Remove the rounded corners on the error page
> 2. Change the Data::Dumper parameters to be less space intensive
>
> The reasoning behind this is that the -moz-border-radius CSS setting to
> give the rounded corners looks great when there is a small amount of
> output, however if you have dumped variables in the output it can get
> rather large, which then tickles a Mozilla/Gecko rendering bug which
> plasters the background on top of the error text output.
>
> This is detailed in
> https://bugzilla.mozilla.org/show_bug.cgi?id=252241
>
> The workround is to simply live with square (although less cool)
> corners, by removing the property from the style sheets. Other browsers
> won't honour this anyhow, so it makes things consistent.

I'm definitely in favour of this.

> The other fix is to set Indent mode on Data::Dumper to 1, which heads
> off to the right hand margin less quickly than the default. Anyone
> using a DBIx::Class based model with elements in stash will know that a
> dumped object rapidly exhausts the width of the browser window :-(

There'll be a solution to that eventually. I'm just not 100% sure what it's
going to be yet :)

--
Matt S Trout Offering custom development, consultancy and support
Technical Director contracts for Catalyst, DBIx::Class and BAST. Contact
Shadowcat Systems Ltd. mst (at) shadowcatsystems.co.uk for more information

+ Help us build a better perl ORM: http://dbix-class.shadowcatsystems.co.uk/ +

_______________________________________________
Catalyst mailing list
Catalyst [at] lists
http://lists.rawmode.org/mailman/listinfo/catalyst

andy at hybridized

Apr 12, 2006, 9:04 AM

Post #3 of 35 (3571 views)
Permalink

Re: Suggested minor fixes for Catalyst error output [In reply to]

On 4/12/06, Matt S Trout <dbix-class [at] trout> wrote:
> Nigel Metheringham wrote:
> > The workround is to simply live with square (although less cool)
> > corners, by removing the property from the style sheets. Other browsers
> > won't honour this anyhow, so it makes things consistent.
>
> I'm definitely in favour of this.

I'm fine with this too, I've been bitten by that annoying Gecko bug
many times myself.

-Andy

_______________________________________________
Catalyst mailing list
Catalyst [at] lists
http://lists.rawmode.org/mailman/listinfo/catalyst

sri at oook

Apr 12, 2006, 9:45 AM

Post #4 of 35 (3572 views)
Permalink

Re: Suggested minor fixes for Catalyst error output [In reply to]

12.04.2006 16:52 Nigel Metheringham:
> The reasoning behind this is that the -moz-border-radius CSS
> setting to
> give the rounded corners looks great when there is a small amount of
> output, however if you have dumped variables in the output it can get
> rather large, which then tickles a Mozilla/Gecko rendering bug which
> plasters the background on top of the error text output.
>
> This is detailed in
> https://bugzilla.mozilla.org/show_bug.cgi?id=252241
>
> The workround is to simply live with square (although less cool)
> corners, by removing the property from the style sheets. Other
> browsers
> won't honour this anyhow, so it makes things consistent.

Please don't just remove the round edges, fix them.
Here is an example how to do it.

http://pro.html.it/esempio/nifty/

--
sebastian

_______________________________________________
Catalyst mailing list
Catalyst [at] lists
http://lists.rawmode.org/mailman/listinfo/catalyst

acid06 at gmail

Apr 12, 2006, 10:20 AM

Post #5 of 35 (3587 views)
Permalink

Re: Suggested minor fixes for Catalyst error output [In reply to]

On 4/12/06, Sebastian Riedel <sri [at] oook> wrote:
> Please don't just remove the round edges, fix them.

I must agree with sri.
There are plenty of pure-html rounded borders alternatives which
actually work cross-browser.

This might be somewhat ridiculous but the first thing I disliked when
I accessed my first Catalyst app under IE was how the error page
looked a lot uglier. After comparing them I noticed that the only
difference really was the rounded corners.

Besides, pretty error pages, with all sorts of information (although
you might never use all of them), always give that "wow" effect when
you're showing something off. ;-)

The second suggestion, however, seems pretty reasonable.

-Nilson Santos F. Jr.

_______________________________________________
Catalyst mailing list
Catalyst [at] lists
http://lists.rawmode.org/mailman/listinfo/catalyst

Wade.Stuart at fallon

Apr 12, 2006, 12:21 PM

Post #6 of 35 (3584 views)
Permalink

Re: Suggested minor fixes for Catalyst error output [In reply to]

catalyst-bounces [at] lists wrote on 04/12/2006 11:45:55 AM:

>
> 12.04.2006 16:52 Nigel Metheringham:
> > The reasoning behind this is that the -moz-border-radius CSS
> > setting to
> > give the rounded corners looks great when there is a small amount of
> > output, however if you have dumped variables in the output it can get
> > rather large, which then tickles a Mozilla/Gecko rendering bug which
> > plasters the background on top of the error text output.
> >
> > This is detailed in
> > https://bugzilla.mozilla.org/show_bug.cgi?id=252241
> >
> > The workround is to simply live with square (although less cool)
> > corners, by removing the property from the style sheets. Other
> > browsers
> > won't honour this anyhow, so it makes things consistent.
>
> Please don't just remove the round edges, fix them.
> Here is an example how to do it.
>
> http://pro.html.it/esempio/nifty/
>
>

This version is better:
http://pro.html.it/niftycube/

> --
> sebastian
>
>
> _______________________________________________
> Catalyst mailing list
> Catalyst [at] lists
> http://lists.rawmode.org/mailman/listinfo/catalyst

_______________________________________________
Catalyst mailing list
Catalyst [at] lists
http://lists.rawmode.org/mailman/listinfo/catalyst

luke.saunders at gmail

Apr 13, 2006, 3:25 AM

Post #7 of 35 (3571 views)
Permalink

Re: Suggested minor fixes for Catalyst error output [In reply to]

I tried knocking up a patch using the NiftyCorners code as suggested (
http://pro.html.it/niftycube/) and though it appears to work it's massive. I
took everything that was needed from the source and put in it Engine.pm and
it's really bloated. See border_js.diff for the nastiness in all its glory.

So given that the suggested JS solution is too big (+300 lines in Engine.pm)
and other JS solutions are also likely to be massive maybe the corners
should just be removed. border_no_corners.diff should take care of this.

On 4/12/06, Wade.Stuart [at] fallon <Wade.Stuart [at] fallon> wrote:
>
>
>
>
>
>
>
> catalyst-bounces [at] lists wrote on 04/12/2006 11:45:55 AM:
>
> >
> > 12.04.2006 16:52 Nigel Metheringham:
> > > The reasoning behind this is that the -moz-border-radius CSS
> > > setting to
> > > give the rounded corners looks great when there is a small amount of
> > > output, however if you have dumped variables in the output it can get
> > > rather large, which then tickles a Mozilla/Gecko rendering bug which
> > > plasters the background on top of the error text output.
> > >
> > > This is detailed in
> > > https://bugzilla.mozilla.org/show_bug.cgi?id=252241
> > >
> > > The workround is to simply live with square (although less cool)
> > > corners, by removing the property from the style sheets. Other
> > > browsers
> > > won't honour this anyhow, so it makes things consistent.
> >
> > Please don't just remove the round edges, fix them.
> > Here is an example how to do it.
> >
> > http://pro.html.it/esempio/nifty/
> >
> >
>
> This version is better:
> http://pro.html.it/niftycube/
>
>
> > --
> > sebastian
> >
> >
> > _______________________________________________
> > Catalyst mailing list
> > Catalyst [at] lists
> > http://lists.rawmode.org/mailman/listinfo/catalyst
>
>
> _______________________________________________
> Catalyst mailing list
> Catalyst [at] lists
> http://lists.rawmode.org/mailman/listinfo/catalyst
>

Attachments:

border_js.diff (12.5 KB)

border_no_corners.diff (0.99 KB)

Nigel.Metheringham at dev

Apr 13, 2006, 3:52 AM

Post #8 of 35 (3588 views)
Permalink

Re: Suggested minor fixes for Catalyst error output [In reply to]

On Thu, 2006-04-13 at 11:25 +0100, luke saunders wrote:
> I tried knocking up a patch using the NiftyCorners code as suggested
> (http://pro.html.it/niftycube/) and though it appears to work it's
> massive. I took everything that was needed from the source and put in
> it Engine.pm and it's really bloated. See border_js.diff for the
> nastiness in all its glory.

Thats what I was thinking, although I had not had time to try coding
anything. Of course you cannot pull them in using a script tag since
you cannot work with all the possible web server variations and you
can't even include them in as you would in a TT page because you can't
count on the user having a TT View installed. (Same for Mason etc).

However TT is required by a cat install (used for the production of the
initial app templates). Maybe we could put the files out separately and
process the error page through TT to pull them in?
[.This could also help in handling the differing licenses between
NiftyCube (GPL) and Catalyst (Artistic & GPL)]

At least separating them out - or maybe encapsulating as in
HTML::Prototype - makes the chunks reusable elsewhere.

Of course, if we are using Nifty for corners, the original welcome page
needs recoding too.

> So given that the suggested JS solution is too big (+300 lines in
> Engine.pm) and other JS solutions are also likely to be massive maybe
> the corners should just be removed. border_no_corners.diff should take
> care of this.

Obviously I can go along with this as its what I initially suggested.

Nigel.

--
[ Nigel Metheringham Nigel.Metheringham [at] InTechnology ]
[. - Comments in this message are my own and not ITO opinion/policy - ]

_______________________________________________
Catalyst mailing list
Catalyst [at] lists
http://lists.rawmode.org/mailman/listinfo/catalyst

danielmcbrearty at gmail

Apr 13, 2006, 4:30 AM

Post #9 of 35 (3576 views)
Permalink

Re: Suggested minor fixes for Catalyst error output [In reply to]

FWIW, I can't see that rounded corners on a debug page is worth any
expenditure of effort whatsoever. But maybe I'm just getting old ...

On 4/13/06, Nigel Metheringham <Nigel.Metheringham [at] dev>
wrote:
>
> On Thu, 2006-04-13 at 11:25 +0100, luke saunders wrote:
> > I tried knocking up a patch using the NiftyCorners code as suggested
> > (http://pro.html.it/niftycube/) and though it appears to work it's
> > massive. I took everything that was needed from the source and put in
> > it Engine.pm and it's really bloated. See border_js.diff for the
> > nastiness in all its glory.
>
> Thats what I was thinking, although I had not had time to try coding
> anything. Of course you cannot pull them in using a script tag since
> you cannot work with all the possible web server variations and you
> can't even include them in as you would in a TT page because you can't
> count on the user having a TT View installed. (Same for Mason etc).
>
> However TT is required by a cat install (used for the production of the
> initial app templates). Maybe we could put the files out separately and
> process the error page through TT to pull them in?
> [.This could also help in handling the differing licenses between
> NiftyCube (GPL) and Catalyst (Artistic & GPL)]
>
> At least separating them out - or maybe encapsulating as in
> HTML::Prototype - makes the chunks reusable elsewhere.
>
> Of course, if we are using Nifty for corners, the original welcome page
> needs recoding too.
>
> > So given that the suggested JS solution is too big (+300 lines in
> > Engine.pm) and other JS solutions are also likely to be massive maybe
> > the corners should just be removed. border_no_corners.diff should take
> > care of this.
>
> Obviously I can go along with this as its what I initially suggested.
>
> Nigel.
>
> --
> [ Nigel Metheringham Nigel.Metheringham [at] InTechnology ]
> [. - Comments in this message are my own and not ITO opinion/policy - ]
>
>
> _______________________________________________
> Catalyst mailing list
> Catalyst [at] lists
> http://lists.rawmode.org/mailman/listinfo/catalyst
>

--
Daniel McBrearty
email : danielmcbrearty at gmail.com
www.engoi.com : the multi - language vocab trainer
BTW : 0873928131

luke.saunders at gmail

Apr 13, 2006, 4:37 AM

Post #10 of 35 (3587 views)
Permalink

Re: Suggested minor fixes for Catalyst error output [In reply to]

Sorry Nigel, I'd forgotten about your original patch.

> However TT is required by a cat install (used for the production of the
> initial app templates). Maybe we could put the files out separately and
> process the error page through TT to pull them in?
> [.This could also help in handling the differing licenses between
> NiftyCube (GPL) and Catalyst (Artistic & GPL)]

This probably is nicer than just lumping it all in Engine.pm. But then i
supposed Catalyst would REALLY rely on the skeleton of the App being created
with the helper script (so the error/welcome/javascript templates can be
deployed in root/templates/ or whatever, without which they'd get no error
at all).

I guess it is possible for just the Nifty JS library to be put in
root/static/js and then included using the same uri_for magic that the
welcome page uses for its images. But the fact remains, it's still yet more
stuff to ship with Cat and yet more stuff to put in the root/static
directories which probably isn't desirable.

So, they're just corners for the error page and they're a bit of a nightmare
so let's just ditch them. They can be left as they are on the welcome page
since that doesn't break.

On 4/13/06, Nigel Metheringham <Nigel.Metheringham [at] dev>
wrote:
>
> On Thu, 2006-04-13 at 11:25 +0100, luke saunders wrote:
> > I tried knocking up a patch using the NiftyCorners code as suggested
> > (http://pro.html.it/niftycube/) and though it appears to work it's
> > massive. I took everything that was needed from the source and put in
> > it Engine.pm and it's really bloated. See border_js.diff for the
> > nastiness in all its glory.
>
> Thats what I was thinking, although I had not had time to try coding
> anything. Of course you cannot pull them in using a script tag since
> you cannot work with all the possible web server variations and you
> can't even include them in as you would in a TT page because you can't
> count on the user having a TT View installed. (Same for Mason etc).
>
> However TT is required by a cat install (used for the production of the
> initial app templates). Maybe we could put the files out separately and
> process the error page through TT to pull them in?
> [.This could also help in handling the differing licenses between
> NiftyCube (GPL) and Catalyst (Artistic & GPL)]
>
> At least separating them out - or maybe encapsulating as in
> HTML::Prototype - makes the chunks reusable elsewhere.
>
> Of course, if we are using Nifty for corners, the original welcome page
> needs recoding too.
>
> > So given that the suggested JS solution is too big (+300 lines in
> > Engine.pm) and other JS solutions are also likely to be massive maybe
> > the corners should just be removed. border_no_corners.diff should take
> > care of this.
>
> Obviously I can go along with this as its what I initially suggested.
>
> Nigel.
>
> --
> [ Nigel Metheringham Nigel.Metheringham [at] InTechnology ]
> [. - Comments in this message are my own and not ITO opinion/policy - ]
>
>
> _______________________________________________
> Catalyst mailing list
> Catalyst [at] lists
> http://lists.rawmode.org/mailman/listinfo/catalyst
>

simon at browsing

Apr 13, 2006, 4:47 AM

Post #11 of 35 (3588 views)
Permalink

Re: Suggested minor fixes for Catalyst error output [In reply to]

On 13 Apr 2006, at 11:25, luke saunders wrote:

> I tried knocking up a patch using the NiftyCorners code as
> suggested (http://pro.html.it/niftycube/) and though it appears to
> work it's massive. I took everything that was needed from the
> source and put in it Engine.pm and it's really bloated. See
> border_js.diff for the nastiness in all its glory.
>
> So given that the suggested JS solution is too big (+300 lines in
> Engine.pm) and other JS solutions are also likely to be massive
> maybe the corners should just be removed. border_no_corners.diff
> should take care of this

If you 'view rendered source' (needs ff plugin) after nifty has done
its work, you actually get the css + divs it generated - if these get
hard-coded instead we don't need the javascript.

Simon.

pagaltzis at gmx

Apr 13, 2006, 5:18 AM

Post #12 of 35 (3573 views)
Permalink

Re: Suggested minor fixes for Catalyst error output [In reply to]

* Sebastian Riedel <sri [at] oook> [2006-04-12 18:50]:
> Please don't just remove the round edges, fix them. Here is an
> example how to do it.
>
> http://pro.html.it/esempio/nifty/

Here’s a better example of how to do it:

http://virtuelvis.com/gallery/css/rounded/

It works in every modern browser and requires a couple of lines
of CSS inlined in the page instead of a whole honking’ JS
library. You could even inline the required images into the CSS
by using `data:` URIs, in which case the stylesheet would be
entirely self-contained.

It won’t work in fossils like IE, but would still work in many
more browsers than the current `-moz-border-radius` bit.

Regards,
--
Aristotle Pagaltzis // <http://plasmasturm.org/>

_______________________________________________
Catalyst mailing list
Catalyst [at] lists
http://lists.rawmode.org/mailman/listinfo/catalyst

sri at oook

Apr 13, 2006, 5:34 AM

Post #13 of 35 (3575 views)
Permalink

Re: Suggested minor fixes for Catalyst error output [In reply to]

13.04.2006 13:37 luke saunders:
>
> This probably is nicer than just lumping it all in Engine.pm. But
> then i supposed Catalyst would REALLY rely on the skeleton of the
> App being created with the helper script (so the error/welcome/
> javascript templates can be deployed in root/templates/ or
> whatever, without which they'd get no error at all).
>
> I guess it is possible for just the Nifty JS library to be put in
> root/static/js and then included using the same uri_for magic that
> the welcome page uses for its images. But the fact remains, it's
> still yet more stuff to ship with Cat and yet more stuff to put in
> the root/static directories which probably isn't desirable.

No we can't do this, it has to be hardcoded in Engine.pm,
Static::Simple is still just a plugin.
We may remove TT at some point from the core prereqs so thats also no
option. (we are discussing a split between core and helper modules atm)

>
> So, they're just corners for the error page and they're a bit of a
> nightmare so let's just ditch them. They can be left as they are on
> the welcome page since that doesn't break.

Those round corners may be not a essential feature, but they are
still very important, Catalyst should be fun to use and it needs
eyecandy for that.
People who switch between browsers while developing their apps
instantly notice "the ugly debug screen" in non-mozilla browsers.
This is all about user-experience, yes we could just remove them and
the debug screen would still be usable, *but* it would be much less fun!

--
sebastian

_______________________________________________
Catalyst mailing list
Catalyst [at] lists
http://lists.rawmode.org/mailman/listinfo/catalyst

sri at oook

Apr 13, 2006, 5:37 AM

Post #14 of 35 (3571 views)
Permalink

Re: Suggested minor fixes for Catalyst error output [In reply to]

13.04.2006 14:18 A. Pagaltzis:
> It works in every modern browser and requires a couple of lines
> of CSS inlined in the page instead of a whole honking� JS
> library. You could even inline the required images into the CSS
> by using `data:` URIs, in which case the stylesheet would be
> entirely self-contained.
>
> It won�t work in fossils like IE, but would still work in many
> more browsers than the current `-moz-border-radius` bit.

This one requires images, thats no option for the debug screen since
Static::Simple is just a plugin.

--
sebastian

_______________________________________________
Catalyst mailing list
Catalyst [at] lists
http://lists.rawmode.org/mailman/listinfo/catalyst

sri at oook

Apr 13, 2006, 5:50 AM

Post #15 of 35 (3566 views)
Permalink

Re: Suggested minor fixes for Catalyst error output [In reply to]

Am 13.04.2006 um 12:25 schrieb luke saunders:
> So given that the suggested JS solution is too big (+300 lines in
> Engine.pm) and other JS solutions are also likely to be massive
> maybe the corners should just be removed. border_no_corners.diff
> should take care of this.

Actually i have no problem adding 300 lines of JS if it makes the
debug screen look beautiful.

--
sebastian

_______________________________________________
Catalyst mailing list
Catalyst [at] lists
http://lists.rawmode.org/mailman/listinfo/catalyst

dbix-class at trout

Apr 13, 2006, 7:34 AM

Post #16 of 35 (3563 views)
Permalink

Re: Suggested minor fixes for Catalyst error output [In reply to]

Sebastian Riedel wrote:
> 13.04.2006 14:18 A. Pagaltzis:
>> It works in every modern browser and requires a couple of lines
>> of CSS inlined in the page instead of a whole honking� JS
>> library. You could even inline the required images into the CSS
>> by using `data:` URIs, in which case the stylesheet would be
>> entirely self-contained.
>>
>> It won�t work in fossils like IE, but would still work in many
>> more browsers than the current `-moz-border-radius` bit.
>
> This one requires images, thats no option for the debug screen since
> Static::Simple is just a plugin.

Wouldn't inlining via data: URIs fix that?

And if it gets too big we can always just stick it in its own .pm file or in
__DATA__ or similar.

--
Matt S Trout Offering custom development, consultancy and support
Technical Director contracts for Catalyst, DBIx::Class and BAST. Contact
Shadowcat Systems Ltd. mst (at) shadowcatsystems.co.uk for more information

+ Help us build a better perl ORM: http://dbix-class.shadowcatsystems.co.uk/ +

_______________________________________________
Catalyst mailing list
Catalyst [at] lists
http://lists.rawmode.org/mailman/listinfo/catalyst

Nigel.Metheringham at dev

Apr 13, 2006, 7:44 AM

Post #17 of 35 (3574 views)
Permalink

Re: Suggested minor fixes for Catalyst error output [In reply to]

On Thu, 2006-04-13 at 12:47 +0100, Simon Elliott wrote:

> If you 'view rendered source' (needs ff plugin) after nifty has done
> its work, you actually get the css + divs it generated - if these get
> hard-coded instead we don't need the javascript.

I guess, bearing in mind the limitations of css for this, that the
rendered source will be browser dependant, so thats not really an
option.

Nigel.
--
[ Nigel Metheringham Nigel.Metheringham [at] InTechnology ]
[. - Comments in this message are my own and not ITO opinion/policy - ]

_______________________________________________
Catalyst mailing list
Catalyst [at] lists
http://lists.rawmode.org/mailman/listinfo/catalyst

Nigel.Metheringham at dev

Apr 13, 2006, 7:45 AM

Post #18 of 35 (3584 views)
Permalink

Re: Suggested minor fixes for Catalyst error output [In reply to]

On Thu, 2006-04-13 at 14:50 +0200, Sebastian Riedel wrote:
> Am 13.04.2006 um 12:25 schrieb luke saunders:
> > So given that the suggested JS solution is too big (+300 lines in
> > Engine.pm) and other JS solutions are also likely to be massive
> > maybe the corners should just be removed. border_no_corners.diff
> > should take care of this.
>
> Actually i have no problem adding 300 lines of JS if it makes the
> debug screen look beautiful.

So does that mean you are taking on Luke's patch to commit?
[and please add a "local $Data::Dumper::Indent = 1" in that file too]

Nigel.
--
[ Nigel Metheringham Nigel.Metheringham [at] InTechnology ]
[. - Comments in this message are my own and not ITO opinion/policy - ]

_______________________________________________
Catalyst mailing list
Catalyst [at] lists
http://lists.rawmode.org/mailman/listinfo/catalyst

luke.saunders at gmail

Apr 13, 2006, 7:51 AM

Post #19 of 35 (3584 views)
Permalink

Re: Suggested minor fixes for Catalyst error output [In reply to]

Doesn't look like it.

When I made the patch I hadn't figured out a way of giving the corners solid
borders, I just assumed it was probably possible. However it turns out that
it's not possible (at least not with Nifty) and so is therefore no longer an
option. Sorry about that.

Back to the drawing board.

On 4/13/06, Nigel Metheringham <Nigel.Metheringham [at] dev>
wrote:
>
> On Thu, 2006-04-13 at 14:50 +0200, Sebastian Riedel wrote:
> > Am 13.04.2006 um 12:25 schrieb luke saunders:
> > > So given that the suggested JS solution is too big (+300 lines in
> > > Engine.pm) and other JS solutions are also likely to be massive
> > > maybe the corners should just be removed. border_no_corners.diff
> > > should take care of this.
> >
> > Actually i have no problem adding 300 lines of JS if it makes the
> > debug screen look beautiful.
>
> So does that mean you are taking on Luke's patch to commit?
> [and please add a "local $Data::Dumper::Indent = 1" in that file too]
>
> Nigel.
> --
> [ Nigel Metheringham Nigel.Metheringham [at] InTechnology ]
> [. - Comments in this message are my own and not ITO opinion/policy - ]
>
>
> _______________________________________________
> Catalyst mailing list
> Catalyst [at] lists
> http://lists.rawmode.org/mailman/listinfo/catalyst
>

sri at oook

Apr 13, 2006, 7:57 AM

Post #20 of 35 (3565 views)
Permalink

Re: Suggested minor fixes for Catalyst error output [In reply to]

13.04.2006 16:45 Nigel Metheringham:
> So does that mean you are taking on Luke's patch to commit?

No, Luke's patch doesn't add the solid borders to rounded corners,
which makes it look bad.
He just told me on irc that he has given up on getting them to work. :(

Hope we don't need to get a whole new debug (and welcome) screen,
because i like the current one.

--
sebastian

_______________________________________________
Catalyst mailing list
Catalyst [at] lists
http://lists.rawmode.org/mailman/listinfo/catalyst

john.lifsey at nrl

Apr 13, 2006, 8:10 AM

Post #21 of 35 (3583 views)
Permalink

Re: Suggested minor fixes for Catalyst error output [In reply to]

luke saunders wrote:
> Doesn't look like it.
>
> When I made the patch I hadn't figured out a way of giving the
>
>
> tp://lists.rawmode.org/mailman/listinfo/catalyst
>
I may be misunderstanding the problem but can't niftycube do solid
borders? For instance in this example..
http://pro.html.it/niftycube/nifty10.html

John

_______________________________________________
Catalyst mailing list
Catalyst [at] lists
http://lists.rawmode.org/mailman/listinfo/catalyst

moltar at spamcop

Apr 13, 2006, 8:22 AM

Post #22 of 35 (3581 views)
Permalink

Re: Suggested minor fixes for Catalyst error output [In reply to]

Pure XHTML (no extra tags) rounded corners technique was covered in
yesterday's issue of SitePoint's Design View #20 mailing list. It's
pretty clever actually.

http://www.sitepoint.com/newsletter/viewissue.php?id=5&issue=20&format=html#6
http://tools.sitepoint.com/spanky/

On the same note. Since you are adding rounded corners, why don't you
add some gradient backgrounds, huge type and some badges. I suggest
placing HTTP error codes inside the badges. Here is a quick tutorial:

http://bartelme.at/journal/266/

Yaya.. just kiddin' ;)

Andy Grundman wrote:
> On 4/12/06, Matt S Trout <dbix-class [at] trout> wrote:
>> Nigel Metheringham wrote:
>>> The workround is to simply live with square (although less cool)
>>> corners, by removing the property from the style sheets. Other browsers
>>> won't honour this anyhow, so it makes things consistent.
>> I'm definitely in favour of this.
>
> I'm fine with this too, I've been bitten by that annoying Gecko bug
> many times myself.
>
> -Andy

_______________________________________________
Catalyst mailing list
Catalyst [at] lists
http://lists.rawmode.org/mailman/listinfo/catalyst

luke.saunders at gmail

Apr 13, 2006, 8:37 AM

Post #23 of 35 (3573 views)
Permalink

Re: Suggested minor fixes for Catalyst error output [In reply to]

> Pure XHTML (no extra tags) rounded corners technique was covered in
> yesterday's issue of SitePoint's Design View #20 mailing list. It's
> pretty clever actually.

It looks like that method works by using background images on various
elements. Sadly, that's no good for reasons outlined earlier in the thread.
Thanks for the suggestion though.

> I may be misunderstanding the problem but can't niftycube do solid
> borders? For instance in this example..

Damn, you got my hopes up. That's not quite it. We want a single outline of
even width that goes all the way around the box. Just make your Cat site
crash and look at the error screen to see what I mean, I can't describe it.

On 4/13/06, moltar <moltar [at] spamcop> wrote:
>
> Pure XHTML (no extra tags) rounded corners technique was covered in
> yesterday's issue of SitePoint's Design View #20 mailing list. It's
> pretty clever actually.
>
>
> http://www.sitepoint.com/newsletter/viewissue.php?id=5&issue=20&format=html#6
> http://tools.sitepoint.com/spanky/
>
> On the same note. Since you are adding rounded corners, why don't you
> add some gradient backgrounds, huge type and some badges. I suggest
> placing HTTP error codes inside the badges. Here is a quick tutorial:
>
> http://bartelme.at/journal/266/
>
> Yaya.. just kiddin' ;)
>
>
> Andy Grundman wrote:
> > On 4/12/06, Matt S Trout <dbix-class [at] trout> wrote:
> >> Nigel Metheringham wrote:
> >>> The workround is to simply live with square (although less cool)
> >>> corners, by removing the property from the style sheets. Other
> browsers
> >>> won't honour this anyhow, so it makes things consistent.
> >> I'm definitely in favour of this.
> >
> > I'm fine with this too, I've been bitten by that annoying Gecko bug
> > many times myself.
> >
> > -Andy
>
> _______________________________________________
> Catalyst mailing list
> Catalyst [at] lists
> http://lists.rawmode.org/mailman/listinfo/catalyst
>

dbix-class at trout

Apr 13, 2006, 8:51 AM

Post #24 of 35 (3569 views)
Permalink

Re: Suggested minor fixes for Catalyst error output [In reply to]

luke saunders wrote:
>
> > Pure XHTML (no extra tags) rounded corners technique was covered in
> > yesterday's issue of SitePoint's Design View #20 mailing list. It's
> > pretty clever actually.
>
> It looks like that method works by using background images on various
> elements. Sadly, that's no good for reasons outlined earlier in the
> thread. Thanks for the suggestion though.

*cough* data: URLs *cough*

--
Matt S Trout Offering custom development, consultancy and support
Technical Director contracts for Catalyst, DBIx::Class and BAST. Contact
Shadowcat Systems Ltd. mst (at) shadowcatsystems.co.uk for more information

+ Help us build a better perl ORM: http://dbix-class.shadowcatsystems.co.uk/ +

_______________________________________________
Catalyst mailing list
Catalyst [at] lists
http://lists.rawmode.org/mailman/listinfo/catalyst

sri at oook

Apr 13, 2006, 8:56 AM

Post #25 of 35 (3591 views)
Permalink

Re: Suggested minor fixes for Catalyst error output [In reply to]

13.04.2006 luke saunders:
> Damn, you got my hopes up. That's not quite it. We want a single
> outline of even width that goes all the way around the box. Just
> make your Cat site crash and look at the error screen to see what I
> mean, I can't describe it.

http://files.oook.de/debug_screen_ff.png

Thats the current look of the debug screen in Firefox.

--
sebastian

_______________________________________________
Catalyst mailing list
Catalyst [at] lists
http://lists.rawmode.org/mailman/listinfo/catalyst

1 2

View All

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads