Mailing List Archive: Catalyst: Users

Unicode in request captures

Index | Next | Previous | View Threaded

catalyst4 at augensalat

Oct 24, 2009, 3:13 PM

Post #1 of 4 (337 views)
Permalink

Unicode in request captures

While I am at encoding issues in Cat ...

I filed a bug report together with patch and test about Unicode
characters in request captures more than two weeks ago:

https://rt.cpan.org/Public/Bug/Display.html?id=50339

It would be great if someone could care about it.

_______________________________________________
List: Catalyst[at]lists.scsys.co.uk
Listinfo: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst
Searchable archive: http://www.mail-archive.com/catalyst[at]lists.scsys.co.uk/
Dev site: http://dev.catalyst.perl.org/

bobtfish at bobtfish

Oct 27, 2009, 3:08 AM

Post #2 of 4 (280 views)
Permalink

Re: Unicode in request captures [In reply to]

On 24 Oct 2009, at 23:13, Bernhard Graf wrote:

> While I am at encoding issues in Cat ...
>
> I filed a bug report together with patch and test about Unicode
> characters in request captures more than two weeks ago:
>
> https://rt.cpan.org/Public/Bug/Display.html?id=50339
>
> It would be great if someone could care about it.
>

*Taken*

I've got a branch on Catalyst currently to deal with some other
encoding Captures / CaptureArgs issues.

I think that your patch may be a little too enthusiastic about
encoding as it is currently, but also looks like a reasonable first
attempt.

I'll incorporate this into my branch http://dev.catalyst.perl.org/repos/Catalyst/Catalyst-Runtime/5.80/branches/uri_encode_captures_andor_args_take2/

Many thanks for the patch, I'll update you further on the status of
the branch in RT.

Cheers
t0m

_______________________________________________
List: Catalyst[at]lists.scsys.co.uk
Listinfo: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst
Searchable archive: http://www.mail-archive.com/catalyst[at]lists.scsys.co.uk/
Dev site: http://dev.catalyst.perl.org/

catalyst4 at augensalat

Oct 27, 2009, 3:29 AM

Post #3 of 4 (280 views)
Permalink

Re: Unicode in request captures [In reply to]

Hi t0m,

>> I filed a bug report together with patch and test about Unicode
>> characters in request captures more than two weeks ago:
>>
>> https://rt.cpan.org/Public/Bug/Display.html?id=50339
>
> *Taken*

fine.

> I've got a branch on Catalyst currently to deal with some other encoding
> Captures / CaptureArgs issues.

good to hear.

> I think that your patch may be a little too enthusiastic about encoding
> as it is currently, but also looks like a reasonable first attempt.

hmm, what do you mean with too enthusiastic?

> I'll incorporate this into my branch
> http://dev.catalyst.perl.org/repos/Catalyst/Catalyst-Runtime/5.80/branches/uri_encode_captures_andor_args_take2/
>
>
> Many thanks for the patch, I'll update you further on the status of the
> branch in RT.

Thx

Bernhard

_______________________________________________
List: Catalyst[at]lists.scsys.co.uk
Listinfo: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst
Searchable archive: http://www.mail-archive.com/catalyst[at]lists.scsys.co.uk/
Dev site: http://dev.catalyst.perl.org/

bobtfish at bobtfish

Oct 28, 2009, 5:11 PM

Post #4 of 4 (258 views)
Permalink

Re: Unicode in request captures [In reply to]

On 27 Oct 2009, at 10:29, Bernhard Graf wrote:
>> I think that your patch may be a little too enthusiastic about
>> encoding
>> as it is currently, but also looks like a reasonable first attempt.
>
> hmm, what do you mean with too enthusiastic?

I mean may encode too much - so, for example, people working around
the fact that it doesn't work right currently may end up with things
double encoded etc.. I may be wrong - I just glanced at the patch. I
know for _certain_ that the code in my branch will fail like this
currently.

If you have spare tuits to work on this then please feel free to turn
up on irc for a commit bit - I've written out a list of tests I think
are needed for the second attempt at this (as previously noted, I
tried to do this before, but broke stuff - so many more tests and
much more care is being employed this time round)

Cheers
t0m

_______________________________________________
List: Catalyst[at]lists.scsys.co.uk
Listinfo: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst
Searchable archive: http://www.mail-archive.com/catalyst[at]lists.scsys.co.uk/
Dev site: http://dev.catalyst.perl.org/

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact lists@gossamer-threads.com