Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: Catalyst: Dev

Patch to use catfile rather than catdir where appropriate

 

 

Catalyst dev RSS feed   Index | Next | Previous | View Threaded


nigel at dotdot

Mar 1, 2012, 3:37 AM

Post #1 of 1 (505 views)
Permalink
Patch to use catfile rather than catdir where appropriate

There are a few places in the Catalyst-Runtime source tree where
the result from File::Spec->catdir is used to refer to a file.
This works on most systems but there are some where files and
directories are very different things, and this could cause pain
and confusion to folks on those systems.

This change, against current git HEAD, changes all the catdir uses
I identified as being against files to catfile

[.There is one other place where there is confusion, but it is in
one of the Module Install inc files, so I guess will need to be
fixed there]

Github pull request:-
https://github.com/rafl/catalyst-runtime/pull/4

Github change
https://github.com/nigelm/catalyst-runtime/commit/7815afcacc5aac809129e92af1049659eeea496b

Github branch with that change
https://github.com/nigelm/catalyst-runtime/tree/nigelm/fix-catdir-misuse


Nigel.
--
[ Nigel Metheringham ------------------------------ nigel [at] dotdot ]
[ Ellipsis Intangible Technologies ]



_______________________________________________
Catalyst-dev mailing list
Catalyst-dev [at] lists
http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst-dev

Catalyst dev RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.