Mailing List Archive: Catalyst: Dev

Proposed patch to Catalyst::Plugin::ConfigLoader

Index | Next | Previous | View Threaded

stuart at morungos

Jun 24, 2009, 5:42 PM

Post #1 of 4 (1168 views)
Permalink

Proposed patch to Catalyst::Plugin::ConfigLoader

Hi all,

Here is a proposed patch to Catalyst::Plugin::ConfigLoader that allows
it to use environment variables as a built-in macro for configuration.
I use this technique a lot in managing multiple FastCGI configurations.

This is the first time I've mailed a patch, so any feedback or
comments will be welcome. I did read the guidelines, and I hope the
accompanying tests are appropriate and adequate.

All the best
Stuart
--
Stuart Watt
stuart[at]morungos.com

Attachments:

configloaderpatch.txt (3.07 KB)

bobtfish at bobtfish

Jun 28, 2009, 6:32 AM

Post #2 of 4 (1088 views)
Permalink

Re: Proposed patch to Catalyst::Plugin::ConfigLoader [In reply to]

On 25 Jun 2009, at 01:42, Stuart Watt wrote:
> Here is a proposed patch to Catalyst::Plugin::ConfigLoader that
> allows it to use environment variables as a built-in macro for
> configuration. I use this technique a lot in managing multiple
> FastCGI configurations.
>
> This is the first time I've mailed a patch, so any feedback or
> comments will be welcome. I did read the guidelines, and I hope the
> accompanying tests are appropriate and adequate.

Looks great to me, useful feature - thanks!

Applied with attribution as r10698 (http://dev.catalyst.perl.org/
svnweb/Catalyst/revision/?rev=10698).

Cheers
t0m

_______________________________________________
Catalyst-dev mailing list
Catalyst-dev[at]lists.scsys.co.uk
http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst-dev

cub.uanic at gmail

Aug 18, 2009, 3:56 PM

Post #3 of 4 (835 views)
Permalink

Re: Proposed patch to Catalyst::Plugin::ConfigLoader [In reply to]

Documentation also should be fixed - now we have more than three
default macros ;)

--- /usr/local/share/perl/5.10.0/Catalyst/Plugin/ConfigLoader.pm
2009-08-13 12:46:41.000000000 +0000
+++ /tmp/ConfigLoader.pm 2009-08-18 22:52:54.006574352 +0000
@@ -273,7 +273,7 @@

=head2 config_substitutions( $value )

-This method substitutes macros found with calls to a function. There are three
+This method substitutes macros found with calls to a function. There are some
default macros:

=over 4

--
Sincerely yours,
Oleg Kostyuk (CUB-UANIC)

_______________________________________________
Catalyst-dev mailing list
Catalyst-dev[at]lists.scsys.co.uk
http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst-dev

brian.cassidy at gmail

Aug 19, 2009, 4:54 AM

Post #4 of 4 (821 views)
Permalink

Re: Proposed patch to Catalyst::Plugin::ConfigLoader [In reply to]

On Tue, Aug 18, 2009 at 7:56 PM, Oleg Kostyuk<cub.uanic[at]gmail.com> wrote:
> Documentation also should be fixed - now we have more than three
> default macros ;)

A slightly different wording committed as svn r11163.

Thanks.

--
Brian Cassidy (brian.cassidy[at]gmail.com)

_______________________________________________
Catalyst-dev mailing list
Catalyst-dev[at]lists.scsys.co.uk
http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst-dev

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact lists@gossamer-threads.com