Mailing List Archive: Catalyst: Dev

[Patch] Bug in warning message in Catalyst::Component (5.8001)

Index | Next | Previous | View Threaded

emazep at gmail

Apr 19, 2009, 8:31 PM

Post #1 of 2 (533 views)
Permalink

[Patch] Bug in warning message in Catalyst::Component (5.8001)

Line 82 in Catalyst::Component (5.8001) says:

warn "Your linearised isa hierarchy is: " . join(', ',
mro::get_linear_isa($class)) . "\n";

however mro::get_linear_isa() returns an arrayref, not a list.

Patch attached.

P.S.

The patch applies s/linearised/linearized/ as well, since it sounds more
familiar to my foreign ear: please drop that change (and forgive me) if
I'm wrong.

Thank you for your invaluable work!

-Emanuele Zeppieri

Attachments:

Controller.pm.patch (0.80 KB)

bobtfish at bobtfish

Apr 20, 2009, 1:53 AM

Post #2 of 2 (476 views)
Permalink

Re: [Patch] Bug in warning message in Catalyst::Component (5.8001) [In reply to]

On 20 Apr 2009, at 04:31, Emanuele Zeppieri wrote:

> Line 82 in Catalyst::Component (5.8001) says:
>
> warn "Your linearised isa hierarchy is: " . join(', ',
> mro::get_linear_isa($class)) . "\n";
>
> however mro::get_linear_isa() returns an arrayref, not a list.

Gagh, I always get that wrong. Well spotted.

> Patch attached.
>
> P.S.
>
> The patch applies s/linearised/linearized/ as well, since it sounds
> more familiar to my foreign ear: please drop that change (and
> forgive me) if I'm wrong.
>

No thats fine, all the rest of Catalyst is in en_US, even if en_GB
comes out my fingers naturally ;)

Many thanks for the patch, applied as r9752.

Cheers
t0m

_______________________________________________
Catalyst-dev mailing list
Catalyst-dev[at]lists.scsys.co.uk
http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst-dev

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact lists@gossamer-threads.com