Mailing List Archive: Catalyst: Dev

[Catalyst-Plugin-FillInForm PATCH] documentation fix - short-circuit view rather than fillform

Index | Next | Previous | View Threaded

peter at pcc

Mar 9, 2009, 2:24 PM

Post #1 of 3 (1283 views)
Permalink

[Catalyst-Plugin-FillInForm PATCH] documentation fix - short-circuit view rather than fillform

---
lib/Catalyst/Plugin/FillInForm.pm | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/Catalyst/Plugin/FillInForm.pm b/lib/Catalyst/Plugin/FillInForm.pm
index 21405b3..5f6c96e 100644
--- a/lib/Catalyst/Plugin/FillInForm.pm
+++ b/lib/Catalyst/Plugin/FillInForm.pm
@@ -130,8 +130,8 @@ Then you'll need to change it to something like this:

sub end : Private {
my ($self, $c) = @_;
- $c->forward('render');
- $c->fillform($c->req->params) unless $c->res->output;
+ $c->forward('render') unless $c->res->output;
+ $c->fillform($c->req->params);
}

sub render : ActionClass('RenderView') { }
--
1.5.6.5

--
Peter

Attachments:

signature.asc (0.19 KB)

pagaltzis at gmx

Mar 9, 2009, 2:40 PM

Post #2 of 3 (1201 views)
Permalink

Re: [Catalyst-Plugin-FillInForm PATCH] documentation fix - short-circuit view rather than fillform [In reply to]

* Peter Collingbourne <peter [at] pcc> [2009-03-09 22:25]:
> - $c->forward('render');
> - $c->fillform($c->req->params) unless $c->res->output;
> + $c->forward('render') unless $c->res->output;
> + $c->fillform($c->req->params);

Is there a reason you used two separate conditionals?

Regards,
--
Aristotle Pagaltzis // <http://plasmasturm.org/>

_______________________________________________
Catalyst-dev mailing list
Catalyst-dev [at] lists
http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst-dev

peter at pcc

Mar 10, 2009, 7:30 AM

Post #3 of 3 (1189 views)
Permalink

Re: Re: [Catalyst-Plugin-FillInForm PATCH] documentation fix - short-circuit view rather than fillform [In reply to]

On Mon, Mar 09, 2009 at 10:40:45PM +0100, Aristotle Pagaltzis wrote:
> * Peter Collingbourne <peter [at] pcc> [2009-03-09 22:25]:
> > - $c->forward('render');
> > - $c->fillform($c->req->params) unless $c->res->output;
> > + $c->forward('render') unless $c->res->output;
> > + $c->fillform($c->req->params);
>
> Is there a reason you used two separate conditionals?

There is only one conditional -- the patch removes the conditional on
fillform and adds it to forward.

Thanks,
--
Peter

_______________________________________________
Catalyst-dev mailing list
Catalyst-dev [at] lists
http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst-dev

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads