Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: Catalyst: Dev

Suggested patch to Catalyst::Manual::Tutorial::AdvancedCRUD::FormFu

 

 

Catalyst dev RSS feed   Index | Next | Previous | View Threaded


del at alum

Feb 4, 2009, 8:17 AM

Post #1 of 3 (1309 views)
Permalink
Suggested patch to Catalyst::Manual::Tutorial::AdvancedCRUD::FormFu

Dear Catalyst developers -

Attached is a patch that updates Catalyst::Manual::Tutorial::AdvancedCRUD::FormFu. I had noticed that both
$form->save_to_model($book) and
$form->defaults_from_model($book)
generated warnings, and that alternatives should be used. E.g.:
save_to_model() method deprecated and is provided for compatibility only, and will be removed: use $form->model->update() instead
I think the patch to the POD reflects the preferred usage. My local tests suggest that it works, but I am still a Catalyst (and FormFu) newbie.

-Del

p.s. - Apologies in advance for the HTML email; I think that otherwise Thunderbird, my MUA, will inline the patch instead of marking it as an attachment.
Attachments: AdvancedCRUD-FormFu.patch (1.90 KB)


del at alum

Feb 4, 2009, 3:38 PM

Post #2 of 3 (1227 views)
Permalink
Re: Suggested patch to Catalyst::Manual::Tutorial::AdvancedCRUD::FormFu [In reply to]

Del Merritt wrote:
Dear Catalyst developers -

Attached is a patch that updates Catalyst::Manual::Tutorial::AdvancedCRUD::FormFu. I had noticed that both
$form->save_to_model($book) and
$form->defaults_from_model($book)
generated warnings, and that alternatives should be used. E.g.:
save_to_model() method deprecated and is provided for compatibility only, and will be removed: use $form->model->update() instead
I think the patch to the POD reflects the preferred usage. My local tests suggest that it works, but I am still a Catalyst (and FormFu) newbie.

Oops - please disregard that patch, and use this one instead. Sloppy of me; sorry!

-Del
Attachments: AdvancedCRUD-FormFu-corrected.patch (1.90 KB)


bobtfish at bobtfish

Feb 6, 2009, 7:22 AM

Post #3 of 3 (1217 views)
Permalink
Re: Suggested patch to Catalyst::Manual::Tutorial::AdvancedCRUD::FormFu [In reply to]

>
> Oops - please disregard that patch, and use this one instead.
> Sloppy of me; sorry!
>

Happens to the best of us.

Thanks for the patch, applied as:

http://dev.catalystframework.org/svnweb/Catalyst/revision?rev=9232

Cheers
t0m


_______________________________________________
Catalyst-dev mailing list
Catalyst-dev [at] lists
http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst-dev

Catalyst dev RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.