Mailing List Archive: Catalyst: Dev

patch for changes to Catalyst-Manual::Tutorial

Index | Next | Previous | View Threaded

del at alum

Jan 29, 2009, 10:11 AM

Post #1 of 2 (563 views)
Permalink

patch for changes to Catalyst-Manual::Tutorial

Dear Catalyst developers -

While I was working through the Tutorial, I found a couple of nits in,
and also thought I'd add my $0.22 to the guide.

The attached patch represents these changes:

* Tutorial::Authorization - corrects the ACL for "/books/delete" so
that it allows either a "user" or an "admin" to delete books; this
is what is suggested in the text, and prior operation did *not*
allow a non-admin to delete a book. Included here also is a small
editorial comment that allowing users to delete but not create
could be considered an odd bit of policy, but it's just an example.
* Tutorial::AdvancedCRUD::FormFu - purely editorial: suggests how
the intrepid user might now proceed, having completed the Tutorial.

The patch was generated with "svn diff" from the Catalyst-Manual
directory; I hope this is not too inconvenient. I was not willing to
wait for svn's diff over the entire repository.

Apologies in advance if:

1. the diff isn't of the proper format; #catalyst suggested it would
be acceptable
2. the form of attachment is annoying; please let me know how better
to send/attach if this is a problem
3. I've missed some other bit of catalyst-specific patch protocol

-Del

Attachments:

TutorialMods.patch (2.58 KB)

bobtfish at bobtfish

Jan 29, 2009, 1:18 PM

Post #2 of 2 (512 views)
Permalink

Re: patch for changes to Catalyst-Manual::Tutorial [In reply to]

On 29 Jan 2009, at 18:11, Del Merritt wrote:
> The patch was generated with "svn diff" from the Catalyst-Manual
> directory; I hope this is not too inconvenient. I was not willing
> to wait for svn's diff over the entire repository.
>

Applied!

http://dev.catalystframework.org/svnweb/Catalyst/revision?rev=9140

> Apologies in advance if:

<pedant mode="on">

> 1. the diff isn't of the proper format; #catalyst suggested it would
> be acceptable

Usually I'd diff from trunk, so you apply with -p0, but -p2 worked
just fine..

> 2. the form of attachment is annoying; please let me know how better
> to send/attach if this is a problem

Not a big issue, but inline means I have to save the mail and crop
the patch out, rather than just saving the patch, so if you can make
it an actual attachment that'd be slightly more convenient.

</pedant>

> 3. I've missed some other bit of catalyst-specific patch protocol

Nope, next step is stop by #catalyst-dev, and someone will give you a
commit bit to the Manual :_)

Good work, many thanks.
t0m

_______________________________________________
Catalyst-dev mailing list
Catalyst-dev[at]lists.scsys.co.uk
http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst-dev

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact lists@gossamer-threads.com