Mailing List Archive: Catalyst: Dev

Possible bug in Catalyst-Devel-1.05 [Patch]

Index | Next | Previous | View Threaded

ema_zep at libero

Apr 8, 2008, 11:08 PM

Post #1 of 4 (399 views)
Permalink

Possible bug in Catalyst-Devel-1.05 [Patch]

Good morning!

Marcus,

is the following (line 622) in Helper.pm correct?

[% name %]->plugins(qw/-Debug ConfigLoader Static::Simple/);

since there is no "plugins" method in Catalyst.pm <= 5.7012 ...

If I understand correctly, according to the /new style/, it should
instead be:

__PACKAGE__->setup(qw/-Debug ConfigLoader Static::Simple/);

In case I'm right, the attached patch does just that.

Cheers,
Emanuele

Attachments:

Helper.pm.patch (0.46 KB)

marcus at nordaaker

Apr 8, 2008, 11:20 PM

Post #2 of 4 (388 views)
Permalink

Re: Possible bug in Catalyst-Devel-1.05 [Patch] [In reply to]

n 9. april. 2008, at 08.08, Emanuele Zeppieri wrote:
> Good morning!
>
> Marcus,
>
> is the following (line 622) in Helper.pm correct?
>
> [% name %]->plugins(qw/-Debug ConfigLoader Static::Simple/);
>
> since there is no "plugins" method in Catalyst.pm <= 5.7012 ...
>
> If I understand correctly, according to the /new style/, it should
> instead be:
>
> __PACKAGE__->setup(qw/-Debug ConfigLoader Static::Simple/);
>
> In case I'm right, the attached patch does just that.
>

Thanks Emanuele.

Not sure how that slipped through :( 1.06 on it's way to CPAN.

Marcus

_______________________________________________
Catalyst-dev mailing list
Catalyst-dev[at]lists.scsys.co.uk
http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst-dev

jon at jrock

Apr 9, 2008, 9:48 AM

Post #3 of 4 (376 views)
Permalink

Re: Possible bug in Catalyst-Devel-1.05 [Patch] [In reply to]

* On Wed, Apr 09 2008, Emanuele Zeppieri wrote:
> Good morning!
>
> Marcus,
>
> is the following (line 622) in Helper.pm correct?
>
> [% name %]->plugins(qw/-Debug ConfigLoader Static::Simple/);
>
> since there is no "plugins" method in Catalyst.pm <= 5.7012 ...
>
> If I understand correctly, according to the /new style/, it should
> instead be:
>
> __PACKAGE__->setup(qw/-Debug ConfigLoader Static::Simple/);
>
> In case I'm right, the attached patch does just that.
>
> Cheers,
> Emanuele
> --- Helper.pm 2008-04-07 11:55:12.000000000 +0200
> +++ Helper.pm.new 2008-04-09 07:17:21.014000000 +0200
> @@ -619,8 +619,6 @@
>
> use parent qw/Catalyst/;
>
> -[% name %]->plugins(qw/-Debug ConfigLoader Static::Simple/);
> -

Where did this come from anyway? "use parent" looks like a change for
the Moose branch, but svn log doesn't reveal anything interesting.

Regards,
Jonathan Rockway

--
print just => another => perl => hacker => if $,=$"

_______________________________________________
Catalyst-dev mailing list
Catalyst-dev[at]lists.scsys.co.uk
http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst-dev

ema_zep at libero

Apr 9, 2008, 11:26 AM

Post #4 of 4 (382 views)
Permalink

Re: Possible bug in Catalyst-Devel-1.05 [Patch] [In reply to]

Jonathan Rockway wrote:

> * On Wed, Apr 09 2008, Emanuele Zeppieri wrote:
>> Good morning!
>>
>> Marcus,
>>
>> is the following (line 622) in Helper.pm correct?
>>
>> [% name %]->plugins(qw/-Debug ConfigLoader Static::Simple/);
>>
>> since there is no "plugins" method in Catalyst.pm <= 5.7012 ...
>>
>> If I understand correctly, according to the /new style/, it should
>> instead be:
>>
>> __PACKAGE__->setup(qw/-Debug ConfigLoader Static::Simple/);
>>
>> In case I'm right, the attached patch does just that.
>>
>> Cheers,
>> Emanuele
>> --- Helper.pm 2008-04-07 11:55:12.000000000 +0200
>> +++ Helper.pm.new 2008-04-09 07:17:21.014000000 +0200
>> @@ -619,8 +619,6 @@
>>
>> use parent qw/Catalyst/;
>>
>> -[% name %]->plugins(qw/-Debug ConfigLoader Static::Simple/);
>> -
>
> Where did this come from anyway? "use parent" looks like a change for
> the Moose branch, but svn log doesn't reveal anything interesting.

I'm afraid you're asking the wrong person, I'm not a committer ;-)
I can just point you to this previous message from Marcus:
http://lists.scsys.co.uk/pipermail/catalyst-dev/2008-April/001104.html

Cheers,
Emanuele.

_______________________________________________
Catalyst-dev mailing list
Catalyst-dev[at]lists.scsys.co.uk
http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst-dev

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact lists@gossamer-threads.com