marcus at nordaaker
Apr 6, 2008, 12:43 PM
Post #2 of 2
(145 views)
Permalink
|
|
Re: PATCH: for Catalyst-Utils home finding bug
[In reply to]
|
|
Looks good
Merge back committed as revision 7576.
On 6. april. 2008, at 19.25, Matt S Trout wrote:
> Did anybody review and apply this?
>
> I can't really do the review since I helped diagnose it.
>
> ----- Forwarded message from John Goulah <jgoulah[at]gmail.com> -----
>
> Return-Path: catalyst-dev-bounces[at]lists.scsys.co.uk
> Delivered-To: matt[at]trout.me.uk
> Received: (qmail 28115 invoked by alias); 20 Feb 2008 16:47:45 -0000
> Delivered-To: dbix-class[at]trout.me.uk
> Received: (qmail 28113 invoked from network); 20 Feb 2008 16:47:45
> -0000
> Received: from unknown (HELO jules.scsys.co.uk) (217.168.146.69)
> by 0 with SMTP; 20 Feb 2008 16:47:45 -0000
> Received: from localhost ([127.0.0.1] helo=jules.scsys.co.uk)
> by jules.scsys.co.uk with esmtp (Exim 4.60)
> (envelope-from <catalyst-dev-bounces[at]lists.scsys.co.uk>)
> id 1JRscr-0000lI-To; Wed, 20 Feb 2008 17:20:57 +0000
> Received: from wr-out-0506.google.com ([64.233.184.236])
> by jules.scsys.co.uk with esmtp (Exim 4.60)
> (envelope-from <jgoulah[at]gmail.com>) id 1JRscp-0000lD-Ek
> for catalyst-dev[at]lists.scsys.co.uk; Wed, 20 Feb 2008 17:20:55 +0000
> Received: by wr-out-0506.google.com with SMTP id c47so2770450wra.20
> for <catalyst-dev[at]lists.scsys.co.uk>;
> Wed, 20 Feb 2008 09:20:53 -0800 (PST)
> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com;
> s=gamma;
> h=domainkey-signature:received:received:message-
> id:date:from:to:subject:mime-version:content-type;
> bh=qLjH37LLy/TZloDbeNvP4FiFnvQ11W6pARgPGF7Oc1s=;
> b=f55XoSofbufq1sEpRprGlFOFv+RcrLNCCdW+LloUhn4LWo2p6qNbH9VTA7Hb/
> edsDQJo6hU/g2v66KVMCK6g0syaIKC3/SMmsgfyPcjLU4vXe2atifB9F/nM
> +tlrNzYJRnMf6XLpTAEXookpwGRo9X7dFMi77ihWgqxLyAzr9mU=
> DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
> h=message-id:date:from:to:subject:mime-version:content-type;
>
> b
> =
> e0JMfgzpXuZFkZTJ0nvSwwvUuLsP0CWQvTpWQLJK9FtnzaiSsOiwkztJTKfCuBHMMihzF93zHr4WTPyf
> /lOt2pueU6ucw/xeGmKgYueKDfSo/y9yMrxCFkrgPto6dwt/
> o1A7cwBNW3EX4m1vgolwsGAVjv/zKJ7FMdNMqYqzHI0=
> Received: by 10.141.171.6 with SMTP id y6mr5905864rvo.
> 84.1203528052402;
> Wed, 20 Feb 2008 09:20:52 -0800 (PST)
> Received: by 10.141.202.19 with HTTP; Wed, 20 Feb 2008 09:20:52
> -0800 (PST)
> Message-ID: <183c1cc10802200920t1febf65dh5d5850ddf57663b1[at]mail.gmail.com
> >
> Date: Wed, 20 Feb 2008 12:20:52 -0500
> From: John Goulah <jgoulah[at]gmail.com>
> To: catalyst-dev[at]lists.scsys.co.uk
> MIME-Version: 1.0
> Content-Type: multipart/mixed;
> boundary="----=_Part_15834_3483285.1203528052408"
> Subject: [Catalyst-dev] PATCH: for Catalyst-Utils home finding bug
> X-BeenThere: catalyst-dev[at]lists.scsys.co.uk
> X-Mailman-Version: 2.1.5
> Precedence: list
> Reply-To: Development of the elegant MVC web framework <catalyst-dev[at]lists.scsys.co.uk
> >
> List-Id: Development of the elegant MVC web framework
> <catalyst-dev.lists.scsys.co.uk>
> List-Unsubscribe: <http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst-dev
> >,
> <mailto:catalyst-dev-request[at]lists.scsys.co.uk?subject=unsubscribe>
> List-Archive: <http://lists.scsys.co.uk/pipermail/catalyst-dev>
> List-Post: <mailto:catalyst-dev[at]lists.scsys.co.uk>
> List-Help: <mailto:catalyst-dev-request[at]lists.scsys.co.uk?
> subject=help>
> List-Subscribe: <http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst-dev
> >,
> <mailto:catalyst-dev-request[at]lists.scsys.co.uk?subject=subscribe>
> Errors-To: catalyst-dev-bounces[at]lists.scsys.co.uk
>
> Here is a patch to fix the Catalyst home finding bug for scripts
> that run in
> directories more than one level deep. Feel free to rename the
> test. If
> there is some better way to test, let me know, but it fails under the
> current code and passes with the attached patch.
>
> Also these dirs must be added, along with the empty Makefile.PL
>
> A Catalyst-Runtime/5.70/trunk/t/something
> A Catalyst-Runtime/5.70/trunk/t/something/script
> A Catalyst-Runtime/5.70/trunk/t/something/script/foo
> A Catalyst-Runtime/5.70/trunk/t/something/script/foo/bar
> A Catalyst-Runtime/5.70/trunk/t/something/Makefile.PL
>
>
> Thanks!
> John
>
>
> _______________________________________________
> Catalyst-dev mailing list
> Catalyst-dev[at]lists.scsys.co.uk
> http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst-dev
>
>
> ----- End forwarded message -----
>
> --
> Matt S Trout Need help with your Catalyst or DBIx::Class
> project?
> Technical Director http://www.shadowcat.co.uk/catalyst/
> Shadowcat Systems Ltd. Want a managed development or deployment
> platform?
> http://chainsawblues.vox.com/ http://www.shadowcat.co.uk/servers/
>
> _______________________________________________
> Catalyst-dev mailing list
> Catalyst-dev[at]lists.scsys.co.uk
> http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst-dev
_______________________________________________
Catalyst-dev mailing list
Catalyst-dev[at]lists.scsys.co.uk
http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst-dev
|
