Mailing List Archive: Bricolage: devel

trunk

Index | Next | Previous | View Threaded

lannings at who

Mar 2, 2009, 6:58 AM

Post #1 of 5 (1185 views)
Permalink

trunk

In trying to test trunk after merging rev_1_10,
I found that HTML::Template::Expr is apparently required
even though in lib/Bric/Admin.pod it says
=item HTML::Template::Expr (optional)

$ make test
PERL_DL_NONLAZY=1 /usr/bin/perl inst/runtests.pl
t/Bric/Test/Runner.pm .. 1/2535
# Failed test 'use Bric::Util::Job::Pub;'
# at t/Bric/Util/Job/Pub/Test.pm line 12.
# (in Bric::Util::Job::Pub::Test->_test_load)
# Tried to use 'Bric::Util::Job::Pub'.
# Error: Can't locate HTML/Template/Expr.pm in @INC (@INC contains: lib t
/usr/local/bricolage/lib /usr/local/bricolage/lib /etc/perl
/usr/local/lib/perl/5.10.0 /usr/local/share/perl/5.10.0 /usr/lib/perl5
/usr/share/perl5 /usr/lib/perl/5.10 /usr/share/perl/5.10
/usr/local/lib/site_perl .) at lib/Bric/Util/Burner/Template.pm line 45, <AH>
line 424.
[........]

Sure enough, we find

use HTML::Template::Expr;

in lib/Bric/Util/Burner/Template.pm .
So... who's lying? I assume the idea
is that not everybody will use HTML::Template.
In lib/Bric/Util/Burner.pm , we have

require Bric::Util::Burner::Template if eval { require HTML::Template };

Should it also require HTML::Template::Expr, or what?

david at kineticode

Mar 2, 2009, 8:40 AM

Post #2 of 5 (1112 views)
Permalink

Re: trunk [In reply to]

On Mar 2, 2009, at 6:58 AM, Scott Lanning wrote:

> So... who's lying? I assume the idea
> is that not everybody will use HTML::Template.
> In lib/Bric/Util/Burner.pm , we have
>
> require Bric::Util::Burner::Template if eval { require
> HTML::Template };
>
> Should it also require HTML::Template::Expr, or what?

It should only load it if HTML::Template loads. IOW, it should be
optional.

Best,

David

paulo at digitalcraftsmen

Mar 2, 2009, 8:54 AM

Post #3 of 5 (1112 views)
Permalink

Re: trunk [In reply to]

David E. Wheeler wrote:
> On Mar 2, 2009, at 6:58 AM, Scott Lanning wrote:
>
>> So... who's lying? I assume the idea
>> is that not everybody will use HTML::Template.
>> In lib/Bric/Util/Burner.pm , we have
>>
>> require Bric::Util::Burner::Template if eval { require HTML::Template };
>>
>> Should it also require HTML::Template::Expr, or what?
>
> It should only load it if HTML::Template loads. IOW, it should be optional.

If you have HTML::Template installed on your bricolage server then you have
to have to have HTML::Template::Expr installed even if you're not using
HTML::Template for bricolage, since the eval will load it if it exists.

So going on the code snippet from the burner, HTML::Template::Expr should
be mandatory if HTML::Template exists.

Separately it would be really nice to tell bricolage - "Please don't load
HTML::Template even though it's installed on the server, you don't need it"
when PREVIEW_MASON is enabled " ... yeah yeah I know patches welcome :-)

regards,

Paul

--
Paul Orrock Digital Craftsmen
Lead SysAdmin www.digitalcraftsmen.net
Exmouth House, 3 Pine Street, London, EC1R 0JH
Tel: 020 7183 1410 Fax: 020 7099 5140

lannings at who

Mar 6, 2009, 3:39 AM

Post #4 of 5 (1091 views)
Permalink

Re: trunk [In reply to]

On Mon, 2 Mar 2009, Paul Orrock wrote:
> David E. Wheeler wrote:
>>> Should it also require HTML::Template::Expr, or what?
>>
>> It should only load it if HTML::Template loads. IOW, it should be optional.
>
> If you have HTML::Template installed on your bricolage server then you have
> to have to have HTML::Template::Expr installed even if you're not using
> HTML::Template for bricolage, since the eval will load it if it exists.
>
> So going on the code snippet from the burner, HTML::Template::Expr should be
> mandatory if HTML::Template exists.

I made it require HTML::Template::Expr
since it seems that Burner::Template uses that in fact.
So, voila.

david at kineticode

Mar 6, 2009, 9:09 AM

Post #5 of 5 (1096 views)
Permalink

Re: trunk [In reply to]

On Mar 6, 2009, at 3:39 AM, Scott Lanning wrote:

> I made it require HTML::Template::Expr
> since it seems that Burner::Template uses that in fact.
> So, voila.

Parfait, merci.

Salut,

David

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads