Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: Bricolage: devel

Patch: Fix keyword save for Categories

 

 

Bricolage devel RSS feed   Index | Next | Previous | View Threaded


adrian at gossamer-threads

Feb 27, 2009, 6:57 PM

Post #1 of 2 (841 views)
Permalink
Patch: Fix keyword save for Categories

Hi,

Got a fatal error:

Can't use string ("1030") as an ARRAY ref while "strict refs" in use at
Bric/App/Callback/Profile/Category.pm line 123, <GEN21> line 87.\n

while trying to save keyword changes on a Category. The following patch
fixes this problem:

Index: lib/Bric/App/Callback/Profile/Category.pm
===================================================================
--- lib/Bric/App/Callback/Profile/Category.pm (revision 8426)
+++ lib/Bric/App/Callback/Profile/Category.pm (working copy)
@@ -118,7 +120,7 @@

# Delete old keywords.
my $old;
- my $keywords = { map { $_ => 1 } @{ $param->{keyword_id} } };
+ my $keywords = { map { $_ => 1 } @{
mk_aref($param->{keyword_id}) } };
foreach ($cat->get_keywords) {
push @$old, $_ unless $keywords->{$_->get_id};
}


Adrian


rolfm at denison

Feb 27, 2009, 7:11 PM

Post #2 of 2 (751 views)
Permalink
Re: Patch: Fix keyword save for Categories [In reply to]

Committed in 8427. Thanks!

-Matt

On Feb 27, 2009, at 9:57 PM, Adrian Yee wrote:

> Hi,
>
> Got a fatal error:
>
> Can't use string ("1030") as an ARRAY ref while "strict refs" in use
> at Bric/App/Callback/Profile/Category.pm line 123, <GEN21> line 87.\n
>
> while trying to save keyword changes on a Category. The following
> patch fixes this problem:
>
> Index: lib/Bric/App/Callback/Profile/Category.pm
> ===================================================================
> --- lib/Bric/App/Callback/Profile/Category.pm (revision 8426)
> +++ lib/Bric/App/Callback/Profile/Category.pm (working copy)
> @@ -118,7 +120,7 @@
>
> # Delete old keywords.
> my $old;
> - my $keywords = { map { $_ => 1 } @{ $param->{keyword_id} } };
> + my $keywords = { map { $_ => 1 } @{ mk_aref($param-
> >{keyword_id}) } };
> foreach ($cat->get_keywords) {
> push @$old, $_ unless $keywords->{$_->get_id};
> }
>
>
> Adrian

Bricolage devel RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.