Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: Bricolage: devel

Checkout Button

 

 

Bricolage devel RSS feed   Index | Next | Previous | View Threaded


rolfm at denison

Nov 20, 2008, 8:53 AM

Post #1 of 7 (1625 views)
Permalink
Checkout Button

We're working on putting labels on the desk/workflow icons in the
devel release, and we are curious how the checkout button works.
There's an input, but no javascript or form submission that we can
see. How does it make its magic happen?

Other than that, we are making good progress.

Thanks,

Matt


david at kineticode

Nov 20, 2008, 10:04 AM

Post #2 of 7 (1500 views)
Permalink
Re: Checkout Button [In reply to]

On Nov 20, 2008, at 8:53 AM, Matt Rolf wrote:

> We're working on putting labels on the desk/workflow icons in the
> devel release, and we are curious how the checkout button works.
> There's an input, but no javascript or form submission that we can
> see. How does it make its magic happen?

Hrm. Good question. This is the HTML for that element:

<input type="image" name="desk_asset|checkout_cb"
id="desk_asset_checkout_cb" src="/media/images/checkout.gif"
title="Check out" value="story_1024" />

Somehow that gets sent to Desk.request(), I think, but I've no idea
how. None of the loading code in lib.js appears to do it…Marshall, do
remember how this works?

> Other than that, we are making good progress.

Excellent, thanks!

David


rolfm at denison

Nov 20, 2008, 10:15 AM

Post #3 of 7 (1513 views)
Permalink
Re: Checkout Button [In reply to]

On Nov 20, 2008, at 1:04 PM, David E. Wheeler wrote:

> On Nov 20, 2008, at 8:53 AM, Matt Rolf wrote:
>
>> We're working on putting labels on the desk/workflow icons in the
>> devel release, and we are curious how the checkout button works.
>> There's an input, but no javascript or form submission that we can
>> see. How does it make its magic happen?
>
> Hrm. Good question. This is the HTML for that element:
>
> <input type="image" name="desk_asset|checkout_cb"
> id="desk_asset_checkout_cb" src="/media/images/checkout.gif"
> title="Check out" value="story_1024" />
>
> Somehow that gets sent to Desk.request(), I think, but I've no idea
> how. None of the loading code in lib.js appears to do it…Marshall,
> do remember how this works?

It looks like it was added in 1.11.x. In the work we've done, we've
found that the inputs aren't needed. We've taken them out in our
current iteration and used anchors. The inputs can be put back in if
need be.

But this button doesn't have any javascript or anything else. When we
make it an anchor we get 2 ids, and no values, and it does nothing.

It's interesting.

-matt


greg at node79

Nov 20, 2008, 2:50 PM

Post #4 of 7 (1505 views)
Permalink
Re: Checkout Button [In reply to]

On 20-Nov-08, at 1:04 PM, David E. Wheeler wrote:

> <input type="image" name="desk_asset|checkout_cb"
> id="desk_asset_checkout_cb" src="/media/images/checkout.gif"
> title="Check out" value="story_1024" />
>
> Somehow that gets sent to Desk.request(), I think, but I've no idea
> how. None of the loading code in lib.js appears to do it…Marshall,
> do remember how this works?

Isn't it just a regular form submit? It doesn't seem to do any AJAX
magic, but checks out the story and opens it up for editing with a
POST. It goes here:

<form name="desk" action="/workflow/profile/desk/101/101/"
method="post">


david at kineticode

Nov 20, 2008, 4:09 PM

Post #5 of 7 (1520 views)
Permalink
Re: Checkout Button [In reply to]

On Nov 20, 2008, at 2:50 PM, Greg Heo wrote:

> Isn't it just a regular form submit? It doesn't seem to do any AJAX
> magic, but checks out the story and opens it up for editing with a
> POST. It goes here:
>
> <form name="desk" action="/workflow/profile/desk/101/101/"
> method="post">

Oh, right. Duh. An image input is a form submit. Sheesh.

Best,

David


rolfm at denison

Nov 20, 2008, 8:10 PM

Post #6 of 7 (1508 views)
Permalink
Re: Checkout Button [In reply to]

On Nov 20, 2008, at 5:50 PM, Greg Heo wrote:

> On 20-Nov-08, at 1:04 PM, David E. Wheeler wrote:
>
>> <input type="image" name="desk_asset|checkout_cb"
>> id="desk_asset_checkout_cb" src="/media/images/checkout.gif"
>> title="Check out" value="story_1024" />
>>
>> Somehow that gets sent to Desk.request(), I think, but I've no idea
>> how. None of the loading code in lib.js appears to do it…Marshall,
>> do remember how this works?
>
> Isn't it just a regular form submit? It doesn't seem to do any AJAX
> magic, but checks out the story and opens it up for editing with a
> POST. It goes here:
>
> <form name="desk" action="/workflow/profile/desk/101/101/"
> method="post">

Ah, thanks. We've succeeded in adding labels below the icons, and it
greatly increases the app's usability. Checkout is the only thing we
haven't gotten working yet. Once we get it, I have some css to clean
up and then we can commit it.

-Matt


david at kineticode

Nov 20, 2008, 8:43 PM

Post #7 of 7 (1501 views)
Permalink
Re: Checkout Button [In reply to]

On Nov 20, 2008, at 8:10 PM, Matt Rolf wrote:

> Ah, thanks. We've succeeded in adding labels below the icons, and
> it greatly increases the app's usability. Checkout is the only
> thing we haven't gotten working yet. Once we get it, I have some
> css to clean up and then we can commit it.

Got a screenshot?

Best,

David

Bricolage devel RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.