Mailing List Archive: Bricolage: devel

Re: [8377] Fixed Bric::Soap:Util so exports start the field/container order

Index | Next | Previous | View Threaded

paulo at digitalcraftsmen

Nov 19, 2008, 6:25 AM

Post #1 of 2 (878 views)
Permalink

Re: [8377] Fixed Bric::Soap:Util so exports start the field/container order

Hi,

> + # Surely this should always start at 0, changing the order you get out
> + # of the database can only be a bad idea.
> + my $diff = 0;

I appreciate I may be missing a point here, but why did it have to be
introspected ?

It makes no difference to the ordering as it goes back into the database so
surely it would be a good idea to match it to the place order as it's
pulled out of the DB ?

regards,

Paul

--
Paul Orrock Digital Craftsmen
Lead SysAdmin www.digitalcraftsmen.net
Exmouth House, 3 Pine Street, London, EC1R 0JH
Tel: 020 7183 1410 Fax: 020 7099 5140

david at kineticode

Nov 19, 2008, 11:31 AM

Post #2 of 2 (797 views)
Permalink

Re: [8377] Fixed Bric::Soap:Util so exports start the field/container order [In reply to]

On Nov 19, 2008, at 6:11 AM, paulo [at] bricolage wrote:

> if (@$elems) {
> - my $diff = $elems->[-1]->get_place - scalar @$elems + 1;
> +
> + # Surely this should always start at 0, changing the order
> you get out
> + # of the database can only be a bad idea.
> + my $diff = 0;

Yeah, I wonder why it was the other way?

Also, your indenting is all wrong. Please uses 4 spaces for indents,
not tabs.

Best,

David

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads