Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: Bricolage: commits

[bricoleurs/bricolage] 0d6c56: Fix Back button when viewing an asset.

 

 

Bricolage commits RSS feed   Index | Next | Previous | View Threaded


noreply at github

Dec 1, 2011, 9:03 PM

Post #1 of 1 (1042 views)
Permalink
[bricoleurs/bricolage] 0d6c56: Fix Back button when viewing an asset.

Branch: refs/heads/master
Home: https://github.com/bricoleurs/bricolage

Commit: 0d6c5651b42d680c64323e0f52686e1f4a74f5e0
https://github.com/bricoleurs/bricolage/commit/0d6c5651b42d680c64323e0f52686e1f4a74f5e0
Author: David E. Wheeler <david [at] justatheory>
Date: 2011-12-01 (Thu, 01 Dec 2011)

Changed paths:
M comp/widgets/media_prof/view_meta.html
M comp/widgets/story_prof/view_meta.html
M comp/widgets/tmpl_prof/view_meta.html
M lib/Bric/App/Callback/Profile/Media.pm
M lib/Bric/App/Callback/Profile/Story.pm
M lib/Bric/App/Callback/Profile/Template.pm

Log Message:
-----------
Fix Back button when viewing an asset.

Has been broken by the HTML 5 standard, which has image inputs no longer submit their values, but their .x and .y positions. This is annoying, and more like how IE has always behaved. In [this commit](https://github.com/bricoleurs/bricolage/commit/534e739a34e6d71835033bcf560cb54745dd9222) (and others like it for media nd templates), Scott fixed a bug related to get the Return button to work on the diff view. Removing that change fixes the view Return button, but breaks the Diff return button. So switch to using a very simple image link for the Diff page return button instead of the image input. That works on any browser, and so now the Return button should work properly both when viewing assets and when viewing diffs.

[#240 state:closed]

Bricolage commits RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.