Mailing List Archive: Bricolage: bugs

[Bricolage #147] Add Contributor window closes when you hit enter

Index | Next | Previous | View Threaded

no-reply at lighthouseapp

Mar 14, 2010, 5:36 PM

Post #1 of 5 (618 views)
Permalink

[Bricolage #147] Add Contributor window closes when you hit enter

// Add your reply above here
==================================================
Matthew Rolf updated this ticket at March 15th, 2010 @ 12:36 AM

To duplicate:

In the story profile go to add a contributor. Either leave the field blank or add some text and hit enter. The window will close.

Notice this behavior is different from the related media and related story pop-up windows. The behavior should be to perform the search while leaving the window open.
--------------------------------------------------------------------------------

Assigned: Bugs (at bricolage)
State: new
Milestone: 2.0.0
View this ticket online: http://bricolage.lighthouseapp.com/projects/29601/tickets/147-add-contributor-window-closes-when-you-hit-enter
Stop being notified of this ticket's changes: http://bricolage.lighthouseapp.com/projects/29601/tickets/147-add-contributor-window-closes-when-you-hit-enter/watch
Update your Profile: http://bricolage.lighthouseapp.com/profile
Support: support [at] lighthouseapp or http://help.lighthouseapp.com

no-reply at lighthouseapp

Mar 22, 2010, 8:41 PM

Post #2 of 5 (584 views)
Permalink

[Bricolage #147] Add Contributor window closes when you hit enter [In reply to]

// Add your reply above here
==================================================
theory updated this ticket at March 23rd, 2010 @ 03:41 AM
* State changed from "new" to "open"
* Tag changed from "" to "contributors "pop-up window""
* Assigned user changed from "Bugs (at bricolage)" to "theory"

--------------------------------------------------------------------------------

Assigned: theory
State: open
Milestone: 2.0.0
View this ticket online: http://bricolage.lighthouseapp.com/projects/29601/tickets/147-add-contributor-window-closes-when-you-hit-enter
Stop being notified of this ticket's changes: http://bricolage.lighthouseapp.com/projects/29601/tickets/147-add-contributor-window-closes-when-you-hit-enter/watch
Update your Profile: http://bricolage.lighthouseapp.com/profile
Support: support [at] lighthouseapp or http://help.lighthouseapp.com

no-reply at lighthouseapp

Mar 22, 2010, 10:58 PM

Post #3 of 5 (583 views)
Permalink

[Bricolage #147] Add Contributor window closes when you hit enter [In reply to]

// Add your reply above here
==================================================
theory updated this ticket at March 23rd, 2010 @ 05:58 AM

Man! Contributors are all fucked up. I might have to rewrite them. In addition to the issue you've raised:

* If I have two contributors listed, and I click "Delete" for one it disappears, and if I click "Delete" for the other, it doesn't disappear and the one I just deleted re-appears!
* Reordering in the popup is ignored, not passed on to the parent window when the popup is closed.
* If I edit contributors in the popup and click the "save" button to return to the parent window, and then click to edit contributors again without saving, the changes do not appear in the popup. This seems to be because the popup populates contributors from the document in the session, but when it closes, it just sends HTML to the parent window without a submit.

So irritating.
--------------------------------------------------------------------------------

Assigned: theory
State: open
Milestone: 2.0.0
View this ticket online: http://bricolage.lighthouseapp.com/projects/29601/tickets/147-add-contributor-window-closes-when-you-hit-enter
Stop being notified of this ticket's changes: http://bricolage.lighthouseapp.com/projects/29601/tickets/147-add-contributor-window-closes-when-you-hit-enter/watch
Update your Profile: http://bricolage.lighthouseapp.com/profile
Support: support [at] lighthouseapp or http://help.lighthouseapp.com

no-reply at lighthouseapp

Mar 22, 2010, 11:16 PM

Post #4 of 5 (583 views)
Permalink

[Bricolage #147] Add Contributor window closes when you hit enter [In reply to]

// Add your reply above here
==================================================
theory updated this ticket at March 23rd, 2010 @ 06:16 AM

Okay, I've [fixed your bug](http://github.com/bricoleurs/bricolage/commit/e883ebbb16c3e32dcf87de95610a5390858bd413) and [the delete issue](http://github.com/bricoleurs/bricolage/commit/96413beb3bc024d3ee30a0c22335c6285724ace5). It's the other two issues that will be tricky and might require more work.

Which will have to happen later, alas.
--------------------------------------------------------------------------------

Assigned: theory
State: open
Milestone: 2.0.0
View this ticket online: http://bricolage.lighthouseapp.com/projects/29601/tickets/147-add-contributor-window-closes-when-you-hit-enter
Stop being notified of this ticket's changes: http://bricolage.lighthouseapp.com/projects/29601/tickets/147-add-contributor-window-closes-when-you-hit-enter/watch
Update your Profile: http://bricolage.lighthouseapp.com/profile
Support: support [at] lighthouseapp or http://help.lighthouseapp.com

no-reply at lighthouseapp

Mar 23, 2010, 10:13 PM

Post #5 of 5 (585 views)
Permalink

[Bricolage #147] Add Contributor window closes when you hit enter [In reply to]

// Add your reply above here
==================================================
theory updated this ticket at March 24th, 2010 @ 05:13 AM
* State changed from "open" to "resolved"
And now I've [addressed](http://github.com/bricoleurs/bricolage/commit/e11eca1687c36a596b7a505aab1830808b734239) the other two issues by changing the "Save" button in the popup to actually submit the contributor changes. Bricolage makes the updates to the document in the session, then returns HTML of the updated list of contributors, which is then shoved into the contributors box in the document profile. As a result, changes to contributor order are reflected, and multiple changes without saves in between work as expected.
--------------------------------------------------------------------------------

Assigned: theory
State: resolved
Milestone: 2.0.0
View this ticket online: http://bricolage.lighthouseapp.com/projects/29601/tickets/147-add-contributor-window-closes-when-you-hit-enter
Stop being notified of this ticket's changes: http://bricolage.lighthouseapp.com/projects/29601/tickets/147-add-contributor-window-closes-when-you-hit-enter/watch
Update your Profile: http://bricolage.lighthouseapp.com/profile
Support: support [at] lighthouseapp or http://help.lighthouseapp.com

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads