Mailing List Archive: Bricolage: bugs

[Bug 1390] story profile category auto complete will systematically delete elements & refuse to add more

Index | Next | Previous | View Threaded

bugs at lists

Feb 24, 2009, 4:26 PM

Post #1 of 12 (2028 views)
Permalink

[Bug 1390] story profile category auto complete will systematically delete elements & refuse to add more

http://bugs.bricolage.cc/show_bug.cgi?id=1390

Matt Rolf <rolfm [at] denison> changed:

What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|bugs [at] lists |rolfm [at] denison

--
Configure bugmail: http://bugs.bricolage.cc/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.

bugs at lists

Mar 3, 2009, 6:38 PM

Post #2 of 12 (1943 views)
Permalink

[Bug 1390] story profile category auto complete will systematically delete elements & refuse to add more [In reply to]

http://bugs.bricolage.cc/show_bug.cgi?id=1390

Matt Rolf <rolfm [at] denison> changed:

What |Removed |Added
----------------------------------------------------------------------------
Priority|P3 |P2

--
Configure bugmail: http://bugs.bricolage.cc/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.

bugs at lists

Mar 6, 2009, 5:00 PM

Post #3 of 12 (1946 views)
Permalink

[Bug 1390] story profile category auto complete will systematically delete elements & refuse to add more [In reply to]

http://bugs.bricolage.cc/show_bug.cgi?id=1390

--- Comment #1 from Matt Rolf <rolfm [at] denison> 2009-03-07 01:00:54 ---
This bug appears to only affect Safari. Sarah and I are sort of in the dark as
to why Safari isn't getting with the program, as the function call is fairly
unambiguous. Interestingly enough, it never gets called by Safari.

--
Configure bugmail: http://bugs.bricolage.cc/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.

bugs at lists

Mar 6, 2009, 5:04 PM

Post #4 of 12 (1949 views)
Permalink

[Bug 1390] story profile category auto complete will systematically delete elements & refuse to add more [In reply to]

bugs at lists

Mar 6, 2009, 5:10 PM

Post #5 of 12 (1944 views)
Permalink

[Bug 1390] story profile category auto complete will systematically delete elements & refuse to add more [In reply to]

http://bugs.bricolage.cc/show_bug.cgi?id=1390

--- Comment #3 from Matt Rolf <rolfm [at] denison> 2009-03-07 01:10:50 ---
Yes.

--
Configure bugmail: http://bugs.bricolage.cc/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.

bugs at lists

Mar 9, 2009, 10:48 PM

Post #6 of 12 (1935 views)
Permalink

[Bug 1390] story profile category auto complete will systematically delete elements & refuse to add more [In reply to]

http://bugs.bricolage.cc/show_bug.cgi?id=1390

--- Comment #4 from David Wheeler <david [at] kineticode> 2009-03-10 05:48:27 ---
I found that when I hit "Enter" when adding a second category to a story, it
opened a related media box. I think we need to make sure that keys are captured
in the category box, because obviously "Enter" is submitting instead of
selecting.

--
Configure bugmail: http://bugs.bricolage.cc/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.

bugs at lists

Mar 11, 2009, 7:09 AM

Post #7 of 12 (1936 views)
Permalink

[Bug 1390] story profile category auto complete will systematically delete elements & refuse to add more [In reply to]

http://bugs.bricolage.cc/show_bug.cgi?id=1390

Sarah Mercier <mercie_s [at] denison> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |mercie_s [at] denison

--- Comment #5 from Sarah Mercier <mercie_s [at] denison> 2009-03-11 14:09:49 ---
So I tried adding an onkeyup to the input, which I then check to see if it is
'13' (aka enter) at which point I do the add category call. This didn't work,
and it still calls the delete button for the elements. So, I tried adding a
kind of "listener" function which is called during the onclick of that input.
Within that function I simply stop the current event, disable all image buttons
(which seem to be what the input is trying to call) and then try to do an
event.observe on the input, looking for a submit. Once the submit is called, I
am trying to tell the observe to alert me with a "Got here".

I know it goes within this function because I get the alert, but even when I
disable all the buttons it is calling, it still tries to submit using those
buttons, so instead of alerting with a "Got here", I get a page refresh.

David, if you don't have related media or stories on a page, it will delete
elements. I have found that if I have related story/media buttons and I do an
Event.stop(event); it will ignore the delete buttons but it still calls the
related story/media buttons starting at the top of the page. Can anyone see
any reason why the input would go to the top of the content part of the page
and systematically go through, trying to submit specific image inputs?

--
Configure bugmail: http://bugs.bricolage.cc/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.

bugs at lists

Mar 11, 2009, 1:35 PM

Post #8 of 12 (1935 views)
Permalink

[Bug 1390] story profile category auto complete will systematically delete elements & refuse to add more [In reply to]

http://bugs.bricolage.cc/show_bug.cgi?id=1390

David Wheeler <david [at] kineticode> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED

--- Comment #6 from David Wheeler <david [at] kineticode> 2009-03-11 20:35:58 ---
(In reply to comment #5)

> David, if you don't have related media or stories on a page, it will delete
> elements. I have found that if I have related story/media buttons and I do an
> Event.stop(event); it will ignore the delete buttons but it still calls the
> related story/media buttons starting at the top of the page. Can anyone see
> any reason why the input would go to the top of the content part of the page
> and systematically go through, trying to submit specific image inputs?

Good to know, thanks.

How do other projects that use autosuggest fields deal with this? Someone must
have dealt with this problem already, no? Maybe there's something useful in the
examples here?

http://woork.blogspot.com/2009/02/useful-ajax-auto-suggest-scripts.html

—Theory

--
Configure bugmail: http://bugs.bricolage.cc/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.

bugs at lists

Mar 12, 2009, 2:20 PM

Post #9 of 12 (1919 views)
Permalink

[Bug 1390] story profile category auto complete will systematically delete elements & refuse to add more [In reply to]

http://bugs.bricolage.cc/show_bug.cgi?id=1390

Matt Rolf <rolfm [at] denison> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED

--- Comment #7 from Matt Rolf <rolfm [at] denison> 2009-03-12 21:20:23 ---
Fixed in Rev. 8502. Newer versions of Safari didn't need Marshall's fix for a
bug in 2.0.3.

--
Configure bugmail: http://bugs.bricolage.cc/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.

bugs at lists

Mar 12, 2009, 4:50 PM

Post #10 of 12 (1907 views)
Permalink

[Bug 1390] story profile category auto complete will systematically delete elements & refuse to add more [In reply to]

http://bugs.bricolage.cc/show_bug.cgi?id=1390

Marshall Roch <marshall [at] mroch> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |marshall [at] mroch
Status|RESOLVED |REOPENED
Resolution|FIXED |

--- Comment #8 from Marshall Roch <marshall [at] mroch> 2009-03-12 23:50:11 ---
(In reply to comment #7)
> Fixed in Rev. 8502. Newer versions of Safari didn't need Marshall's fix for a
> bug in 2.0.3.
>

I don't think the fix in rev 8502 is correct, since the conditional now always
returns false.

I think it's too soon to discontinue support for Safari 2.0. Safari 3.0 only
runs on OS X 10.4.11 or newer (latest version of 10.4) and has only been out
for 18 months.

--
Configure bugmail: http://bugs.bricolage.cc/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.

bugs at lists

Mar 13, 2009, 2:49 PM

Post #11 of 12 (1894 views)
Permalink

[Bug 1390] story profile category auto complete will systematically delete elements & refuse to add more [In reply to]

http://bugs.bricolage.cc/show_bug.cgi?id=1390

--- Comment #9 from Matt Rolf <rolfm [at] denison> 2009-03-13 21:49:51 ---
(In reply to comment #8)
> (In reply to comment #7)
> > Fixed in Rev. 8502. Newer versions of Safari didn't need Marshall's fix for a
> > bug in 2.0.3.
> >
>
> I don't think the fix in rev 8502 is correct, since the conditional now always
> returns false.
>
> I think it's too soon to discontinue support for Safari 2.0. Safari 3.0 only
> runs on OS X 10.4.11 or newer (latest version of 10.4) and has only been out
> for 18 months.
>

So that will always return either true or false - or is it just how I have it
written? I didn't find much when I was googling for that browser test.

Marshall, can you go into more detail about the bug that your code fixes? It
looks like it's supposed to fix something in the list of choices, is that
right? Your comment of

// This makes the selection go to the end.

is sort of vague to me.

--
Configure bugmail: http://bugs.bricolage.cc/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.

bugs at lists

Mar 14, 2009, 9:08 AM

Post #12 of 12 (1891 views)
Permalink

[Bug 1390] story profile category auto complete will systematically delete elements & refuse to add more [In reply to]

http://bugs.bricolage.cc/show_bug.cgi?id=1390

--- Comment #10 from Marshall Roch <marshall [at] mroch> 2009-03-14 16:08:27 ---
(In reply to comment #9)
> So that will always return either true or false - or is it just how I have it
> written? I didn't find much when I was googling for that browser test.

navigator.appVersion is something like:

5.0 (Macintosh; U; Intel Mac OS X 10_5_6; en-us) AppleWebKit/528.16 (KHTML,
like Gecko) Version/4.0 Safari/528.16

In Safari 2, it's like:

0.5 (Macintosh; U; Intel Mac OS X; en) AppleWebKit/419.3(KHTML, like Gecko)
Safari/419.3

So it's not a simple version number. indexOf("AppleWebKit") is either -1 (not
found) or the column where the text "AppleWebKit" starts, which is greater than
3 (49 for Safari 4, 39 for Safari 2 above).

So before, it returned true iff the browser is Safari (indexOf returned
anything other than -1). Now it returns true if the browser is NOT Safari
(indexOf returns -1) and false for ALL versions of Safari (indexOf returns 49).

To detect Safari versions you have to parse out the number after AppleWebKit
(>500 is Safari 3+). See http://trac.webkit.org/wiki/DetectingWebKit. The
overhead of the script they suggest seems pretty big.

Maybe the simplest fix would be this:

if(navigator.appVersion.indexOf('AppleWebKit/4') > -1) {

which would only return true if the browser was between AppleWebKit/400 and
AppleWebKit/499. Safari 2 is in the 400s, Safari 3 and 4 are in the 500s.
Safari 1 ranges from 85 into the 200s, but we don't support Safari 1.

> Marshall, can you go into more detail about the bug that your code fixes? It
> looks like it's supposed to fix something in the list of choices, is that
> right? Your comment of
>
> // This makes the selection go to the end.
>
> is sort of vague to me.

IIRC, the bug was that when you hit enter, it autocompleted, but the cursor
didn't move to the end of the new text. That is, if you typed "bri<enter>" you
ended up with "bri<cursor>colage" instead of "bricolage<cursor>".

--
Configure bugmail: http://bugs.bricolage.cc/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads