Mailing List Archive: Bricolage: bugs

[Bug 1418] Internet Explorer issues in 1.11

Index | Next | Previous | View Threaded

bugs at lists

Feb 24, 2009, 9:55 AM

Post #1 of 19 (2181 views)
Permalink

[Bug 1418] Internet Explorer issues in 1.11

http://bugs.bricolage.cc/show_bug.cgi?id=1418

Matt Rolf <rolfm [at] denison> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |rolfm [at] denison
Status|NEW |ASSIGNED

--
Configure bugmail: http://bugs.bricolage.cc/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.

bugs at lists

Feb 24, 2009, 4:26 PM

Post #2 of 19 (2123 views)
Permalink

[Bug 1418] Internet Explorer issues in 1.11 [In reply to]

http://bugs.bricolage.cc/show_bug.cgi?id=1418

Matt Rolf <rolfm [at] denison> changed:

What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|bugs [at] lists |rolfm [at] denison
Status|ASSIGNED |NEW

--
Configure bugmail: http://bugs.bricolage.cc/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.

bugs at lists

Feb 25, 2009, 9:02 AM

Post #3 of 19 (2126 views)
Permalink

[Bug 1418] Internet Explorer issues in 1.11 [In reply to]

http://bugs.bricolage.cc/show_bug.cgi?id=1418

--- Comment #2 from Matt Rolf <rolfm [at] denison> 2009-02-25 17:02:57 ---
Thanks for the report. I tried your patch but it still doesn't work on IE7.
We'll try and get that fixed in the next couple days.

--
Configure bugmail: http://bugs.bricolage.cc/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.

bugs at lists

Feb 25, 2009, 9:05 AM

Post #4 of 19 (2123 views)
Permalink

[Bug 1418] Internet Explorer issues in 1.11 [In reply to]

http://bugs.bricolage.cc/show_bug.cgi?id=1418

--- Comment #3 from Matt Rolf <rolfm [at] denison> 2009-02-25 17:05:42 ---
Sorry, it does work - stupid caching.

--
Configure bugmail: http://bugs.bricolage.cc/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.

bugs at lists

Feb 25, 2009, 10:28 AM

Post #5 of 19 (2123 views)
Permalink

[Bug 1418] Internet Explorer issues in 1.11 [In reply to]

http://bugs.bricolage.cc/show_bug.cgi?id=1418

--- Comment #4 from Matt Rolf <rolfm [at] denison> 2009-02-25 18:28:39 ---
I committed the first patch. Regarding the second issue (bulk edit) as far as
I could tell, it doesn't happen when an AJAX event happens, just when the
"save" or "save and stay" buttons are clicked. Is that correct?

--
Configure bugmail: http://bugs.bricolage.cc/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.

bugs at lists

Feb 25, 2009, 10:52 AM

Post #6 of 19 (2110 views)
Permalink

[Bug 1418] Internet Explorer issues in 1.11 [In reply to]

http://bugs.bricolage.cc/show_bug.cgi?id=1418

--- Comment #5 from Kahil <kjallad [at] dpsource> 2009-02-25 18:52:42 ---
Yes, I believe that is correct - "Add Element", deleting an element, dragging
an element did not cause the error, but clicking any of the buttons on the
bottom of the "Story Profile" page (Save, Check In, Save and Stay, etc) did
cause the error.

There may be other places where this kind of thing is happening, I remember
finding it very helpful to look at the contents of the HTTP POSTs and seeing
what IE was doing differently with <button> elements...

If the approach I used - turning <button><img src=xyz></button> into <spans>
that call customSubmit() - I can try to go through and see if I can find other
places the same thing comes up...

--
Configure bugmail: http://bugs.bricolage.cc/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.

bugs at lists

Feb 25, 2009, 6:07 PM

Post #7 of 19 (2109 views)
Permalink

[Bug 1418] Internet Explorer issues in 1.11 [In reply to]

http://bugs.bricolage.cc/show_bug.cgi?id=1418

--- Comment #6 from Matt Rolf <rolfm [at] denison> 2009-02-26 02:07:15 ---
(In reply to comment #5)
> If the approach I used - turning <button><img src=xyz></button> into <spans>
> that call customSubmit() - I can try to go through and see if I can find other
> places the same thing comes up...

Well, I know we've got some styles on buttons in the css - it wouldn't surprise
me if there was other stuff in the code dependent on that markup. Maybe it
would make sense to just deactivate the buttons on those submits, much as we
did for the ajax request when we upgraded Prototype.

Also, for the record, issue #3 in this bug is a duplicate of bug 1406, so I'll
close this bug after #2 is resolved.

--
Configure bugmail: http://bugs.bricolage.cc/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.

bugs at lists

Feb 25, 2009, 6:13 PM

Post #8 of 19 (2115 views)
Permalink

[Bug 1418] Internet Explorer issues in 1.11 [In reply to]

http://bugs.bricolage.cc/show_bug.cgi?id=1418

--- Comment #7 from Matt Rolf <rolfm [at] denison> 2009-02-26 02:13:57 ---
It's on more than the buttons - the view old version link causes the error,
too.

--
Configure bugmail: http://bugs.bricolage.cc/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.

bugs at lists

Feb 26, 2009, 8:16 AM

Post #9 of 19 (2108 views)
Permalink

[Bug 1418] Internet Explorer issues in 1.11 [In reply to]

http://bugs.bricolage.cc/show_bug.cgi?id=1418

--- Comment #8 from Kahil <kjallad [at] dpsource> 2009-02-26 16:16:45 ---
Oops, Sorry about duping 1406 . . . Dang, was hoping the prototype and
scriptaculous upgrade would magically fix this stuff but I guess not. I'll get
my devel installation up to trunk and see if I can help.

Re: #2, I guess this will happen on any form submit from IE on a page where
there is a Bulk Edit (or other callback-calling) image button. Disabling them
in javascript when something else is clicked as you suggest looks like it will
work - I just tested that IE does not put disabled buttons in the POSTDATA.

The only potential drawback I see to doing it in script is that a JS error
would then break the submit, but there is so much JS in there that an err would
likely mean nothing works anyway, and it is a nicer fix than going through
changing HTML to make IE happy...

--
Configure bugmail: http://bugs.bricolage.cc/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.

bugs at lists

Feb 26, 2009, 8:57 AM

Post #10 of 19 (2111 views)
Permalink

[Bug 1418] Internet Explorer issues in 1.11 [In reply to]

http://bugs.bricolage.cc/show_bug.cgi?id=1418

David Wheeler <david [at] kineticode> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |david [at] kineticode

--- Comment #9 from David Wheeler <david [at] kineticode> 2009-02-26 16:57:06 ---
So is it only the Bulk Edit button that's the problem?

I'm kind of confused as to why this is an issue, since AFAIK we're not using
the new prototype stuff for the bulk edit feature. Does this work properly in
1.10 on IE 7? If so, what's different?

—Theory

--
Configure bugmail: http://bugs.bricolage.cc/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.

bugs at lists

Feb 26, 2009, 9:16 AM

Post #11 of 19 (2110 views)
Permalink

[Bug 1418] Internet Explorer issues in 1.11 [In reply to]

http://bugs.bricolage.cc/show_bug.cgi?id=1418

--- Comment #10 from Matt Rolf <rolfm [at] denison> 2009-02-26 17:16:43 ---
(In reply to comment #9)
> So is it only the Bulk Edit button that's the problem?
>
> I'm kind of confused as to why this is an issue, since AFAIK we're not using
> the new prototype stuff for the bulk edit feature. Does this work properly in
> 1.10 on IE 7? If so, what's different?
>
> —Theory
>

As far as I can tell, it works fine in 1.0.x - at least it does on our install.
It appears to happen when you click anything that calls customSubmit from
lib.js in 1.11 - but that function hasn't changed in years.

I'm still trying to figure out why the submitted patch worked. Because it's no
longer a button? Or because he added the customSubmit to it? I'm confused.

--
Configure bugmail: http://bugs.bricolage.cc/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.

bugs at lists

Feb 26, 2009, 9:24 AM

Post #12 of 19 (2102 views)
Permalink

[Bug 1418] Internet Explorer issues in 1.11 [In reply to]

http://bugs.bricolage.cc/show_bug.cgi?id=1418

--- Comment #11 from Kahil <kjallad [at] dpsource> 2009-02-26 17:24:16 ---
The "Bulk Edit" function isn't broken, the problem comes from the new <button>
HTML for it. On a form submit, IE sends the button element's name, but with no
value, so "Bulk Edit" tries to run on nothing which causes the error . . . 1.10
doesn't have the <button> so it doesn't happen.

My patch fixes it by removing the <button>, disabling them in script should
have the same effect and if generalized would apply to any other buttons that
are around in the GUI...

--
Configure bugmail: http://bugs.bricolage.cc/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.

bugs at lists

Feb 26, 2009, 9:59 AM

Post #13 of 19 (2107 views)
Permalink

[Bug 1418] Internet Explorer issues in 1.11 [In reply to]

http://bugs.bricolage.cc/show_bug.cgi?id=1418

--- Comment #12 from David Wheeler <david [at] kineticode> 2009-02-26 17:59:03 ---
Which button is it, exactly, that's submitted?

It seems to me that lib.js/prototype/whatever should not submit a button if
it's not clicked, if that's how a normal, non-JS submit works.

Best,

David

--
Configure bugmail: http://bugs.bricolage.cc/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.

bugs at lists

Feb 26, 2009, 10:16 AM

Post #14 of 19 (2109 views)
Permalink

[Bug 1418] Internet Explorer issues in 1.11 [In reply to]

http://bugs.bricolage.cc/show_bug.cgi?id=1418

--- Comment #13 from Kahil <kjallad [at] dpsource> 2009-02-26 18:16:33 ---
All of the

<button><img src="/media/images/bulk-edit.png" alt="Bulk Edit" /></button>'s

get submitted. I'm pretty sure this happens on non-JS submits and JS submits in
IE.

Its not a javascript/prototype problem, its all about IE sucking and throwing
the innerHTML of a button element into form submits, regardless of them being
clicked.

--
Configure bugmail: http://bugs.bricolage.cc/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.

bugs at lists

Feb 26, 2009, 10:20 AM

Post #15 of 19 (2106 views)
Permalink

[Bug 1418] Internet Explorer issues in 1.11 [In reply to]

http://bugs.bricolage.cc/show_bug.cgi?id=1418

--- Comment #14 from David Wheeler <david [at] kineticode> 2009-02-26 18:20:31 ---
Oh, okay. Then I think Matt's right, we should just strip out button elements
on submit if the browser is IE.

David

--
Configure bugmail: http://bugs.bricolage.cc/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.

bugs at lists

Feb 26, 2009, 6:08 PM

Post #16 of 19 (2095 views)
Permalink

[Bug 1418] Internet Explorer issues in 1.11 [In reply to]

http://bugs.bricolage.cc/show_bug.cgi?id=1418

--- Comment #15 from Matt Rolf <rolfm [at] denison> 2009-02-27 02:08:02 ---
(In reply to comment #14)
> Oh, okay. Then I think Matt's right, we should just strip out button elements
> on submit if the browser is IE.
>
> David
>

David, could you take a look at marshall's commit in #7769? It looks like
that's where he made the change:

- <& '/widgets/profile/button.mc',
- id => $top_level ? 'bulk_edit_this_cb' : 'bulk_edit_' . $id,
- widget => 'container_prof',
- cb => $top_level ? 'bulk_edit_this_cb' : 'bulk_edit_cb',
- button => 'bulk_edit_lgreen',
- value => $id,
- useTable => 0
- &>
-
+<button id="<% $top_level ? 'bulk_edit_this_cb' : 'bulk_edit_' . $id %>"
name="container_prof|<% $top_level ? 'bulk_edit_this_cb' : 'bulk_edit_cb' %>"
value="<% $id %>">

Was that proper? Did you guys stop using button.mc?

--
Configure bugmail: http://bugs.bricolage.cc/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.

bugs at lists

Feb 26, 2009, 6:24 PM

Post #17 of 19 (2096 views)
Permalink

[Bug 1418] Internet Explorer issues in 1.11 [In reply to]

http://bugs.bricolage.cc/show_bug.cgi?id=1418

--- Comment #16 from David Wheeler <david [at] kineticode> 2009-02-27 02:24:36 ---
I think that button.mc puts in a big fat image button, no? You'll have to ask
Marshall why he did it this way, though I'm sure there was a reason.

What happens if you revert that change?

--
Configure bugmail: http://bugs.bricolage.cc/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.

bugs at lists

Feb 26, 2009, 6:34 PM

Post #18 of 19 (2094 views)
Permalink

[Bug 1418] Internet Explorer issues in 1.11 [In reply to]

http://bugs.bricolage.cc/show_bug.cgi?id=1418

--- Comment #17 from Matt Rolf <rolfm [at] denison> 2009-02-27 02:34:28 ---
(In reply to comment #16)
> I think that button.mc puts in a big fat image button, no? You'll have to ask
> Marshall why he did it this way, though I'm sure there was a reason.
>
> What happens if you revert that change?
>

Oh, ok, I see. I'll patch it.

--
Configure bugmail: http://bugs.bricolage.cc/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.

bugs at lists

Mar 2, 2009, 7:20 AM

Post #19 of 19 (2070 views)
Permalink

[Bug 1418] Internet Explorer issues in 1.11 [In reply to]

http://bugs.bricolage.cc/show_bug.cgi?id=1418

Matt Rolf <rolfm [at] denison> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED

--- Comment #18 from Matt Rolf <rolfm [at] denison> 2009-03-02 15:20:49 ---
Part two fixed in revision 8430. Just having bulk edit call customSubmit seems
to fix the problem, with no other markup or javascript changes. Closing as
part 3 is a duplicate of bug 1406. Thanks!

--
Configure bugmail: http://bugs.bricolage.cc/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads