Mailing List Archive: Bricolage: bugs

[Bug 1265] Editing notes results in cached object inconsistency and simultaneous checkout of multiple versions of same story

Index | Next | Previous | View Threaded

bugzilla-daemon at bugs

Apr 14, 2008, 1:15 PM

Post #1 of 7 (339 views)
Permalink

[Bug 1265] Editing notes results in cached object inconsistency and simultaneous checkout of multiple versions of same story

http://bugs.bricolage.cc/show_bug.cgi?id=1265

David Wheeler <david[at]kineticode.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |david[at]kineticode.com
AssignedTo|bugs[at]lists.bricolage.cc |david[at]kineticode.com
Status|ASSIGNED |NEW

--
Configure bugmail: http://bugs.bricolage.cc/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.

bugzilla-daemon at bugs

Apr 14, 2008, 1:16 PM

Post #2 of 7 (323 views)
Permalink

[Bug 1265] Editing notes results in cached object inconsistency and simultaneous checkout of multiple versions of same story [In reply to]

http://bugs.bricolage.cc/show_bug.cgi?id=1265

David Wheeler <david[at]kineticode.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED

--
Configure bugmail: http://bugs.bricolage.cc/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.

bugzilla-daemon at bugs

Apr 15, 2008, 1:40 PM

Post #3 of 7 (321 views)
Permalink

[Bug 1265] Editing notes results in cached object inconsistency and simultaneous checkout of multiple versions of same story [In reply to]

http://bugs.bricolage.cc/show_bug.cgi?id=1265

--- Comment #3 from David Wheeler <david[at]kineticode.com> 2008-04-15 16:40:40 ---
Creating notes is working fine for me in rev_1_10.

David, can you recreate your patch with `svn diff -x '-w'`, so that the
whitespace changes are ignored? Otherwise it's too much for me to easily figure
out.

Also, can you provide detailed instructions for how to replicate this bug?

Thanks,

David

--
Configure bugmail: http://bugs.bricolage.cc/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.

bugzilla-daemon at bugs

Apr 17, 2008, 8:58 AM

Post #4 of 7 (319 views)
Permalink

[Bug 1265] Editing notes results in cached object inconsistency and simultaneous checkout of multiple versions of same story [In reply to]

http://bugs.bricolage.cc/show_bug.cgi?id=1265

Dave Beaudet <d-beaudet[at]nga.gov> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #235 is|0 |1
obsolete| |

--- Comment #4 from Dave Beaudet <d-beaudet[at]nga.gov> 2008-04-17 11:58:20 ---
Created an attachment (id=345)
--> (http://bugs.bricolage.cc/attachment.cgi?id=345)
recreated patch with svn diff -x '-w' as per David's request

--
Configure bugmail: http://bugs.bricolage.cc/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.

bugzilla-daemon at bugs

Apr 17, 2008, 9:05 AM

Post #5 of 7 (315 views)
Permalink

[Bug 1265] Editing notes results in cached object inconsistency and simultaneous checkout of multiple versions of same story [In reply to]

http://bugs.bricolage.cc/show_bug.cgi?id=1265

--- Comment #5 from Dave Beaudet <d-beaudet[at]nga.gov> 2008-04-17 12:05:23 ---

>> Also, can you provide detailed instructions for how to replicate this bug?

As far as I recall (it's been a while since I was working on this) and cannot
reproduce it since applying my own patch, I discovered this by checking out a
story, adding a note, checking the story back in, wash, rinse, repeat.

However, I did just discover some more possibly-related weirdness. When I check
out a story, then immediately "cancel checkout", then visit the desk on which
the story exists, and click "notes", I am permitted to enter notes for the
story and save the note -- which should not be allowed for a story that's not
checked out. I am then returned to my workspace page where the story of
course, does not exist since it's not checked out. I then visit the story
again and click notes, but this time, no text entry field appears (as should
have been the case the first time). So, maybe something in cancel checkout is
not releasing the story cache or resetting the fact that I've no longer got the
story checked out?

--
Configure bugmail: http://bugs.bricolage.cc/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.

bugzilla-daemon at bugs

Apr 24, 2008, 4:27 PM

Post #6 of 7 (297 views)
Permalink

[Bug 1265] Editing notes results in cached object inconsistency and simultaneous checkout of multiple versions of same story [In reply to]

http://bugs.bricolage.cc/show_bug.cgi?id=1265

David Wheeler <david[at]kineticode.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #345 is|0 |1
obsolete| |

--- Comment #6 from David Wheeler <david[at]kineticode.com> 2008-04-24 19:27:26 ---
Created an attachment (id=346)
--> (http://bugs.bricolage.cc/attachment.cgi?id=346)
New Note callback Patch

Okay, I did some poking around and realized that the callback was not doing due
diligence on the object the note was applied to to make sure that the user had
it checked out. So it would be *possible* to screw things up like you describe
if a user:

* Cliked "My Workspace" from within the story profile instead of clicking
"Save". This leaves the story in the user's session.
* From the workspace the user checked the story into the desk. The story is
still in the session.
* The user checks out multiple stories at once, returning her to My
Workspace. The old version is still in the session.
* She edits the notes from My Workspace, without going into the story
profile.

At least I *think* that this can happen. I'm not sure. At any rate, I added
code so that the user cannot add a note if a story is not checked out to her,
and I now use UUID to tell if a story is the same as what's in the session,
thus avoiding the whole problem of whether or not a story has an ID.

I'm going to commit this patch, but please do apply it to your code and let me
know if things continue to work as you expect.

Thanks!

--
Configure bugmail: http://bugs.bricolage.cc/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.

bugzilla-daemon at bugs

Apr 24, 2008, 4:32 PM

Post #7 of 7 (303 views)
Permalink

[Bug 1265] Editing notes results in cached object inconsistency and simultaneous checkout of multiple versions of same story [In reply to]

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact lists@gossamer-threads.com