Mailing List Archive: Apache: Dev

Re: svn commit: r1327907 - /httpd/httpd/trunk/server/Makefile.in

Index | Next | Previous | View Threaded

jorton at redhat

Apr 23, 2012, 1:39 AM

Post #1 of 3 (159 views)
Permalink

Re: svn commit: r1327907 - /httpd/httpd/trunk/server/Makefile.in

On Thu, Apr 19, 2012 at 11:54:00AM -0000, fuankg [at] apache wrote:
> Author: fuankg
> Date: Thu Apr 19 11:53:59 2012
> New Revision: 1327907
>
> URL: http://svn.apache.org/viewvc?rev=1327907&view=rev
...
> --- httpd/httpd/trunk/server/Makefile.in (original)
> +++ httpd/httpd/trunk/server/Makefile.in Thu Apr 19 11:53:59 2012
> @@ -27,9 +27,14 @@ TARGETS = delete-exports $(LTLIBRARY_NAM
> include $(top_builddir)/build/rules.mk
> include $(top_srcdir)/build/library.mk
>
> +ifdef CC_FOR_BUILD
> +gen_test_char: gen_test_char.c
> + $(CC_FOR_BUILD) -DCROSS_COMPILE -o $@ $<
> +else

I think this is GNU make specific, isn't it? Our makefiles are (were?)
supposed to work with non-GNU make and I presume people still rely on
that for *BSD (?).

Regards, Joe

mamfelt at gmail

Apr 23, 2012, 2:47 AM

Post #2 of 3 (152 views)
Permalink

Re: svn commit: r1327907 - /httpd/httpd/trunk/server/Makefile.in [In reply to]

AIX make is not gnu make in any case. If I recall, GNU make is not
"UNIX"/POSIX make.

From my perspective, would be better if project was not dependent on GNU
make.

On Mon, Apr 23, 2012 at 10:39 AM, Joe Orton <jorton [at] redhat> wrote:

> On Thu, Apr 19, 2012 at 11:54:00AM -0000, fuankg [at] apache wrote:
> > Author: fuankg
> > Date: Thu Apr 19 11:53:59 2012
> > New Revision: 1327907
> >
> > URL: http://svn.apache.org/viewvc?rev=1327907&view=rev
> ...
> > --- httpd/httpd/trunk/server/Makefile.in (original)
> > +++ httpd/httpd/trunk/server/Makefile.in Thu Apr 19 11:53:59 2012
> > @@ -27,9 +27,14 @@ TARGETS = delete-exports $(LTLIBRARY_NAM
> > include $(top_builddir)/build/rules.mk
> > include $(top_srcdir)/build/library.mk
> >
> > +ifdef CC_FOR_BUILD
> > +gen_test_char: gen_test_char.c
> > + $(CC_FOR_BUILD) -DCROSS_COMPILE -o $@ $<
> > +else
>
> I think this is GNU make specific, isn't it? Our makefiles are (were?)
> supposed to work with non-GNU make and I presume people still rely on
> that for *BSD (?).
>
> Regards, Joe
>

fuankg at apache

Apr 23, 2012, 5:08 AM

Post #3 of 3 (148 views)
Permalink

Re: svn commit: r1327907 - /httpd/httpd/trunk/server/Makefile.in [In reply to]

Am 23.04.2012 10:39, schrieb Joe Orton:
> On Thu, Apr 19, 2012 at 11:54:00AM -0000, fuankg [at] apache wrote:
>> Author: fuankg
>> Date: Thu Apr 19 11:53:59 2012
>> New Revision: 1327907
>>
>> URL: http://svn.apache.org/viewvc?rev=1327907&view=rev
> ...
>> --- httpd/httpd/trunk/server/Makefile.in (original)
>> +++ httpd/httpd/trunk/server/Makefile.in Thu Apr 19 11:53:59 2012
>> @@ -27,9 +27,14 @@ TARGETS = delete-exports $(LTLIBRARY_NAM
>> include $(top_builddir)/build/rules.mk
>> include $(top_srcdir)/build/library.mk
>>
>> +ifdef CC_FOR_BUILD
>> +gen_test_char: gen_test_char.c
>> + $(CC_FOR_BUILD) -DCROSS_COMPILE -o $@ $<
>> +else
>
> I think this is GNU make specific, isn't it? Our makefiles are (were?)
> supposed to work with non-GNU make and I presume people still rely on
> that for *BSD (?).
I thought that I saw somewhere in configure that we check for gnu make,
but I may recall wrong.
Anyway, I think it would be the best way if we would compeltely
eleminate building gen_test_char with apr = always build the same way as
happens if -DCROSS_COMPILE is defined. I we would change this then we
could always build gen_test_char with CC_FOR_BUILD where CC_FOR_BUILD ==
CC if not cross-compiling. This would then remove the hack in
Makefile.in. I dont believe that we would face any different output from
gen_test_char on any of the supported platforms if we would go this way ...

Gün.

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads