Mailing List Archive: Apache: Dev

Trunk MPM API changes and the OS/2 and NetWare MPMs

Index | Next | Previous | View Threaded

trawick at gmail

Oct 18, 2009, 7:32 AM

Post #1 of 6 (224 views)
Permalink

Trunk MPM API changes and the OS/2 and NetWare MPMs

APIs were changed to avoid hard-wiring the MPM into the base server
compilation (replacing stuff like MPM_NAME, MPM_CHILD_PID(), mpm.h,
etc. with callable equivalents).

I didn't make these changes to these two MPMs previously because:
* OS/2 MPM was not in trunk at the time
* the NetWare maintainer was ambivalent about keeping the NetWare MPM
in trunk when I was itching to do this work

I am happy to

* start committing the necessary changes (unbuilt and untested)
* provide some notes on what needs to be done
* continue to ignore

as desired by the maintainers. Just let me know ;)

fuankg at apache

Oct 18, 2009, 8:28 AM

Post #2 of 6 (203 views)
Permalink

Re: Trunk MPM API changes and the OS/2 and NetWare MPMs [In reply to]

Hi Jeff,
Jeff Trawick schrieb:
> I am happy to
>
> * start committing the necessary changes (unbuilt and untested)
> * provide some notes on what needs to be done
> * continue to ignore
>
> as desired by the maintainers. Just let me know ;)
please do! Although I have current trunk working, its still lacking some
stuff, and I probably did some things wrong; I think I have XXX comments
in it as reminder what still needs tweaks ...

Also, I was recently checking for the optional hook stuff when you
changed mod_watchdog, and I'm not sure yet if it really works - f.e.
from what I see mod_ssl has such an optional hook, but I dont see
mod_status have it plugin ...
I compiled and tested the hook sample modules, and these seem to work ...

thanks, Gün.

brian.havard at gmail

Oct 18, 2009, 1:50 PM

Post #3 of 6 (201 views)
Permalink

Re: Trunk MPM API changes and the OS/2 and NetWare MPMs [In reply to]

Jeff Trawick wrote:
> APIs were changed to avoid hard-wiring the MPM into the base server
> compilation (replacing stuff like MPM_NAME, MPM_CHILD_PID(), mpm.h,
> etc. with callable equivalents).
>
> I didn't make these changes to these two MPMs previously because:
> * OS/2 MPM was not in trunk at the time
> * the NetWare maintainer was ambivalent about keeping the NetWare MPM
> in trunk when I was itching to do this work
>
> I am happy to
>
> * start committing the necessary changes (unbuilt and untested)
> * provide some notes on what needs to be done
> * continue to ignore
>
> as desired by the maintainers. Just let me know ;)
>

I've spent some time getting my own working copy of trunk to build and
run using the OS/2 MPM so I've probably done most of what you're talking
about but I'd certainly be interested in your notes on what should be
done as I've almost certainly missed some things.

trawick at gmail

Nov 2, 2009, 8:43 AM

Post #4 of 6 (120 views)
Permalink

Re: Trunk MPM API changes and the OS/2 and NetWare MPMs [In reply to]

On Sun, Oct 18, 2009 at 12:50 PM, Brian Havard <brian.havard[at]gmail.com> wrote:
> Jeff Trawick wrote:
>> APIs were changed to avoid hard-wiring the MPM into the base server
>> compilation (replacing stuff like MPM_NAME, MPM_CHILD_PID(), mpm.h,
>> etc. with callable equivalents).
>>
>> I didn't make these changes to these two MPMs previously because:
>> * OS/2 MPM was not in trunk at the time
>> * the NetWare maintainer was ambivalent about keeping the NetWare MPM
>> in trunk when I was itching to do this work
>>
>> I am happy to
>>
>> * start committing the necessary changes (unbuilt and untested)
>> * provide some notes on what needs to be done
>> * continue to ignore
>>
>> as desired by the maintainers. Just let me know ;)
>>
>
> I've spent some time getting my own working copy of trunk to build and
> run using the OS/2 MPM so I've probably done most of what you're talking
> about but I'd certainly be interested in your notes on what should be
> done as I've almost certainly missed some things.

Making the same general changes as in r791309 and r831951 should be a
real good start. I can look again after it is committed.

trawick at gmail

Nov 2, 2009, 8:44 AM

Post #5 of 6 (120 views)
Permalink

Re: Trunk MPM API changes and the OS/2 and NetWare MPMs [In reply to]

On Sun, Oct 18, 2009 at 7:28 AM, Guenter Knauf <fuankg[at]apache.org> wrote:
> Hi Jeff,
> Jeff Trawick schrieb:
>> I am happy to
>>
>> * start committing the necessary changes (unbuilt and untested)
>> * provide some notes on what needs to be done
>> * continue to ignore
>>
>> as desired by the maintainers. Just let me know ;)
> please do! Although I have current trunk working, its still lacking some
> stuff, and I probably did some things wrong; I think I have XXX comments
> in it as reminder what still needs tweaks ...

I cleaned up some obvious issues in r831951. It looks close to worker now.

brian.havard at gmail

Nov 3, 2009, 6:19 AM

Post #6 of 6 (109 views)
Permalink

Re: Trunk MPM API changes and the OS/2 and NetWare MPMs [In reply to]

Jeff Trawick wrote:
> On Sun, Oct 18, 2009 at 12:50 PM, Brian Havard <brian.havard[at]gmail.com> wrote:
>
>> Jeff Trawick wrote:
>>
>>> APIs were changed to avoid hard-wiring the MPM into the base server
>>> compilation (replacing stuff like MPM_NAME, MPM_CHILD_PID(), mpm.h,
>>> etc. with callable equivalents).
>>>
>>> I didn't make these changes to these two MPMs previously because:
>>> * OS/2 MPM was not in trunk at the time
>>> * the NetWare maintainer was ambivalent about keeping the NetWare MPM
>>> in trunk when I was itching to do this work
>>>
>>> I am happy to
>>>
>>> * start committing the necessary changes (unbuilt and untested)
>>> * provide some notes on what needs to be done
>>> * continue to ignore
>>>
>>> as desired by the maintainers. Just let me know ;)
>>>
>>>
>> I've spent some time getting my own working copy of trunk to build and
>> run using the OS/2 MPM so I've probably done most of what you're talking
>> about but I'd certainly be interested in your notes on what should be
>> done as I've almost certainly missed some things.
>>
>
> Making the same general changes as in r791309 and r831951 should be a
> real good start. I can look again after it is committed.
>

OK, I've now committed my MPM changes after adding a few things
indicated by your two revisions. Builds and serves up the manual, so far
so good.

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact lists@gossamer-threads.com