Mailing List Archive: Apache: Dev

Dav Locks corrupting; need some troubleshooting tools

Index | Next | Previous | View Threaded

rasputnik at hellooperator

Oct 14, 2009, 6:47 AM

Post #1 of 4 (352 views)
Permalink

Dav Locks corrupting; need some troubleshooting tools

Hi all

I'm on apache 2.0.63, and seeing nonsensical Dav Locks
(symptoms are that files show as being locked by users that couldn't
possibly have locked them).

I *think* I've tracked it down to a bug in mod_dav_fs; it appears that
if files are deleted
from disk (by a mechanism other than Dav), any locks that were taken
out on that file
'jump' so that they apply to a different file altogether.

Are there any tools that let me inspect the content of DavLockDB? And
who's a good person
to talk to if I need to pick over the code?

rasputnik at hellooperator

Oct 15, 2009, 7:27 AM

Post #2 of 4 (311 views)
Permalink

Re: Dav Locks corrupting; need some troubleshooting tools [In reply to]

[.sorry for the crosspost, but not sure where this should go].

To answer my own question:

got to the bottom of it; looks to me like the
lock DB is a hash of

inode <-> locktoken

Steps to reproduce:

* PUT file
* LOCK file
* PROPGET file (note down the locktoken)
use something other than DAV to delete 'file' (e.g. a cronjob)
* PUT newfile (very good chance the inode is reused)
* LOCK newfile (it will fail)
* PROPGET newfile (you'll see it has the same locktoken)

Should I report this as a bug?

On Wed, Oct 14, 2009 at 2:47 PM, Dick Davies
<rasputnik [at] hellooperator> wrote:
> Hi all
>
> I'm on apache 2.0.63, and seeing nonsensical Dav Locks
> (symptoms are that files show as being locked by users that couldn't
> possibly have locked them).
>
> I *think* I've tracked it down to a bug in mod_dav_fs; it appears that
> if files are deleted
> from disk (by a mechanism other than Dav), any locks that were taken
> out on that file
> 'jump' so that they apply to a different file altogether.
>
> Are there any tools that let me inspect the content of DavLockDB? And
> who's a good person
> to talk to if I need to pick over the code?
>

jorton at redhat

Oct 15, 2009, 7:33 AM

Post #3 of 4 (312 views)
Permalink

Re: Dav Locks corrupting; need some troubleshooting tools [In reply to]

On Thu, Oct 15, 2009 at 03:27:29PM +0100, Dick Davies wrote:
> [.sorry for the crosspost, but not sure where this should go].
>
> To answer my own question:
>
> got to the bottom of it; looks to me like the
> lock DB is a hash of
>
> inode <-> locktoken
>
> Steps to reproduce:
>
> * PUT file
> * LOCK file
> * PROPGET file (note down the locktoken)
> use something other than DAV to delete 'file' (e.g. a cronjob)

mod_dav doesn't support operations on the repository outside of its
control - this has always been the case. You should think of the DAV
repository as "owned" by mod_dav.

Regards, Joe

sisred at cf

Oct 15, 2009, 8:21 AM

Post #4 of 4 (311 views)
Permalink

Re: Dav Locks corrupting; need some troubleshooting tools [In reply to]

Is that documented anywhere at all?

In any event, does it made sense to use something other than the
inode as the key into the lockDB - the URI for example?

On Thu, Oct 15, 2009 at 3:33 PM, Joe Orton <jorton [at] redhat> wrote:

>> Steps to reproduce:
>>
>> * PUT file
>> * LOCK file
>> * PROPGET file (note down the locktoken)
>> use something other than DAV to delete 'file' (e.g. a cronjob)
>
> mod_dav doesn't support operations on the repository outside of its
> control - this has always been the case. You should think of the DAV
> repository as "owned" by mod_dav.
>
> Regards, Joe
>

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact lists@gossamer-threads.com