Mailing List Archive: Apache: Dev

[VOTE] release httpd mod_fcgid-2.3.2?

Index | Next | Previous | View Threaded

wrowe at rowe-clan

Sep 28, 2009, 8:30 PM

Post #1 of 10 (618 views)
Permalink

[VOTE] release httpd mod_fcgid-2.3.2?

Quick on the heels of mod_fcgid 2.3.1 we have another candidate for your
consideration, with many improvements to docs and especially the authn/authz
interface.

Please fetch up the newly minted mod_fcgid-2.3.2.tar.gz (or bz2)
or the win32 suitable package mod_fcgid-2.3.2-crlf.zip from:

http://httpd.apache.org/dev/dist/mod_fcgid/

review, take it for a spin, and cast your choice

[ ] -1 for any release of 2.3.2 (regressed from 2.3.1?)
[ ] +1 to release as 2.3.2-beta
[ ] +1 to release as 2.3.2-GA

Note no configuration updates occur yet on make install. Not sure what our
'example' aught to look like, yet. Documentation still needs substantial
attention from fans to fill in the text.

For getting started,

http://svn.apache.org/repos/asf/httpd/mod_fcgid/tags/2.3.2/README-FCGID

Bill

trawick at gmail

Sep 29, 2009, 6:42 AM

Post #2 of 10 (590 views)
Permalink

Re: [VOTE] release httpd mod_fcgid-2.3.2? [In reply to]

On Mon, Sep 28, 2009 at 11:30 PM, William A. Rowe, Jr.
<wrowe [at] rowe-clan>wrote:

> Quick on the heels of mod_fcgid 2.3.1 we have another candidate for your
> consideration, with many improvements to docs and especially the
> authn/authz
> interface.
>
> Please fetch up the newly minted mod_fcgid-2.3.2.tar.gz (or bz2)
> or the win32 suitable package mod_fcgid-2.3.2-crlf.zip from:
>
> http://httpd.apache.org/dev/dist/mod_fcgid/
>

Thanks!

>
> [X] +1 to release as 2.3.2-beta
>

(new directive names need to be agreed to; maybe I can find a way to help)

It is holding up nicely with 32-bit and 64-bit httpd 2.2.x on OpenSolaris
2009.06, and 32-bit httpd 2.0.x and 2.2.x on Ubuntu 8.10.

jim at jaguNET

Sep 30, 2009, 11:13 AM

Post #3 of 10 (585 views)
Permalink

Re: [VOTE] release httpd mod_fcgid-2.3.2? [In reply to]

On Sep 28, 2009, at 11:30 PM, William A. Rowe, Jr. wrote:

> Quick on the heels of mod_fcgid 2.3.1 we have another candidate for
> your
> consideration, with many improvements to docs and especially the
> authn/authz
> interface.
>
> Please fetch up the newly minted mod_fcgid-2.3.2.tar.gz (or bz2)
> or the win32 suitable package mod_fcgid-2.3.2-crlf.zip from:
>
> http://httpd.apache.org/dev/dist/mod_fcgid/
>
> review, take it for a spin, and cast your choice
>
> [ ] -1 for any release of 2.3.2 (regressed from 2.3.1?)
> [ ] +1 to release as 2.3.2-beta
> [ ] +1 to release as 2.3.2-GA
>
> Note no configuration updates occur yet on make install. Not sure
> what our
> 'example' aught to look like, yet. Documentation still needs
> substantial
> attention from fans to fill in the text.
>
> For getting started,
>
> http://svn.apache.org/repos/asf/httpd/mod_fcgid/tags/2.3.2/README-
> FCGID
>

+1 release as 2.3.2-beta

wrowe at rowe-clan

Oct 3, 2009, 9:14 AM

Post #4 of 10 (577 views)
Permalink

Re: [VOTE] release httpd mod_fcgid-2.3.2? [In reply to]

William A. Rowe, Jr. wrote:
>
> [X] -1 for any release of 2.3.2 (regressed from 2.3.1?)
> [ ] +1 to release as 2.3.2-beta
> [ ] +1 to release as 2.3.2-GA

C:\local0\asf\release\module-build\mod_fcgid\modules\fcgid\fcgid_pm_win.c(142) :
error C2065: 'LOG_WARNING' : undeclared identifier
fcgid_proc_win.c
C:\local0\asf\release\module-build\mod_fcgid\modules\fcgid\fcgid_proc_win.c(164)
: error C2143: syntax error : missing ';' before 'if'
fcgid_proctbl_win.c
fcgid_protocol.c
fcgid_spawn_ctl.c
mod_fcgid.c
C:\local0\asf\release\module-build\mod_fcgid\modules\fcgid\mod_fcgid.c(35) : war
ning C4273: 'fcgid_module' : inconsistent dll linkage. dllexport assumed.

But in the spirit of release early, release often, we'll try again.

trawick at gmail

Oct 3, 2009, 9:29 AM

Post #5 of 10 (570 views)
Permalink

Re: [VOTE] release httpd mod_fcgid-2.3.2? [In reply to]

On Sat, Oct 3, 2009 at 12:14 PM, William A. Rowe, Jr.
<wrowe [at] rowe-clan>wrote:

> William A. Rowe, Jr. wrote:
> >
> > [X] -1 for any release of 2.3.2 (regressed from 2.3.1?)
> > [ ] +1 to release as 2.3.2-beta
> > [ ] +1 to release as 2.3.2-GA
>
> C:\local0\asf\release\module-build\mod_fcgid\modules\fcgid\fcgid_pm_win.c(142)
> :
> error C2065: 'LOG_WARNING' : undeclared identifier
> fcgid_proc_win.c
>
> C:\local0\asf\release\module-build\mod_fcgid\modules\fcgid\fcgid_proc_win.c(164)
> : error C2143: syntax error : missing ';' before 'if'
> fcgid_proctbl_win.c
> fcgid_protocol.c
> fcgid_spawn_ctl.c
> mod_fcgid.c
> C:\local0\asf\release\module-build\mod_fcgid\modules\fcgid\mod_fcgid.c(35)
> : war
> ning C4273: 'fcgid_module' : inconsistent dll linkage. dllexport assumed.
>
>
My apologies :(

Shall I take a stab at fixing (but since you get to press a button to build
and I don't, it may be less trouble for you to fix/rebuild at the same
time)?

But in the spirit of release early, release often, we'll try again.
>
>
BTW, do you have bandwidth/interest to look at the "[mod_fcgid] Cleaning up
configuration directive names" thread? I could make some progress on that
since it would be useful to finalize those ASAP.

trawick at gmail

Oct 3, 2009, 10:23 AM

Post #6 of 10 (570 views)
Permalink

Re: [VOTE] release httpd mod_fcgid-2.3.2? [In reply to]

wrowe at rowe-clan

Oct 3, 2009, 12:38 PM

Post #7 of 10 (577 views)
Permalink

Re: [VOTE] release httpd mod_fcgid-2.3.2? [In reply to]

Jeff Trawick wrote:
>
> supposedly fixed now; please try again

And I whacked the module structure, always dllexport'ed. So now, from trunk;

--------------------Configuration: mod_fcgid - Win32 Release--------------------
Generating fcgid_config.h
Compiling resources...
Compiling...
fcgid_bridge.c
fcgid_bucket.c
fcgid_conf.c
fcgid_filter.c
fcgid_pm_main.c
fcgid_pm_win.c
fcgid_proc_win.c
fcgid_proctbl_win.c
fcgid_protocol.c
fcgid_spawn_ctl.c
mod_fcgid.c
Generating Code...
Linking...
Creating library Release/mod_fcgid.lib and object Release/mod_fcgid.exp
Embed .manifest

mod_fcgid.so - 0 error(s), 0 warning(s)

Looking good :)

fuankg at apache

Oct 3, 2009, 4:19 PM

Post #8 of 10 (563 views)
Permalink

Re: [VOTE] release httpd mod_fcgid-2.3.2? [In reply to]

Bill,
William A. Rowe, Jr. schrieb:
> William A. Rowe, Jr. wrote:
>> [X] -1 for any release of 2.3.2 (regressed from 2.3.1?)
>> [ ] +1 to release as 2.3.2-beta
>> [ ] +1 to release as 2.3.2-GA
>
> C:\local0\asf\release\module-build\mod_fcgid\modules\fcgid\fcgid_pm_win.c(142) :
> error C2065: 'LOG_WARNING' : undeclared identifier
> fcgid_proc_win.c
a friend posted a patch to me about same but in fcgi_pm_unix.c ...
I've not looked into it, but will shortly commit below if you dont
object ...

--- fcgid_pm_unix.c.orig 2009-09-18 06:14:45.000000000 +1000
+++ fcgid_pm_unix.c 2009-09-30 12:52:22.609375000 +1000
@@ -22,6 +22,7 @@
#include "apr_queue.h"
#include "apr_global_mutex.h"
#include "apr_support.h"
+#include "http_config.h"
#include "fcgid_pm.h"
#include "fcgid_pm_main.h"
#include "fcgid_conf.h"
@@ -239,7 +240,7 @@
"mod_fcgid: Process manager %" APR_PID_T_FMT "
started", getpid());

if ((rv = init_signal(main_server)) != APR_SUCCESS) {
- ap_log_error(APLOG_MARK, LOG_EMERG, 0, main_server,
+ ap_log_error(APLOG_MARK, APLOG_EMERG, 0, main_server,
"mod_fcgid: can't install signal handler,
exiting now");
exit(1);
}
@@ -247,7 +248,7 @@
/* if running as root, switch to configured user */
if (ap_unixd_config.suexec_enabled) {
if (getuid() != 0) {
- ap_log_error(APLOG_MARK, LOG_EMERG, 0, main_server,
+ ap_log_error(APLOG_MARK, APLOG_EMERG, 0, main_server,
"mod_fcgid: current user is not root while
suexec is enabled, exiting now");
exit(1);
}
@@ -412,7 +413,7 @@
initenv_arr = apr_table_elts(initenv);
initenv_entry = (apr_table_entry_t *) initenv_arr->elts;
if (initenv_arr->nelts > INITENV_CNT)
- ap_log_rerror(APLOG_MARK, LOG_WARNING, 0, r,
+ ap_log_rerror(APLOG_MARK, APLOG_WARNING, 0, r,
"mod_fcgid: %d environment variables dropped;
increase "
"INITENV_CNT in fcgid_pm.h from %d to at
least %d",
initenv_arr->nelts - INITENV_CNT,
@@ -459,7 +460,7 @@

/* Get the global mutex before posting the request */
if ((rv = apr_global_mutex_lock(g_pipelock)) != APR_SUCCESS) {
- ap_log_rerror(APLOG_MARK, LOG_WARNING, rv, r,
+ ap_log_rerror(APLOG_MARK, APLOG_WARNING, rv, r,
"mod_fcgid: can't get pipe mutex");
exit(0);
}
@@ -468,7 +469,7 @@
apr_file_write_full(g_ap_write_pipe, command, nbytes,
NULL)) != APR_SUCCESS) {
/* Just print some error log and fall through */
- ap_log_rerror(APLOG_MARK, LOG_WARNING, rv, r,
+ ap_log_rerror(APLOG_MARK, APLOG_WARNING, rv, r,
"mod_fcgid: can't write spawn command");
} else {
/* Wait the finish notify while send the request successfully */
@@ -476,14 +477,14 @@
if ((rv =
apr_file_read(g_ap_read_pipe, &notifybyte,
&nbytes)) != APR_SUCCESS) {
- ap_log_rerror(APLOG_MARK, LOG_WARNING, rv, r,
+ ap_log_rerror(APLOG_MARK, APLOG_WARNING, rv, r,
"mod_fcgid: can't get notify from process
manager");
}
}

/* Release the lock */
if ((rv = apr_global_mutex_unlock(g_pipelock)) != APR_SUCCESS) {
- ap_log_rerror(APLOG_MARK, LOG_WARNING, rv, r,
+ ap_log_rerror(APLOG_MARK, APLOG_WARNING, rv, r,
"mod_fcgid: can't release pipe mutex");
exit(0);
}
@@ -500,7 +501,7 @@
if ((rv =
apr_file_write(g_pm_write_pipe, &notifybyte,
&nbytes)) != APR_SUCCESS) {
- ap_log_error(APLOG_MARK, LOG_WARNING, rv, main_server,
+ ap_log_error(APLOG_MARK, APLOG_WARNING, rv, main_server,
"mod_fcgid: can't send notify from process manager");
}

@@ -522,7 +523,7 @@

/* Log any unexpect result */
if (rv != APR_SUCCESS && !APR_STATUS_IS_TIMEUP(rv)) {
- ap_log_error(APLOG_MARK, LOG_WARNING, rv, main_server,
+ ap_log_error(APLOG_MARK, APLOG_WARNING, rv, main_server,
"mod_fcgid: error while waiting for message from
pipe");
return rv;
}

Gün.

trawick at gmail

Oct 3, 2009, 4:59 PM

Post #9 of 10 (567 views)
Permalink

Re: [VOTE] release httpd mod_fcgid-2.3.2? [In reply to]

On Sat, Oct 3, 2009 at 7:19 PM, Guenter Knauf <fuankg [at] apache> wrote:

> Bill,
> William A. Rowe, Jr. schrieb:
> > William A. Rowe, Jr. wrote:
> >> [X] -1 for any release of 2.3.2 (regressed from 2.3.1?)
> >> [ ] +1 to release as 2.3.2-beta
> >> [ ] +1 to release as 2.3.2-GA
> >
> >
> C:\local0\asf\release\module-build\mod_fcgid\modules\fcgid\fcgid_pm_win.c(142)
> :
> > error C2065: 'LOG_WARNING' : undeclared identifier
> > fcgid_proc_win.c
> a friend posted a patch to me about same but in fcgi_pm_unix.c ...
> I've not looked into it, but will shortly commit below if you dont
> object ...
>
> --- fcgid_pm_unix.c.orig 2009-09-18 06:14:45.000000000 +1000
> +++ fcgid_pm_unix.c 2009-09-30 12:52:22.609375000 +1000
> @@ -22,6 +22,7 @@
> #include "apr_queue.h"
> #include "apr_global_mutex.h"
> #include "apr_support.h"
> +#include "http_config.h"
>

should be http_log.h AFAICT

> @@ -247,7 +248,7 @@
> /* if running as root, switch to configured user */
> if (ap_unixd_config.suexec_enabled) {
> if (getuid() != 0) {
> - ap_log_error(APLOG_MARK, LOG_EMERG, 0, main_server,
> + ap_log_error(APLOG_MARK, APLOG_EMERG, 0, main_server,
>

go for it; it is a nice cleanup (but no operational change since the values
are by definition the same)

I broke the Windows logging with one of these non-AP LOG_foo, perhaps after
starting at these calls a while and not noticing ;)

fuankg at apache

Oct 3, 2009, 5:31 PM

Post #10 of 10 (573 views)
Permalink

Re: [VOTE] release httpd mod_fcgid-2.3.2? [In reply to]

Jeff,
Jeff Trawick schrieb:
> --- fcgid_pm_unix.c.orig 2009-09-18 06:14:45.000000000 +1000
> +++ fcgid_pm_unix.c 2009-09-30 12:52:22.609375000 +1000
> @@ -22,6 +22,7 @@
> #include "apr_queue.h"
> #include "apr_global_mutex.h"
> #include "apr_support.h"
> +#include "http_config.h"
>
>
> should be http_log.h AFAICT
this wasnt needed for the logs, but for some defines in mpm.h AFAICT ...
he was breave enough to try a NetWare build, but that finally failed
since we have no poll on NW :)
I've not yet time to look into the mod ...

G�n.

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads