nick at webthing
Sep 24, 2009, 11:24 PM
Post #1 of 1
(222 views)
Permalink
|
|
Re: DO NOT REPLY [Bug 47447] Add possibility to use client IP as a value in RequestHeader (and Header, too, but this is almost meaningless)
|
|
On 25 Sep 2009, at 06:32, bugzilla [at] apache wrote:
> https://issues.apache.org/bugzilla/show_bug.cgi?id=47447
>
> --- Comment #2 from Will Rowe <wrowe [at] apache> 2009-09-24
> 22:32:34 PDT ---
> Here's my problem with the RequestHeader hacks. They are hacks.
>
> We have a whole registration system to provide additional providers
> to %*
> log formats, and no way to then expose those to other modules
> providing
> %escape features like RequestHeader. I had a solution for X-FF
> based on
> picking one of these up, and lo and behold, there is no API in
> mod_log_config
> to recover all the useful extensions added to logging.
>
> The right way to fix this is to move the %escape registration from the
> mod_log_config to the core, and let every module who wants to call
> out to
> a new provider in the core which collects all available features.
1st reaction to that: sounds like a very similar exercise to moving
ap_expr
into core. The log format stuff might be a good fit there too?
2nd reaction: ap_expr remains work-in-progress, and isn't always simple
to retrofit (big examples where it has yet to be done are mod_rewrite
and
mod_ssl). Is this stuff going to be a simpler exercise?
--
Nick Kew
|
