Mailing List Archive: Apache: Dev

sendfile in darwin

Index | Next | Previous | View Threaded

jim at jaguNET

May 6, 2008, 10:43 AM

Post #1 of 8 (213 views)
Permalink

sendfile in darwin

Hmmm.... at least in apr-1.3.0 (HEAD), sendfile in Darwin still
seems broken... getting:

[Tue May 06 13:35:26 2008] [crit] [Tue May 06 13:35:26 2008] file
core_filters.c,
line 391, assertion "total_bytes_left > 0 && tmplen > 0" failed

from the test framework for httpd:

t/apache/getfile...........ok 1/144# Failed test 143 in t/apache/
getfile.t at line 23 fail #143
t/apache/getfile...........NOK 143# Failed test 144 in t/apache/
getfile.t at line 23 fail #144
t/apache/getfile...........FAILED tests 143-144
Failed 2/144 tests, 98.61% okay

Will see how the latest 1.2.x does...

wrowe at rowe-clan

May 6, 2008, 10:53 AM

Post #2 of 8 (207 views)
Permalink

Re: sendfile in darwin [In reply to]

Jim Jagielski wrote:
>
> Will see how the latest 1.2.x does...

Uhm - 1.2.x deliberately disables sendfile detection on Darwin.

jim at jaguNET

May 6, 2008, 10:59 AM

Post #3 of 8 (207 views)
Permalink

Re: sendfile in darwin [In reply to]

On May 6, 2008, at 1:53 PM, William A. Rowe, Jr. wrote:

> Jim Jagielski wrote:
>> Will see how the latest 1.2.x does...
>
> Uhm - 1.2.x deliberately disables sendfile detection on Darwin.
>

Yep, and so the test runs cleanly (confirmed)...

jim at jaguNET

May 6, 2008, 1:20 PM

Post #4 of 8 (207 views)
Permalink

Re: sendfile in darwin [In reply to]

I should have some cycles to dig deeper on this tomorrow...

jim at jaguNET

May 7, 2008, 6:14 AM

Post #5 of 8 (196 views)
Permalink

Re: sendfile in darwin [In reply to]

Just a quick FYI: Simply using the FreeBSD logic flow for
sendfile (ie: adding || defined(DARWIN) and pulling out the
existing DARWIN-specific section) clears up the problems I saw
with the getfile tests...

So I guess I need to dig deeper on this...

BTW: This is on OS X 10.5.2 (Darwin 9.2.2)

On May 6, 2008, at 4:20 PM, Jim Jagielski wrote:

> I should have some cycles to dig deeper on this tomorrow...
>

jim at jaguNET

May 7, 2008, 6:25 AM

Post #6 of 8 (196 views)
Permalink

Re: sendfile in darwin [In reply to]

On May 7, 2008, at 9:14 AM, Jim Jagielski wrote:

> Just a quick FYI: Simply using the FreeBSD logic flow for
> sendfile (ie: adding || defined(DARWIN) and pulling out the
> existing DARWIN-specific section) clears up the problems I saw
> with the getfile tests...
>
> So I guess I need to dig deeper on this...
>

Hold on... this may not be correct... double checking

jim at jaguNET

May 7, 2008, 6:31 AM

Post #7 of 8 (196 views)
Permalink

Re: sendfile in darwin [In reply to]

On May 7, 2008, at 9:25 AM, Jim Jagielski wrote:

>
> On May 7, 2008, at 9:14 AM, Jim Jagielski wrote:
>
>> Just a quick FYI: Simply using the FreeBSD logic flow for
>> sendfile (ie: adding || defined(DARWIN) and pulling out the
>> existing DARWIN-specific section) clears up the problems I saw
>> with the getfile tests...
>>
>> So I guess I need to dig deeper on this...
>>
>
> Hold on... this may not be correct... double checking
>

Yeah, ignore the above for now...

jim at jaguNET

May 7, 2008, 10:29 AM

Post #8 of 8 (194 views)
Permalink

Re: sendfile in darwin [In reply to]

On May 7, 2008, at 9:31 AM, Jim Jagielski wrote:

>
> On May 7, 2008, at 9:25 AM, Jim Jagielski wrote:
>
>>
>> On May 7, 2008, at 9:14 AM, Jim Jagielski wrote:
>>
>>> Just a quick FYI: Simply using the FreeBSD logic flow for
>>> sendfile (ie: adding || defined(DARWIN) and pulling out the
>>> existing DARWIN-specific section) clears up the problems I saw
>>> with the getfile tests...
>>>
>>> So I guess I need to dig deeper on this...
>>>
>>
>> Hold on... this may not be correct... double checking
>>
>
> Yeah, ignore the above for now...
>

Squashed... Spent a LOT of time on this (even ported the
Linux impl to Darwin, which actually is nicer since it
uses apr_socket_sendv() and does things like checking
partial header/footer stuff, which I may eventually
commit to trunk) and the fix was simple...

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact lists@gossamer-threads.com