Mailing List Archive: Apache: Dev

Please Review! Path for os/win32/os.h - new reports Win64 when build for 64-bit

Index | Next | Previous | View Threaded

jorge.schrauwen at gmail

Jul 26, 2006, 1:10 PM

Post #1 of 6 (626 views)
Permalink

Please Review! Path for os/win32/os.h - new reports Win64 when build for 64-bit

Ok this is my first path so please bare with me and review.

Since I'm rather new to C I did a lot of research and testing on this.
More information regarding the changes:
http://msdn.microsoft.com/msdnmag/issues/06/05/x64/default.aspx#S4

----------- os\win32\os.h -----------

--- os.h.orig 2006-04-22 03:53:06.000000000 +0200
+++ os.h 2006-07-26 21:22:24.000516000 +0200
@@ -38,7 +38,11 @@
#include <io.h>
#include <fcntl.h>

+//Checking the architecture we are compiling for (Itanium 64-bit, x64
(AMD64/EM64T) or x86)
#define PLATFORM "Win32"
+#ifdef _WIN64
+# define PLATFORM "Win64"
+#endif

/* going away shortly... */
#define HAVE_DRIVE_LETTERS

thanks for your time to review.

--
~Jorge

Attachments:

os.h.diff (0.39 KB)

rpluem at apache

Jul 26, 2006, 1:42 PM

Post #2 of 6 (593 views)
Permalink

Re: Please Review! Path for os/win32/os.h - new reports Win64 when build for 64-bit [In reply to]

On 07/26/2006 10:10 PM, Jorge Schrauwen wrote:
> Ok this is my first path so please bare with me and review.
>
> Since I'm rather new to C I did a lot of research and testing on this.
> More information regarding the changes:
> http://msdn.microsoft.com/msdnmag/issues/06/05/x64/default.aspx#S4
>
> ----------- os\win32\os.h -----------
>
> --- os.h.orig 2006-04-22 03:53:06.000000000 +0200
> +++ os.h 2006-07-26 21:22:24.000516000 +0200
> @@ -38,7 +38,11 @@
> #include <io.h>
> #include <fcntl.h>
>
> +//Checking the architecture we are compiling for (Itanium 64-bit, x64
> (AMD64/EM64T) or x86)

I cannot comment on the subject itself as I am not a windows man, but only on
the style: Please do not use C++ style comments like //. Please use always /* */.
Regarding style the following page is very helpful:

http://httpd.apache.org/dev/styleguide.html

Regards

Rüdiger

jorge.schrauwen at gmail

Jul 26, 2006, 2:00 PM

Post #3 of 6 (596 views)
Permalink

Re: Please Review! Path for os/win32/os.h - new reports Win64 when build for 64-bit [In reply to]

I just tried lots of diferent comment styles like #, ', ... till i found one
that worked. never though there would be more that one... makes sence
though, especially for larger blocks of comment.

So here is an updated diff file.

On 7/26/06, Ruediger Pluem <rpluem[at]apache.org> wrote:
>
>
>
> On 07/26/2006 10:10 PM, Jorge Schrauwen wrote:
> > Ok this is my first path so please bare with me and review.
> >
> > Since I'm rather new to C I did a lot of research and testing on this.
> > More information regarding the changes:
> > http://msdn.microsoft.com/msdnmag/issues/06/05/x64/default.aspx#S4
> >
> > ----------- os\win32\os.h -----------
> >
> > --- os.h.orig 2006-04-22 03:53:06.000000000 +0200
> > +++ os.h 2006-07-26 21:22:24.000516000 +0200
> > @@ -38,7 +38,11 @@
> > #include <io.h>
> > #include <fcntl.h>
> >
> > +//Checking the architecture we are compiling for (Itanium 64-bit, x64
> > (AMD64/EM64T) or x86)
>
> I cannot comment on the subject itself as I am not a windows man, but only
> on
> the style: Please do not use C++ style comments like //. Please use always
> /* */.
> Regarding style the following page is very helpful:
>
> http://httpd.apache.org/dev/styleguide.html
>
> Regards
>
> Rüdiger
>
>

--
~Jorge

Attachments:

os.h.diff (0.33 KB)

wrowe at rowe-clan

Jul 26, 2006, 2:26 PM

Post #4 of 6 (595 views)
Permalink

Re: Please Review! Path for os/win32/os.h - new reports Win64 when build for 64-bit [In reply to]

Jorge Schrauwen wrote:
> I just tried lots of diferent comment styles like #, ', ... till i found
> one that worked. never though there would be more that one... makes
> sence though, especially for larger blocks of comment.

It makes sense because MS has spoiled you into thinking // is for comments.
It's not. That's a C++ comment. Unfortunately, since MS uses the same
lexar (they made C a subset of C++ which isn't to spec) and permitted this
bastardization, most MS users are clueless.

Bill

jorge.schrauwen at gmail

Jun 19, 2009, 9:30 AM

Post #5 of 6 (430 views)
Permalink

Re: Please Review! Path for os/win32/os.h - new reports Win64 when build for 64-bit [In reply to]

Sorry to dig up this old thread again but some users of my unofficial binary
have been complaining that it still says Win32.

So any chances somebody could look at this again. It's a rather trivial
change I think.

~Jorge

On Wed, Jul 26, 2006 at 11:00 PM, Jorge Schrauwen <jorge.schrauwen[at]gmail.com
> wrote:

> I just tried lots of diferent comment styles like #, ', ... till i found
> one that worked. never though there would be more that one... makes sence
> though, especially for larger blocks of comment.
>
> So here is an updated diff file.
>
> On 7/26/06, Ruediger Pluem <rpluem[at]apache.org> wrote:
>>
>>
>>
>> On 07/26/2006 10:10 PM, Jorge Schrauwen wrote:
>> > Ok this is my first path so please bare with me and review.
>> >
>> > Since I'm rather new to C I did a lot of research and testing on this.
>> > More information regarding the changes:
>> > http://msdn.microsoft.com/msdnmag/issues/06/05/x64/default.aspx#S4
>> >
>> > ----------- os\win32\os.h -----------
>> >
>> > --- os.h.orig 2006-04-22 03:53:06.000000000 +0200
>> > +++ os.h 2006-07-26 21:22:24.000516000 +0200
>> > @@ -38,7 +38,11 @@
>> > #include <io.h>
>> > #include <fcntl.h>
>> >
>> > +//Checking the architecture we are compiling for (Itanium 64-bit, x64
>> > (AMD64/EM64T) or x86)
>>
>> I cannot comment on the subject itself as I am not a windows man, but only
>> on
>> the style: Please do not use C++ style comments like //. Please use always
>> /* */.
>> Regarding style the following page is very helpful:
>>
>> http://httpd.apache.org/dev/styleguide.html
>>
>> Regards
>>
>> Rüdiger
>>
>>
>
>
> --
> ~Jorge

Attachments:

os.h.diff (0.33 KB)

jorge.schrauwen at gmail

Jun 24, 2009, 1:00 PM

Post #6 of 6 (389 views)
Permalink

Re: Please Review! Path for os/win32/os.h - new reports Win64 when build for 64-bit [In reply to]

I thought I did but couldn't find it.

I've create a new bug report:
https://issues.apache.org/bugzilla/show_bug.cgi?id=47418

~Jorge

On Wed, Jun 24, 2009 at 9:40 PM, Jorge Schrauwen
<jorge.schrauwen[at]gmail.com>wrote:

> I can't remember,
>
> I'll open one tomorrow when I have access to my updated patch.
>
> ~Jorge
>
>
>
> On Wed, Jun 24, 2009 at 7:55 PM, Mario Brandt<jblond[at]gmail.com> wrote:
> > Hi Jorge,
> > did you also open a bug in bugzilla?
> >
> > Mario
> >
> > On Fri, Jun 19, 2009 at 6:30 PM, Jorge
> > Schrauwen<jorge.schrauwen[at]gmail.com> wrote:
> >> Sorry to dig up this old thread again but some users of my unofficial
> binary
> >> have been complaining that it still says Win32.
> >>
> >> So any chances somebody could look at this again. It's a rather trivial
> >> change I think.
> >>
> >> ~Jorge
> >
>

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact lists@gossamer-threads.com