Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: Apache: Dev

Re: svn commit: r423886 - in /httpd/httpd/trunk: CHANGES server/request.c

 

 

Apache dev RSS feed   Index | Next | Previous | View Threaded


jorton at redhat

Jul 20, 2006, 5:04 AM

Post #1 of 8 (1534 views)
Permalink
Re: svn commit: r423886 - in /httpd/httpd/trunk: CHANGES server/request.c

On Thu, Jul 20, 2006 at 11:01:08AM -0000, rpluem [at] apache wrote:
> Author: rpluem
> Date: Thu Jul 20 04:01:07 2006
> New Revision: 423886
>
> URL: http://svn.apache.org/viewvc?rev=423886&view=rev
> Log:
> * Check for symbolic links of the target file in the optimized case that we
> had already done this specific directory walk for this request. This can
> happen when we have an internal redirect, like the ones caused by mod_dir
> (/ -> index.html). See also
>
> http://mail-archives.apache.org/mod_mbox/httpd-dev/200607.mbox/%3c44B5521F.8050906 [at] globalvanet%3e
>
> If we do not do this we have a security hole as the FollowSymLinks and
> SymLinksIfOwnerMatch settings can circumvented this way.

I think it's a *very* bad idea to imply that SymLinksIfOwnerMatch is a
security feature.

If you did want to call this a "security feature" then you also need to
fix the big fat race condition inbetween all those nice careful stat()
calls and the default handler going to open the file. Which I doubt
would be simple to say the least.

I'd stay well clear of the word "security" here.

joe


rpluem at apache

Jul 20, 2006, 5:42 AM

Post #2 of 8 (1429 views)
Permalink
Re: svn commit: r423886 - in /httpd/httpd/trunk: CHANGES server/request.c [In reply to]

On 20.07.2006 14:04, Joe Orton wrote:


>
> I think it's a *very* bad idea to imply that SymLinksIfOwnerMatch is a
> security feature.
>
> If you did want to call this a "security feature" then you also need to
> fix the big fat race condition inbetween all those nice careful stat()
> calls and the default handler going to open the file. Which I doubt
> would be simple to say the least.

This is true.

>
> I'd stay well clear of the word "security" here.

I guess I can't change the log entry anymore. All I can do is adjust the CHANGES
entry. Would that address your concerns?

Regards

RĂ¼diger


justin at erenkrantz

Jul 20, 2006, 9:10 AM

Post #3 of 8 (1440 views)
Permalink
Re: svn commit: r423886 - in /httpd/httpd/trunk: CHANGES server/request.c [In reply to]

On 7/20/06, Ruediger Pluem <rpluem [at] apache> wrote:
> I guess I can't change the log entry anymore. All I can do is adjust the CHANGES
> entry. Would that address your concerns?

svn propchange --revprop -r423886 svn:log https://svn.apache.org/repos/asf/

HTH. -- justin


rooneg at electricjellyfish

Jul 20, 2006, 9:11 AM

Post #4 of 8 (1429 views)
Permalink
Re: svn commit: r423886 - in /httpd/httpd/trunk: CHANGES server/request.c [In reply to]

On 7/20/06, Ruediger Pluem <rpluem [at] apache> wrote:

> I guess I can't change the log entry anymore. All I can do is adjust the CHANGES
> entry. Would that address your concerns?

Actually you can change the log entry. Try 'svn pedit --revprop -r REVISION'

-garrett


wrowe at rowe-clan

Jul 20, 2006, 11:02 AM

Post #5 of 8 (1424 views)
Permalink
Re: svn commit: r423886 - in /httpd/httpd/trunk: CHANGES server/request.c [In reply to]

Joe Orton wrote:
>
> I think it's a *very* bad idea to imply that SymLinksIfOwnerMatch is a
> security feature.
>
> If you did want to call this a "security feature" then you also need to
> fix the big fat race condition inbetween all those nice careful stat()
> calls and the default handler going to open the file. Which I doubt
> would be simple to say the least.
>
> I'd stay well clear of the word "security" here.

+1. I simply don't see how we can permanently solve every case where users
are permitted to modify the server. And in fact; I'd like us to finally
divorce all of the "foolish/nefarious web author has done X to administrator's
server", into their own class of bugs. Let's give this a name other than
'security vulnerability'.

There are a bazillion other things nefarious users, who an administrator has
put faith in, can do to a server. Let's try to narrow this down to "Untrusted
User" and "Untrusted Author" categories (1. has a shell for various operations
to perms, symlinks, run scripts, etc etc), 2. can only place 'files' into the
web space).

The "security" rule of apache is simple, anything user "nobody" can see, apache
is capable of serving, and it's up to the administrator to configure such that

1. user "nobody" has no access to the files, or
2. configure apache in such as was as to "avoid" serving those files.


wrowe at rowe-clan

Jul 20, 2006, 11:03 AM

Post #6 of 8 (1439 views)
Permalink
Re: svn commit: r423886 - in /httpd/httpd/trunk: CHANGES server/request.c [In reply to]

Ruediger Pluem wrote:
>
> I guess I can't change the log entry anymore. All I can do is adjust the CHANGES
> entry. Would that address your concerns?

You can. Syntax escapes me at the moment.


rpluem at apache

Jul 20, 2006, 3:08 PM

Post #7 of 8 (1424 views)
Permalink
Re: svn commit: r423886 - in /httpd/httpd/trunk: CHANGES server/request.c [In reply to]

On 07/20/2006 06:11 PM, Garrett Rooney wrote:

>
>
> Actually you can change the log entry. Try 'svn pedit --revprop -r
> REVISION'
>
> -garrett

Thanks for your help Garrett and Justin. I mixed both of your proposals
and it worked just fine :-)

Regards

Rüdiger


rpluem at apache

Jul 20, 2006, 3:13 PM

Post #8 of 8 (1437 views)
Permalink
Re: svn commit: r423886 - in /httpd/httpd/trunk: CHANGES server/request.c [In reply to]

On 07/20/2006 02:04 PM, Joe Orton wrote:

>
> I think it's a *very* bad idea to imply that SymLinksIfOwnerMatch is a
> security feature.
>
> If you did want to call this a "security feature" then you also need to
> fix the big fat race condition inbetween all those nice careful stat()
> calls and the default handler going to open the file. Which I doubt
> would be simple to say the least.
>
> I'd stay well clear of the word "security" here.

I adjusted the svn log message (http://svn.apache.org/viewvc?view=rev&revision=423886)
and removed the word SECURITY from the CHANGES file (http://svn.apache.org/viewvc?view=rev&revision=424084).
I hope this addresses your concerns.

Regards

RĂ¼diger

Apache dev RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.