trawick at apache
Nov 19, 2009, 12:00 PM
Post #1 of 1
(158 views)
Permalink
|
|
svn commit: r882269 - in /httpd/httpd/trunk: modules/http/http_filters.c modules/proxy/mod_proxy_http.c server/log.c support/htcacheclean.c
|
|
Author: trawick
Date: Thu Nov 19 20:00:12 2009
New Revision: 882269
URL: http://svn.apache.org/viewvc?rev=882269&view=rev
Log:
fix or complain about some invalid errno references
Modified:
httpd/httpd/trunk/modules/http/http_filters.c
httpd/httpd/trunk/modules/proxy/mod_proxy_http.c
httpd/httpd/trunk/server/log.c
httpd/httpd/trunk/support/htcacheclean.c
Modified: httpd/httpd/trunk/modules/http/http_filters.c
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/http/http_filters.c?rev=882269&r1=882268&r2=882269&view=diff
==============================================================================
--- httpd/httpd/trunk/modules/http/http_filters.c (original)
+++ httpd/httpd/trunk/modules/http/http_filters.c Thu Nov 19 20:00:12 2009
@@ -272,7 +272,6 @@
char *endstr;
ctx->state = BODY_LENGTH;
- errno = 0;
/* Protects against over/underflow, non-digit chars in the
* string (excluding leading space) (the endstr checks)
Modified: httpd/httpd/trunk/modules/proxy/mod_proxy_http.c
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/proxy/mod_proxy_http.c?rev=882269&r1=882268&r2=882269&view=diff
==============================================================================
--- httpd/httpd/trunk/modules/proxy/mod_proxy_http.c (original)
+++ httpd/httpd/trunk/modules/proxy/mod_proxy_http.c Thu Nov 19 20:00:12 2009
@@ -1145,7 +1145,7 @@
}
if (rv != OK) {
- /* apr_errno value has been logged in lower level method */
+ /* apr_status_t value has been logged in lower level method */
ap_log_error(APLOG_MARK, APLOG_ERR, 0, r->server,
"proxy: pass request body failed to %pI (%s)"
" from %s (%s)",
Modified: httpd/httpd/trunk/server/log.c
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/server/log.c?rev=882269&r1=882268&r2=882269&view=diff
==============================================================================
--- httpd/httpd/trunk/server/log.c (original)
+++ httpd/httpd/trunk/server/log.c Thu Nov 19 20:00:12 2009
@@ -494,6 +494,7 @@
* because it points to the old error log, or back to the tty
* of the submitter.
* XXX: This is BS - /dev/null is non-portable
+ * errno-as-apr_status_t is also non-portable
*/
if (replace_stderr && freopen("/dev/null", "w", stderr) == NULL) {
ap_log_error(APLOG_MARK, APLOG_CRIT, errno, s_main,
Modified: httpd/httpd/trunk/support/htcacheclean.c
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/support/htcacheclean.c?rev=882269&r1=882268&r2=882269&view=diff
==============================================================================
--- httpd/httpd/trunk/support/htcacheclean.c (original)
+++ httpd/httpd/trunk/support/htcacheclean.c Thu Nov 19 20:00:12 2009
@@ -342,7 +342,7 @@
}
}
- /* this may look strange but apr_stat() may return errno which
+ /* this may look strange but apr_stat() may return an error which
* is system dependent and there may be transient failures,
* so just blindly retry for a short while
*/
|
