chrisd at apache
May 9, 2008, 6:15 PM
Post #1 of 1
(18 views)
Permalink
|
|
svn commit: r655001 - /httpd/httpd/branches/2.2.x/STATUS
|
|
Author: chrisd
Date: Fri May 9 18:15:06 2008
New Revision: 655001
URL: http://svn.apache.org/viewvc?rev=655001&view=rev
Log:
cast a vote, with explanation
Modified:
httpd/httpd/branches/2.2.x/STATUS
Modified: httpd/httpd/branches/2.2.x/STATUS
URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.2.x/STATUS?rev=655001&r1=655000&r2=655001&view=diff
==============================================================================
--- httpd/httpd/branches/2.2.x/STATUS (original)
+++ httpd/httpd/branches/2.2.x/STATUS Fri May 9 18:15:06 2008
@@ -132,7 +132,7 @@
http://svn.apache.org/viewvc?view=rev&revision=579664
Backport version of 2.2.x of patch:
Trunk version works (minus CHANGES conflict)
- +1: niq, wrowe [with chrisd's suggested change below]
+ +1: niq, wrowe [with chrisd's suggested change below], chrisd [as-is]
chrisd says: The patch seems to address the issues in the PR.
My only concern would be that the ap_location_walk() call
(the second one) expects r->uri. I'm fairly sure that
@@ -145,6 +145,15 @@
r->uri = "" (but not NULL, I think ...); we might as
well bypass <Location> checks on these, and also handle
any external modules that might try passing r->uri as NULL.
+ chrisd says: I did some testing with NULL and empty r->uri values
+ and concluded this change appears to be OK as it stands.
+ If r->uri is NULL then the preceding call to
+ ap_getparents() crashes, so no functional modules
+ could be doing this. As for empty r->uri values,
+ <Location ""> will match against these (along with
+ everything else), so we shouldn't bypass them.
+ (Such <Location> usage may not be what's expected, but
+ it works and could be in use by someone.)
* Support chroot on unix-family platforms
PR 43596
|
