Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: Apache: Bugs

[Bug 51696] Code clean up (remove a 1024 heap allocated buffer)

 

 

Apache bugs RSS feed   Index | Next | Previous | View Threaded


bugzilla at apache

Jul 10, 2012, 2:37 PM

Post #1 of 3 (104 views)
Permalink
[Bug 51696] Code clean up (remove a 1024 heap allocated buffer)

https://issues.apache.org/bugzilla/show_bug.cgi?id=51696

--- Comment #2 from Christophe JAILLET <christophe.jaillet [at] wanadoo> ---
Must be revisited due to some change in trunk.
Maybe should be closed now that the 1024 bytes buffer is gone.

Rearranging the code in 'make_cookie' could still be a win. It could avoid the
allocation of a buffer via apr_snprintf which is then apr_pstrdup'ed at the end
of the function.

This would save one of the 2 allocations which are strings build with: "%x.%"
APR_UINT64_T_HEX_FMT.

Would you like me to propose an updated patch ?

--
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe [at] httpd
For additional commands, e-mail: bugs-help [at] httpd


bugzilla at apache

Jul 10, 2012, 2:38 PM

Post #2 of 3 (99 views)
Permalink
[Bug 51696] Code clean up (remove a 1024 heap allocated buffer) [In reply to]

https://issues.apache.org/bugzilla/show_bug.cgi?id=51696

Christophe JAILLET <christophe.jaillet [at] wanadoo> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #27414|0 |1
is patch| |
Attachment #27414|application/octet-stream |text/plain
mime type| |

--
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe [at] httpd
For additional commands, e-mail: bugs-help [at] httpd


bugzilla at apache

Jul 22, 2012, 2:50 PM

Post #3 of 3 (81 views)
Permalink
[Bug 51696] Code clean up (remove a 1024 heap allocated buffer) [In reply to]

https://issues.apache.org/bugzilla/show_bug.cgi?id=51696

Jeff Trawick <trawick [at] apache> changed:

What |Removed |Added
----------------------------------------------------------------------------
Hardware|PC |All
OS|Windows 2000 |All

--
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe [at] httpd
For additional commands, e-mail: bugs-help [at] httpd

Apache bugs RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.