Hi

I am a kind of newsbie in perl and in regex

I would like to applys many regex to (my $cat_name_e = $cat->{cat_name})

So here is what I did : regex are good (I guess) but it is to way I did apply these regex to (my $cat_name_e = $cat->{cat_name}) that is wrong...

(my $cat_name_e = $cat->{cat_name}) =~s/[éèê]/e/g; #replace accent
(my $cat_name_e = $cat->{cat_name}) =~s/[àâ]/a/g; #replace accent
(my $cat_name_e = $cat->{cat_name}) =~s/ô/o/g; #replace accent
(my $cat_name_e = $cat->{cat_name}) =~s/î/i/g; #replace accent
(my $cat_name_e = $cat->{cat_name}) =~s/ç/c/g; #replace accent
(my $cat_name_e = $cat->{cat_name}) =~s/\W/-/g; #replace all non alphanumerics by hyphens
(my $cat_name_e = $cat->{cat_name}) =~s/---/--/g; #replace of hyphens
(my $cat_name_e = $cat->{cat_name}) =~s/--/-/g; #replace of hyphens

Txs
FMP

Hi FMP

try to replace $cat->{cat_name} with $cat{cat_name}.

Cheers,
Oliver

Hi

Txs for you answer

I have done the replace but I have a compilation error message

Regards
FMP

I guess the error looks like this:
"my" variable $cat_name_e masks earlier declaration in same scope at scriptfile.pl line X.

Only use "my" the first time before $cat_name_e and leave it away afterwards. Your code would look like this:



Hope this helps
Oliver

Why not use something like this? Or am I missing the point?


... or even better (probably);


(i.e with the \Q to escape the non-standard charchters, which could be causing the problem).

Hope that helps.

Andy (mod)
andy@ultranerds.co.uk

---

IMPORTANT: I've now moved to ultranerds.co.uk, and the .com will no longer work!
Want to give me something back for my help? Please see my Amazon Wish List
GLinks ULTRA Package (plugins total "value" $3,325 & rising, for just $350)| GLinks ULTRA Package PRO (plugins total "value" $5,625 & rising, for just $500)
Support Forum | Links SQL Plugins | DMOZ Dumps | UltraNerds | ULTRAGLobals Plugin | Pre-Made Template Sets | FREE GLinks Plugins!
Compare our different Plugin packages *new* Free CSS Templates

Hi Andy

thanks for your inputs - you're absolutely right that it's not necessary to repeat $cat_name_e = $cat{cat_name} on every line. And your code version is smaller .

Some additional comments/questions:

- my $cat_name_e = $cat->{cat_name} didn't work for me...
I had to use $cat_name_e = $cat{cat_name}.

- didn't you mean $cat_name_e =~... on line 3+ ?


All the best,
Oliver

Hi,


Whoops I've fixed this up in the above post.


It depends on where $cat is being defined.

It could either be;

$cat->{var_name}

...or

$cat{var_name}

FMP: Can we see where the $cat variable is generated?

Cheers

Andy (mod)
andy@ultranerds.co.uk

---

IMPORTANT: I've now moved to ultranerds.co.uk, and the .com will no longer work!
Want to give me something back for my help? Please see my Amazon Wish List
GLinks ULTRA Package (plugins total "value" $3,325 & rising, for just $350)| GLinks ULTRA Package PRO (plugins total "value" $5,625 & rising, for just $500)
Support Forum | Links SQL Plugins | DMOZ Dumps | UltraNerds | ULTRAGLobals Plugin | Pre-Made Template Sets | FREE GLinks Plugins!
Compare our different Plugin packages *new* Free CSS Templates

Thanks guys it works

I use these REGEX in the globals.txt file of the search_engine template of gossamer Forum product

I just want to make some changes in the generated URL

Original file was

# This file is auto generated and contains a perl hash of
# your template globals for 'default' template set.
# Generated on: Sat Jan 12 12:43:20 2002
# vim: syn=perl
{
'cat_full_name_linked' => q²sub {
my ($id, $sep, $pre, $suf) = @_;
my $cat_path = GT::Template->tags()->{cat_path}; # See "cat_path" global var below
$sep ||= ': ';
$pre ||= '';
$pre =~ s/%/%%/g;
$suf ||= '';
$suf =~ s/%/%%/g;
my $url = '/forum';
my $category = qq|<a href="%s">$pre%s$suf</a>|;
if (!$GForum::CAT_CACHE{$id}) {
my $Cat = $DB->table('Category');
my $cat = $Cat->get({ cat_id => $id }, 'HASH', ['cat_id', 'cat_name', 'cat_id_fk']);
push @{$GForum::CAT_CACHE{$id}}, $cat;
while ($cat = $Cat->get({ cat_id => $cat->{cat_id_fk} }, 'HASH', ['cat_id', 'cat_name', 'cat_id_fk'])) {
push @{$GForum::CAT_CACHE{$id}}, $cat;
}
}
my @cats = @{$GForum::CAT_CACHE{$id}};
my $cat = shift @cats;
my $cat_name = sprintf($category, ${$cat_path->($id)}, $cat->{cat_name});
for (@cats) {
$cat_name = sprintf($category, ${$cat_path->($_->{cat_id})}, $_->{cat_name}) . $sep . $cat_name;
}
return \$cat_name;
}²,
escape_name => q²sub {
my $name = shift;
$name =~ y/ \t\r\n?"'#/__/d;
$name = $IN->escape($name);
$name =~ s|%2F|/|gi; # For some reason, Apache doesn't like %2F in the pathinfo, but a real / is fine
\$name;
}²,
cat_path => q²sub {
my $id = shift;
my $category = q|%s_C%d/|;
if (!$GForum::CAT_CACHE{$id}) {
my $Cat = $DB->table('Category');
my $cat = $Cat->get({ cat_id => $id }, 'HASH', ['cat_id', 'cat_name', 'cat_id_fk']);
push @{$GForum::CAT_CACHE{$id}}, $cat;
while ($cat = $Cat->get({ cat_id => $cat->{cat_id_fk} }, 'HASH', ['cat_id', 'cat_name', 'cat_id_fk'])) {
push @{$GForum::CAT_CACHE{$id}}, $cat;
}
}
my @cats = @{$GForum::CAT_CACHE{$id}};
my $cat = shift @cats;
(my $cat_name_e = $cat->{cat_name}) =~ y/ \t\r\n?"'#/__/d;
my $cat_name = sprintf($category, $cat_name_e, $id);
for (@cats) {
($cat_name_e = $_->{cat_name}) =~ y/ \t\r\n?"'#/__/d;
$cat_name = sprintf($category, $cat_name_e, $_->{cat_id}) . $cat_name;
}
return \"/forum/$cat_name";
}²,
};

Would this not be a good time to use tr/ instead of multiple s/ (to replace the accents, not the hyphen stuff)?

I use this in one of my scripts:

Might be overkill in this case but it gets the job done for me.

Thoughts?